<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110129/">http://git.reviewboard.kde.org/r/110129/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">hmm if it is asyncronious how do you ensure that the signal is from the document in question and not from a previous loaded one as in:
start load
start load
emit loadCompleted <- which of the two does it refer to</pre>
<br />
<p>- C.</p>
<br />
<p>On May 1st, 2013, 7:59 a.m. UTC, Dmitry Kazakov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Dmitry Kazakov.</div>
<p style="color: grey;"><i>Updated May 1, 2013, 7:59 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have added a signal which is emitted when KoMainWindow finishes loading of the document. This is needed, because the loading of remote (via http and etc.) documents happens asynchronously, and we need to know when we can remove the old window, because it has some links with it.
This fixes the bug:
https://bugs.kde.org/show_bug.cgi?id=318560
Pushed into my branch:
http://commits.kde.org/calligra/c49444def062bc37435992fb7546c944c754f6b6</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Testing done with Krita only. But it doesn't change anythink for other applications.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/ui/kis_import_catcher.h <span style="color: grey">(9be44ca)</span></li>
<li>krita/ui/kis_import_catcher.cc <span style="color: grey">(8224df8)</span></li>
<li>krita/ui/kis_view2.cpp <span style="color: grey">(9108c35)</span></li>
<li>libs/main/KoMainWindow.h <span style="color: grey">(550ab33)</span></li>
<li>libs/main/KoMainWindow.cpp <span style="color: grey">(a739cbb)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110129/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>