<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110383/">http://git.reviewboard.kde.org/r/110383/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Some small nitpicks, but for the krita/libs part: ship it. The Words part is for Camilla to determine.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110383/diff/1/?file=142898#file142898line346" style="color: black; font-weight: bold; text-decoration: underline;">libs/main/KoMainWindow.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KoMainWindow::KoMainWindow(const KComponentData &componentData)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">346</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">d</span><span class="o">-></span><span class="n">toggleDockers</span><span class="o">-></span><span class="n">setShortcut</span><span class="p">(</span><span class="n">QKeySequence</span><span class="p">(</span><span class="n">Qt</span><span class="o">::</span><span class="n">CTRL</span> <span class="o">+</span> <span class="n">Qt</span><span class="o">::</span><span class="n">Key_H</span><span class="p">));</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">346</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1"><span class="hl">//</span>d->toggleDockers->setShortcut(QKeySequence(Qt::CTRL + Qt::Key_H));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Best just completely remove the commented-out line.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110383/diff/1/?file=142899#file142899line59" style="color: black; font-weight: bold; text-decoration: underline;">libs/main/KoView.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">59</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include <ktoolbar.h></span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Are these added includes still needed?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110383/diff/1/?file=142907#file142907line788" style="color: black; font-weight: bold; text-decoration: underline;">words/part/KWView.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">788</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">// Handle stause bar & horizonta scroll bar.</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">typo: status and horizontal</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110383/diff/1/?file=142907#file142907line798" style="color: black; font-weight: bold; text-decoration: underline;">words/part/KWView.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">798</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">// Handle verticl scroll bar.</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">typo: vertical</pre>
</div>
<br />
<p>- Boudewijn</p>
<br />
<p>On May 10th, 2013, 5:54 p.m. UTC, mojtaba shahi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By mojtaba shahi.</div>
<p style="color: grey;"><i>Updated May 10, 2013, 5:54 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Implement Distraction-Free mode for Words and Author.
Added an action "View->Distractio Free Mode". This action Hide Menu bar, Tool bar, Staus bar, Dock widgets ,Vertical and horizontl scroll bar from view.
When you switch to Distractio-Free mode it will rise a floating message say how can you get out from this view.
I have added a "Exit Distractio-Free Mode" button to status bar that user can get back to normal view by clicking ont it. (it is visible just in DF mode)
Staus bar will show if user moves mouse on status bar at bottom.
Horizontal and Vertical scroll bars will show when user moves mouse on them.
Cursor will Hide, user doesn't move mouse after 4 seconds.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/plugins/tools/tool_crop/kis_tool_crop.cc <span style="color: grey">(05e905b)</span></li>
<li>krita/ui/CMakeLists.txt <span style="color: grey">(37e4635)</span></li>
<li>krita/ui/kis_view2.cpp <span style="color: grey">(7d4c6da)</span></li>
<li>krita/ui/tool/kis_tool.cc <span style="color: grey">(33dbbf0)</span></li>
<li>krita/ui/widgets/kis_floating_message.h <span style="color: grey">(0d42e8b)</span></li>
<li>krita/ui/widgets/kis_floating_message.cpp <span style="color: grey">(d53e133)</span></li>
<li>libs/main/KoMainWindow.cpp <span style="color: grey">(ea45075)</span></li>
<li>libs/main/KoView.cpp <span style="color: grey">(c9c82e5)</span></li>
<li>libs/widgets/CMakeLists.txt <span style="color: grey">(4e6e362)</span></li>
<li>libs/widgets/KoFloatingMessage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/widgets/KoFloatingMessage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/KWCanvas.cpp <span style="color: grey">(4252ff7)</span></li>
<li>words/part/KWGui.h <span style="color: grey">(c72234d)</span></li>
<li>words/part/KWGui.cpp <span style="color: grey">(803e1b5)</span></li>
<li>words/part/KWView.h <span style="color: grey">(6357876)</span></li>
<li>words/part/KWView.cpp <span style="color: grey">(5c1cc70)</span></li>
<li>words/part/author/author.rc <span style="color: grey">(b3b187c)</span></li>
<li>words/part/words.rc <span style="color: grey">(d2269d1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110383/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/05/10/distraction-free_mode_1.png">Distraction-Free Mode</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/05/10/distraction-free_mode_2.png">Distraction-Free mode with Status bar</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/05/10/distraction-free_mode_3.png">Distraction-Free mode with vertical scroll bar</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>