Hi,<br>After 2 months of waiting because it's high time for 2.7, I committed this breaking the review rule. But I don't know what's the reason that nobody reviewed. Is the change too large or complicated? <br><br>
Or what to do to get general (i.e. checking style, obvious mistakes, too complex areas) reviews from non-Kexi people from Calligra? I sometimes review non-Kexi code, without particular pattern, can I count for the same?<br>
<br><font size="4"><font face="courier new,monospace"></font></font><br><div class="gmail_quote">On 4 May 2013 23:37, Commit Hook <span dir="ltr"><<a href="mailto:null@kde.org" target="_blank">null@kde.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div style="font-family:Verdana,Arial,Helvetica,Sans-Serif"><div>
<table style="border:1px #c9c399 solid" bgcolor="#f9f3c9" cellpadding="8" width="100%">
<tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109214/" target="_blank">http://git.reviewboard.kde.org/r/109214/</a>
</td>
</tr>
</tbody></table>
<br>
</div><pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">This review has been submitted with commit 701ea7a1ba30a490e52b9b25e1b7df31b14fa811 by Jaroslaw Staniek to branch calligra/2.7.</pre>
<span><font color="#888888">
<br>
<p>- Commit</p></font></span><div><div>
<br>
<p>On March 19th, 2013, 10:59 p.m. UTC, Jarosław Staniek wrote:</p>
<table style="background-image:url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png');background-repeat:repeat-x;border:1px black solid" bgcolor="#fefadf" cellpadding="8" cellspacing="0" width="100%">
<tbody><tr>
<td>
<div>Review request for Calligra, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, and Radosław Wicik.</div>
<div>By Jarosław Staniek.</div>
<p style="color:grey"><i>Updated March 19, 2013, 10:59 p.m.</i></p>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
<table style="border:1px solid #b8b5a0" bgcolor="#ffffff" cellpadding="10" cellspacing="0" width="100%">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Main Window
*[code] Message handler now can set redirection to other handler (needed to cleanly implement error callouts for the Welcome assistant)
*[code] Improved message handler API
*Kexi asks for passwords directly on pages without modal dialogs (for New, Open, Welcome assistants) - sample at <a href="http://wstaw.org/m/2013/03/01/plasma-desktopZA2566.png" target="_blank">http://wstaw.org/m/2013/03/01/plasma-desktopZA2566.png</a>
*Improved layout of the context message widget
*Improved support for moving back to previous assistant page
KexiDB
*[code] ConnectionData now "knows" if specifing password is needed for performing connection</pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Testing </h1>
<table style="border:1px solid #b8b5a0" bgcolor="#ffffff" cellpadding="10" cellspacing="0" width="100%">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Executed New/Open/Welcome assistants with server connections requiring passowrds, password pages work; tested layouts</pre>
</td>
</tr>
</tbody></table>
<div style="margin-top:1.5em">
<b style="color:#575012;font-size:10pt;margin-top:1.5em">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=313025" target="_blank">313025</a>
</div>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">
<li>kexi/core/kexi.cpp <span style="color:grey">(087183fcb3786ea795dbdb214b8f27e4517df597)</span></li>
<li>kexi/core/kexiguimsghandler.h <span style="color:grey">(50a078f00b65c67da6f38a940cb0d7cc6c0f65a3)</span></li>
<li>kexi/core/kexiguimsghandler.cpp <span style="color:grey">(964e561c5f510a9d53c12f18527d8e6a2691376e)</span></li>
<li>kexi/core/kexitextmsghandler.h <span style="color:grey">(6c0717fa07530a82bfcb3b5b3f88718e372aed6a)</span></li>
<li>kexi/core/kexitextmsghandler.cpp <span style="color:grey">(0001e8a67b1d4458ae1b223845cf9ebf9870c54e)</span></li>
<li>kexi/kexiutils/KexiAssistantPage.h <span style="color:grey">(6b494e020fe0f6c7604b8732cc77813830961d9d)</span></li>
<li>kexi/kexiutils/KexiAssistantPage.cpp <span style="color:grey">(a5f8df7b0d0ed814c8e80a8977ec6c96a0dcc454)</span></li>
<li>kexi/kexiutils/KexiAssistantWidget.h <span style="color:grey">(8497b6fc8ce787ab1452764cbc706b2b20b8a383)</span></li>
<li>kexi/kexiutils/KexiAssistantWidget.cpp <span style="color:grey">(aba01422f08c2fd7ff6eec0a74c996d93152a2a9)</span></li>
<li>kexi/kexiutils/KexiContextMessage.cpp <span style="color:grey">(b7f533ee82196b21ce23d2cbba6402e8937705a3)</span></li>
<li>kexi/kexiutils/kmessagewidget.cpp <span style="color:grey">(f4b8ea98811179bc7cebc80367d60b7f87979348)</span></li>
<li>kexi/kexiutils/kpassworddialog.ui <span style="color:grey">(PRE-CREATION)</span></li>
<li>kexi/main/CMakeLists.txt <span style="color:grey">(9d80ac0f7e550aa53744cdcd04bc0ab079860edb)</span></li>
<li>kexi/main/KexiMainWindow.cpp <span style="color:grey">(1383610d13b3d5f0d5f5205af42a91a4daff0580)</span></li>
<li>kexi/main/startup/KexiAssistantMessageHandler.h <span style="color:grey">(PRE-CREATION)</span></li>
<li>kexi/main/startup/KexiAssistantMessageHandler.cpp <span style="color:grey">(PRE-CREATION)</span></li>
<li>kexi/main/startup/KexiImportExportAssistant.h <span style="color:grey">(b55d94b67099cf4979f1250ebcadeba93ed6274a)</span></li>
<li>kexi/main/startup/KexiImportExportAssistant.cpp <span style="color:grey">(90f87ae4051b61ebabcd2924e9c209a7dab2bf51)</span></li>
<li>kexi/main/startup/KexiNewProjectAssistant.h <span style="color:grey">(d80fa08993dc603eab3688f38917b39990e9b521)</span></li>
<li>kexi/main/startup/KexiNewProjectAssistant.cpp <span style="color:grey">(201a3345bfc48cb3a1f76ed2e0b0b9e703f63a79)</span></li>
<li>kexi/main/startup/KexiOpenProjectAssistant.h <span style="color:grey">(599d1ea262b9150cc8f9d504349251a6a51b082a)</span></li>
<li>kexi/main/startup/KexiOpenProjectAssistant.cpp <span style="color:grey">(324e7438e0955912d20e590b69c613c050d76180)</span></li>
<li>kexi/main/startup/KexiPasswordPage.h <span style="color:grey">(PRE-CREATION)</span></li>
<li>kexi/main/startup/KexiPasswordPage.cpp <span style="color:grey">(PRE-CREATION)</span></li>
<li>kexi/main/startup/KexiStartup.h <span style="color:grey">(c1807b295d623d1fed1d8dd501d55905d0f7915e)</span></li>
<li>kexi/main/startup/KexiStartup.cpp <span style="color:grey">(b11bf529efdfd21053b95722060a01342067b7a6)</span></li>
<li>kexi/main/startup/KexiWelcomeAssistant.h <span style="color:grey">(c5b751bc0f597f7a11c6ae61e26ed618d9edf21a)</span></li>
<li>kexi/main/startup/KexiWelcomeAssistant.cpp <span style="color:grey">(4ca9b18946759729ccbf1df6793e84585ad96238)</span></li>
<li>kexi/widget/CMakeLists.txt <span style="color:grey">(991c5e62e0e7ac857554709a9bb3110d40f3170d)</span></li>
<li>kexi/widget/KexiPasswordWidget.h <span style="color:grey">(PRE-CREATION)</span></li>
<li>kexi/widget/KexiPasswordWidget.cpp <span style="color:grey">(PRE-CREATION)</span></li>
<li>kexi/widget/KexiPasswordWidget.ui <span style="color:grey">(PRE-CREATION)</span></li>
<li>libs/db/connectiondata.h <span style="color:grey">(3bdc0ac9dea7cd6623d7706a8578d8b6739a5b34)</span></li>
<li>libs/db/connectiondata.cpp <span style="color:grey">(4c75f5c18a7a5db1568f92a1ea301ce0e8766151)</span></li>
<li>libs/db/msghandler.h <span style="color:grey">(4f0faba74520f25f6fba7de2dfd1116478d6ccb6)</span></li>
<li>libs/db/msghandler.cpp <span style="color:grey">(f575453f7afce43c5641436788cada6fed4174a5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109214/diff/" style="margin-left:3em" target="_blank">View Diff</a></p>
</td>
</tr>
</tbody></table>
</div></div></div>
</div>
</blockquote></div><br><br clear="all"><br>-- <br><div dir="ltr">regards / pozdrawiam, Jaroslaw Staniek<br> Kexi & Calligra & KDE | <a href="http://calligra.org/kexi" target="_blank">http://calligra.org/kexi</a> | <a href="http://kde.org" target="_blank">http://kde.org</a><br>
Qt Certified Specialist | <a href="http://qt-project.org" target="_blank">http://qt-project.org</a><br> <a href="http://www.linkedin.com/in/jstaniek" target="_blank">http://www.linkedin.com/in/jstaniek</a></div>