<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110087/">http://git.reviewboard.kde.org/r/110087/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 21st, 2013, 6:15 a.m. UTC, <b>Cyrille Berger Skott</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">But if you could add some documentation explaining the use of:
KoColorConversionTransformation::InternalRenderingIntent
KoColorConversionTransformation::InternalConversionFlags
KoColorConversionTransformation::AdjustmentRenderingIntent
KoColorConversionTransformation::AdjustmentConversionFlags</pre>
<br />
<p>- Cyrille</p>
<br />
<p>On April 20th, 2013, 5:04 a.m. UTC, Dmitry Kazakov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Cyrille Berger Skott.</div>
<div>By Dmitry Kazakov.</div>
<p style="color: grey;"><i>Updated April 20, 2013, 5:04 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch make the use of internal rendering intents and conversion flags consistent. Now there are four constants, which should be used throughout all the code:
KoColorConversionTransformation::InternalRenderingIntent
KoColorConversionTransformation::InternalConversionFlags
KoColorConversionTransformation::AdjustmentRenderingIntent
KoColorConversionTransformation::AdjustmentConversionFlags
The latter two are used in the adjustment transformations. They disable white point workaround in lcms to ensure the Brightness/Contrast and friends transformations work fine.
This fixes bug: https://bugs.kde.org/show_bug.cgi?id=318434
You can find some more docs in the commit to my branch:
http://commits.kde.org/calligra/3699f54e822084e8153192ae3fbb85358b33c5ed</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/image/kis_cross_device_color_picker.h <span style="color: grey">(eb59305)</span></li>
<li>krita/image/kis_fixed_paint_device.h <span style="color: grey">(ede6c13)</span></li>
<li>krita/image/kis_fixed_paint_device.cpp <span style="color: grey">(5f98352)</span></li>
<li>krita/image/kis_group_layer.cc <span style="color: grey">(af12663)</span></li>
<li>krita/image/kis_image.cc <span style="color: grey">(73c0cfb)</span></li>
<li>krita/image/kis_layer.cc <span style="color: grey">(6722b3e)</span></li>
<li>krita/image/kis_mask.cc <span style="color: grey">(f17fe01)</span></li>
<li>krita/image/kis_paint_device.h <span style="color: grey">(9d68a29)</span></li>
<li>krita/image/kis_paint_device.cc <span style="color: grey">(8c0cdd5)</span></li>
<li>krita/image/kis_painter.cc <span style="color: grey">(5849749)</span></li>
<li>krita/image/kis_selection_based_layer.cpp <span style="color: grey">(4888c0c)</span></li>
<li>krita/image/tests/kis_colorspace_convert_visitor_test.cpp <span style="color: grey">(e5835c9)</span></li>
<li>krita/image/tests/kis_image_test.cpp <span style="color: grey">(040d32f)</span></li>
<li>krita/image/tests/kis_selection_test.cpp <span style="color: grey">(7c6141f)</span></li>
<li>krita/plugins/extensions/dockers/advancedcolorselector/kis_common_colors.cpp <span style="color: grey">(006e0ae)</span></li>
<li>krita/plugins/extensions/dockers/historydocker/KisUndoModel.cpp <span style="color: grey">(0839e17)</span></li>
<li>krita/plugins/filters/fastcolortransfer/fastcolortransfer.cpp <span style="color: grey">(32433e6)</span></li>
<li>krita/plugins/filters/fastcolortransfer/kis_wdg_fastcolortransfer.cpp <span style="color: grey">(417c79e)</span></li>
<li>krita/plugins/filters/phongbumpmap/kis_phong_bumpmap_filter.cpp <span style="color: grey">(d5828cd)</span></li>
<li>krita/plugins/formats/bmp/kis_bmp_export.cpp <span style="color: grey">(2d84ee9)</span></li>
<li>krita/plugins/formats/jpeg/kis_jpeg_converter.cc <span style="color: grey">(33ec941)</span></li>
<li>krita/plugins/formats/ppm/kis_ppm_export.cpp <span style="color: grey">(60fcc59)</span></li>
<li>krita/plugins/formats/tiff/kis_tiff_converter.cc <span style="color: grey">(695d9e5)</span></li>
<li>krita/plugins/paintops/libbrush/kis_brush.cpp <span style="color: grey">(0763779)</span></li>
<li>krita/plugins/paintops/libbrush/kis_gbr_brush.cpp <span style="color: grey">(94c754a)</span></li>
<li>krita/plugins/paintops/mypaint/hint.txt <span style="color: grey">(e04c4c2)</span></li>
<li>krita/plugins/paintops/mypaint/mypaint_surface.cpp <span style="color: grey">(1fb755a)</span></li>
<li>krita/plugins/tools/tool_transform2/kis_tool_transform.cc <span style="color: grey">(a13cb17)</span></li>
<li>krita/ui/kis_bookmarked_filter_configurations_model.cc <span style="color: grey">(acbf097)</span></li>
<li>krita/ui/kis_clipboard.cc <span style="color: grey">(cb810f3)</span></li>
<li>krita/ui/kis_custom_pattern.cc <span style="color: grey">(9b76e2b)</span></li>
<li>krita/ui/kis_filters_model.cc <span style="color: grey">(9b940ae)</span></li>
<li>krita/ui/kis_mimedata.cpp <span style="color: grey">(a2305c0)</span></li>
<li>krita/ui/kis_png_converter.cpp <span style="color: grey">(3379a30)</span></li>
<li>krita/ui/tests/kis_prescaled_projection_test.cpp <span style="color: grey">(882e012)</span></li>
<li>krita/ui/widgets/kis_scratch_pad.cpp <span style="color: grey">(036cd1c)</span></li>
<li>libs/pigment/KoColor.cpp <span style="color: grey">(ad7abd9)</span></li>
<li>libs/pigment/KoColorConversionSystem.cpp <span style="color: grey">(9a6dc8f)</span></li>
<li>libs/pigment/KoColorConversionTransformation.h <span style="color: grey">(975575d)</span></li>
<li>libs/pigment/KoColorConversionTransformation.cpp <span style="color: grey">(753bd7f)</span></li>
<li>libs/pigment/KoColorSpace.cpp <span style="color: grey">(1489515)</span></li>
<li>libs/pigment/KoCopyColorConversionTransformation.cpp <span style="color: grey">(bc96290)</span></li>
<li>libs/pigment/KoFallBackColorTransformation.cpp <span style="color: grey">(c8008f0)</span></li>
<li>libs/pigment/KoScaleColorConversionTransformation.h <span style="color: grey">(347510b)</span></li>
<li>libs/pigment/colorspaces/KoSimpleColorSpace.h <span style="color: grey">(85eeaa6)</span></li>
<li>libs/pigment/colorspaces/KoSimpleColorSpaceEngine.cpp <span style="color: grey">(0566475)</span></li>
<li>plugins/colorengines/lcms2/LcmsColorSpace.h <span style="color: grey">(ac88351)</span></li>
<li>plugins/colorengines/lcms2/tests/TestKoCompositeOps.cpp <span style="color: grey">(1dee8af)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110087/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>