<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109994/">http://git.reviewboard.kde.org/r/109994/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Regarding the code: I did a cursory overview of the code. In general it looks very nice so kudos. I noted a few things that I saw which should be fixed. I will look at it in more detail tomorrow.
Tonight I will try out the branch but I expect that the build times will be long so I don't have time to do that now. I will be back with more comments after that.
Do you know if the QtMML widget is maintained? It would be good if we didn't have to maintain it ourselves...</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109994/diff/1/?file=138544#file138544line1791" style="color: black; font-weight: bold; text-decoration: underline;">libs/odf/KoXmlReader.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static void itemAsQDomNode(QDomDocument& ownerDoc, KoXmlPackedDocument* packedDoc,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">1791</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">packedDoc</span><span class="o">-></span><span class="n">processNamespace</span><span class="p">)</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1791</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">packedDoc</span><span class="o">-></span><span class="n">processNamespace</span><span class="hl"> </span><span class="o"><span class="hl">&&</span></span><span class="hl"> </span><span class="n"><span class="hl">i</span></span><span class="hl"> </span><span class="o"><span class="hl">!=</span></span><span class="hl"> </span><span class="o"><span class="hl">-</span></span><span class="mi"><span class="hl">1</span></span><span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If this is a real bugfix, it should go into master immediately and not in the branch.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109994/diff/1/?file=138544#file138544line1884" style="color: black; font-weight: bold; text-decoration: underline;">libs/odf/KoXmlReader.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static void itemAsQDomNode(QDomDocument& ownerDoc, KoXmlPackedDocument* packedDoc,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">1884</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">packedDoc</span><span class="o">-></span><span class="n">processNamespace</span><span class="p">)</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1884</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">packedDoc</span><span class="o">-></span><span class="n">processNamespace</span><span class="hl"> </span><span class="o"><span class="hl">&&</span></span><span class="hl"> </span><span class="n"><span class="hl">i</span></span><span class="hl"> </span><span class="o"><span class="hl">!=</span></span><span class="hl"> </span><span class="o"><span class="hl">-</span></span><span class="mi"><span class="hl">1</span></span><span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">...and same here, of course.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109994/diff/1/?file=138558#file138558line149" style="color: black; font-weight: bold; text-decoration: underline;">plugins/staging/formulashape-2g/FormulaShape.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">149</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span> <span class="n">url</span><span class="p">.</span><span class="n">startsWith</span><span class="p">(</span> <span class="s">"./"</span> <span class="p">)</span> <span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As a general rule, we don't use spaces inside parenthesis.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109994/diff/1/?file=138569#file138569line2" style="color: black; font-weight: bold; text-decoration: underline;">plugins/staging/formulashape-2g/formulashape2g.desktop</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">2</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">Name=Formula Shape 2G</pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That it's 2nd generation is not relevant for users so "Formula Shape" should be enough"</pre>
</div>
<br />
<p>- Inge</p>
<br />
<p>On April 13th, 2013, 3:03 p.m. UTC, Gopalakrishna Bhat wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Gopalakrishna Bhat.</div>
<p style="color: grey;"><i>Updated April 13, 2013, 3:03 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This new implementation for formulashape uses and improves on qtmmlwidgets that was part of Qt Solutions. The code can be found in plugins-formulashape2g-gopalK branch.
Currently implemented features are
1) Loading of formulas in document.
2) Insert of MathML formulas generated from some other tools(viz FireMath plugin for Firefox)
3) Editing of existing formulas.
Features that were there in old version of formulashape but missing now
1) Insert of Elements, Symbols (in a very much unusable state)
2) Edit formulas with LaTeX syntax (Will be done in coming days)
I will remove the extra whitespace that exists in the uploaded diff before merging :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/odf/KoXmlReader.cpp <span style="color: grey">(b5fe9f8)</span></li>
<li>plugins/staging/formulashape-2g/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/FormulaToolFactory.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/FormulaToolFactory.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/FormulaTool.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/FormulaTool.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/FormulaShapePlugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/FormulaShapePlugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/FormulaShapeFactory.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/FormulaShapeFactory.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/FormulaShape.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/FormulaShape.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/FormulaPart.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/FormulaPart.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/FormulaDocument.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/FormulaDocument.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/FormulaCursor.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/FormulaCursor.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/ChangeFormulaCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/ChangeFormulaCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/AlterFormulaCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/AlterFormulaCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/CMakeLists.txt <span style="color: grey">(754362f)</span></li>
<li>plugins/staging/formulashape-2g/formula_export.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/formulashape2g.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/qtmmlwidget/LGPL_EXCEPTION.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/qtmmlwidget/LICENSE.GPL3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/qtmmlwidget/LICENSE.LGPL <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/qtmmlwidget/QtMmlDocument <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/qtmmlwidget/QtMmlWidget <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/qtmmlwidget/README.TXT <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/qtmmlwidget/qtmmlwidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/qtmmlwidget/qtmmlwidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109994/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/04/13/formulaShape.png">Snapshot</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>