<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109897/">http://git.reviewboard.kde.org/r/109897/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 206c7120fbcd737692d7d78120f70ee2f5e6a946 by Friedrich W. H. Kossebau to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On April 7th, 2013, 8:32 p.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Sven Langkamp and Boudewijn Rempt.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated April 7, 2013, 8:32 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This seems a left-over from KDE3/Qt3 times, spacings and margins should be completely controlled by the style IMHO. Only exceptions should be setting the values to 0 to not have any margins/spacings, or if there is some pixel-perfect layouting done.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/plugins/extensions/colorrange/wdg_colorrange.ui <span style="color: grey">(37e64c3)</span></li>
<li>krita/plugins/extensions/colorspaceconversion/wdgconvertcolorspace.ui <span style="color: grey">(b31861b)</span></li>
<li>krita/plugins/extensions/compose/wdg_compose.ui <span style="color: grey">(91a1788)</span></li>
<li>krita/plugins/extensions/dockers/defaultdockers/wdglayerbox.ui <span style="color: grey">(ecfd983)</span></li>
<li>krita/plugins/extensions/dropshadow/wdg_dropshadow.ui <span style="color: grey">(f03818a)</span></li>
<li>krita/plugins/extensions/histogram/wdghistogram.ui <span style="color: grey">(f80c3c1)</span></li>
<li>krita/plugins/extensions/imagesize/wdg_canvassize.ui <span style="color: grey">(056b545)</span></li>
<li>krita/plugins/extensions/imagesize/wdg_imagesize.ui <span style="color: grey">(2c0a2ab)</span></li>
<li>krita/plugins/extensions/imagesize/wdg_layersize.ui <span style="color: grey">(94e71a2)</span></li>
<li>krita/plugins/extensions/imagesplit/wdg_imagesplit.ui <span style="color: grey">(601f5ab)</span></li>
<li>krita/plugins/extensions/modify_selection/wdg_border_selection.ui <span style="color: grey">(73d983b)</span></li>
<li>krita/plugins/extensions/modify_selection/wdg_feather_selection.ui <span style="color: grey">(af505ab)</span></li>
<li>krita/plugins/extensions/modify_selection/wdg_grow_selection.ui <span style="color: grey">(8b3b8c4)</span></li>
<li>krita/plugins/extensions/modify_selection/wdg_shrink_selection.ui <span style="color: grey">(234aab5)</span></li>
<li>krita/plugins/extensions/offsetimage/wdg_offsetimage.ui <span style="color: grey">(2ab32ff)</span></li>
<li>krita/plugins/extensions/rotateimage/wdg_rotateimage.ui <span style="color: grey">(e721842)</span></li>
<li>krita/plugins/extensions/separate_channels/wdg_separations.ui <span style="color: grey">(5ed2c89)</span></li>
<li>krita/plugins/extensions/shearimage/wdg_shearimage.ui <span style="color: grey">(4bd9c4d)</span></li>
<li>krita/plugins/filters/blur/wdg_gaussian_blur.ui <span style="color: grey">(dc1e594)</span></li>
<li>krita/plugins/filters/blur/wdg_lens_blur.ui <span style="color: grey">(7993830)</span></li>
<li>krita/plugins/filters/blur/wdg_motion_blur.ui <span style="color: grey">(729bc4f)</span></li>
<li>krita/plugins/filters/blur/wdgblur.ui <span style="color: grey">(4b7535c)</span></li>
<li>krita/plugins/filters/colors/wdgcolortoalphabase.ui <span style="color: grey">(2dcc3d4)</span></li>
<li>krita/plugins/filters/colorsfilters/wdg_brightness_contrast.ui <span style="color: grey">(f462b7b)</span></li>
<li>krita/plugins/filters/colorsfilters/wdg_perchannel.ui <span style="color: grey">(a8872b6)</span></li>
<li>krita/plugins/filters/dodgeburn/DodgeBurnConfigurationBaseWidget.ui <span style="color: grey">(975e1e7)</span></li>
<li>krita/plugins/filters/fastcolortransfer/wdgfastcolortransfer.ui <span style="color: grey">(c97eb5b)</span></li>
<li>krita/plugins/filters/levelfilter/wdg_level.ui <span style="color: grey">(cda6ffc)</span></li>
<li>krita/plugins/filters/noisefilter/wdgnoiseoptions.ui <span style="color: grey">(cdf8b07)</span></li>
<li>krita/plugins/filters/randompickfilter/wdgrandompickoptions.ui <span style="color: grey">(5800237)</span></li>
<li>krita/plugins/filters/unsharp/wdgunsharp.ui <span style="color: grey">(152ef9f)</span></li>
<li>krita/plugins/filters/wavefilter/wdgwaveoptions.ui <span style="color: grey">(c70d62e)</span></li>
<li>krita/plugins/formats/pdf/pdfimportwidgetbase.ui <span style="color: grey">(506fd49)</span></li>
<li>krita/plugins/formats/png/kis_wdg_options_png.ui <span style="color: grey">(85f6f57)</span></li>
<li>krita/plugins/formats/raw/wdgrawimport.ui <span style="color: grey">(6a78272)</span></li>
<li>krita/plugins/formats/tiff/kis_wdg_options_tiff.ui <span style="color: grey">(f1f7389)</span></li>
<li>krita/plugins/generators/solid/wdgcoloroptions.ui <span style="color: grey">(936def0)</span></li>
<li>krita/plugins/paintops/libpaintop/forms/wdgcustombrush.ui <span style="color: grey">(cd6eb34)</span></li>
<li>krita/plugins/tools/defaulttools/kis_tool_measure.cc <span style="color: grey">(223f317)</span></li>
<li>krita/plugins/tools/defaulttools/wdgcolorpicker.ui <span style="color: grey">(7d1c711)</span></li>
<li>krita/plugins/tools/tool_crop/wdg_tool_crop.ui <span style="color: grey">(08bc2ca)</span></li>
<li>krita/plugins/tools/tool_text/wdgtextoptions.ui <span style="color: grey">(5560fc0)</span></li>
<li>krita/ui/dialogs/kis_dlg_adj_layer_props.cc <span style="color: grey">(70a389c)</span></li>
<li>krita/ui/forms/kis_matrix_widget.ui <span style="color: grey">(63c1e97)</span></li>
<li>krita/ui/forms/kis_previewwidgetbase.ui <span style="color: grey">(2faa678)</span></li>
<li>krita/ui/forms/wdg_resolution.ui <span style="color: grey">(1108a6e)</span></li>
<li>krita/ui/forms/wdgapplyprofile.ui <span style="color: grey">(7dd5d71)</span></li>
<li>krita/ui/forms/wdgautogradient.ui <span style="color: grey">(2b157b7)</span></li>
<li>krita/ui/forms/wdgbookmarkedconfigurationseditor.ui <span style="color: grey">(0054dbf)</span></li>
<li>krita/ui/forms/wdgcolorsettings.ui <span style="color: grey">(cee3691)</span></li>
<li>krita/ui/forms/wdgcustompalette.ui <span style="color: grey">(65f4ea3)</span></li>
<li>krita/ui/forms/wdgdisplaysettings.ui <span style="color: grey">(8ac25c7)</span></li>
<li>krita/ui/forms/wdgdlgblacklistcleanup.ui <span style="color: grey">(c99ccc0)</span></li>
<li>krita/ui/forms/wdgflipbookselector.ui <span style="color: grey">(dca0ab7)</span></li>
<li>krita/ui/forms/wdggeneralsettings.ui <span style="color: grey">(f4e80c0)</span></li>
<li>krita/ui/forms/wdggridsettings.ui <span style="color: grey">(eab3c57)</span></li>
<li>krita/ui/forms/wdgimageproperties.ui <span style="color: grey">(4f1e2a9)</span></li>
<li>krita/ui/forms/wdglayerproperties.ui <span style="color: grey">(d952ab7)</span></li>
<li>krita/ui/forms/wdgnewimage.ui <span style="color: grey">(a9f1a27)</span></li>
<li>krita/ui/forms/wdgperformancesettings.ui <span style="color: grey">(cca6e5f)</span></li>
<li>krita/ui/forms/wdgselectionoptions.ui <span style="color: grey">(19fc539)</span></li>
<li>krita/ui/forms/wdgshapeoptions.ui <span style="color: grey">(65c0e9c)</span></li>
<li>krita/ui/forms/wdgtabletsettings.ui <span style="color: grey">(dd0cde5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109897/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>