<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109888/">http://git.reviewboard.kde.org/r/109888/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Cyrille Berger Skott.</div>
<div>By Friedrich W. H. Kossebau.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">On startup of Braindump there are a few warnings about broken signal/slot connections:
Object::connect: No such signal MainWindow::restoringDone() in /home/koder/Kode/kdegit/Calligra/calligra/braindump/src/import/DockerManager.cpp:145
Object::connect: No such signal MainWindow::beforeHandlingToolBars() in /home/koder/Kode/kdegit/Calligra/calligra/braindump/src/import/DockerManager.cpp:147
Object::connect: No such signal MainWindow::afterHandlingToolBars() in /home/koder/Kode/kdegit/Calligra/calligra/braindump/src/import/DockerManager.cpp:148
Reason for the broken connection with restoringDone() is that Braindump's MainWindow class does not subclass from KoMainWindow (any longer?), so there is no such signal to be expected. Attached patch removes that connection and the related slot restoringDone().
The other two signals have also been with KoMainWindow, but were removed with bd46824cab9eff73c6ff5974c002b11d11faec28 . In any case those two connections seem useless, as well as tagging the two methods moveToolBarsBack()/moveToolBars() as slots. So the attached patch removes also both the connections as well as the slot tags.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>braindump/src/import/DockerManager.h <span style="color: grey">(913ccba)</span></li>
<li>braindump/src/import/DockerManager.cpp <span style="color: grey">(28495b8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109888/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>