<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109046/">http://git.reviewboard.kde.org/r/109046/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109046/diff/2/?file=116015#file116015line378" style="color: black; font-weight: bold; text-decoration: underline;">plan/kptview.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">View::View(KoPart *part, MainDocument *doc, QWidget *parent)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">378</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span> <span class="o">&</span><span class="n">getProject</span><span class="p">(),</span> <span class="n">SIGNAL</span><span class="p">(</span> <span class="n">scheduleAdded</span><span class="p">(</span><span class="hl"> </span><span class="k"><span class="hl">const</span></span><span class="hl"> </span><span class="n">MainSchedule</span><span class="o">*</span> <span class="p"><span class="hl">)</span></span><span class="hl"> </span><span class="p">),</span> <span class="n">SLOT</span><span class="p">(</span> <span class="n">slotScheduleAdded</span><span class="p">(</span><span class="hl"> </span><span class="k"><span class="hl">const</span></span><span class="hl"> </span><span class="n">MainSchedule</span><span class="o">*</span> <span class="p"><span class="hl">)</span></span><span class="hl"> </span><span class="p">)</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">378</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span> <span class="o">&</span><span class="n">getProject</span><span class="p">(),</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">scheduleAdded</span><span class="p">(</span><span class="n">MainSchedule</span><span class="o">*</span><span class="p"><span class="hl">)</span>),</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">slotScheduleAdded</span><span class="p">(</span><span class="n">MainSchedule</span><span class="o">*</span><span class="p"><span class="hl">)</span>)</span> <span class="p">);</span></pre></td>
</tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">379</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span> <span class="o">&</span><span class="n">getProject</span><span class="p">(),</span> <span class="n">SIGNAL</span><span class="p">(</span> <span class="n">scheduleRemoved</span><span class="p">(</span><span class="hl"> </span><span class="k"><span class="hl">const</span></span><span class="hl"> </span><span class="n">MainSchedule</span><span class="o">*</span> <span class="p"><span class="hl">)</span></span><span class="hl"> </span><span class="p">),</span> <span class="n">SLOT</span><span class="p">(</span> <span class="n">slotScheduleRemoved</span><span class="p">(</span><span class="hl"> </span><span class="k"><span class="hl">const</span></span><span class="hl"> </span><span class="n">MainSchedule</span><span class="o">*</span> <span class="p"><span class="hl">)</span></span><span class="hl"> </span><span class="p">)</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">379</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span> <span class="o">&</span><span class="n">getProject</span><span class="p">(),</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">scheduleRemoved</span><span class="p">(</span><span class="n">MainSchedule</span><span class="o">*</span><span class="p"><span class="hl">)</span>),</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">slotScheduleRemoved</span><span class="p">(</span><span class="n">MainSchedule</span><span class="o">*</span><span class="p"><span class="hl">)</span>)</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">'const' should be removed from value types, but not from pointers</pre>
</div>
<br />
<p>- Friedrich W. H.</p>
<br />
<p>On February 26th, 2013, 5:22 p.m. UTC, Inge Wallin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Dag Andersen.</div>
<div>By Inge Wallin.</div>
<p style="color: grey;"><i>Updated Feb. 26, 2013, 5:22 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is yet another normalize signature patch created by fixsrc.py, this time in Plan.
According to http://englishbreakfastnetwork.org/krazy/reports/bundled-apps/calligra/plan/index.html there are over 2000 such issues in Plan so I'm only fixing those at the top level so that they can be inspected manually without choking on the sheer amount.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plan/kptviewlistdocker.cpp <span style="color: grey">(2c5ec18)</span></li>
<li>plan/kptviewlistdialog.cpp <span style="color: grey">(bd7c805)</span></li>
<li>plan/kptview.cpp <span style="color: grey">(fcfa192)</span></li>
<li>plan/kptviewlist.cpp <span style="color: grey">(86a3c93)</span></li>
<li>plan/kpttaskdefaultpanel.cpp <span style="color: grey">(ec15644)</span></li>
<li>plan/kptpart.cpp <span style="color: grey">(1657c06)</span></li>
<li>plan/kptschedulesdocker.cpp <span style="color: grey">(3217f77)</span></li>
<li>plan/kptinsertfiledlg.cpp <span style="color: grey">(045bce1)</span></li>
<li>plan/kptmaindocument.cpp <span style="color: grey">(b4afbc3)</span></li>
<li>plan/kptbuiltinschedulerplugin.cpp <span style="color: grey">(c29ae4c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109046/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>