<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109700/">http://git.reviewboard.kde.org/r/109700/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Sebastian Sauer.</div>
<p style="color: grey;"><i>Updated March 25, 2013, 4:47 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks as my patch also contained a second Words related progressbar change. That wasn't supposed to be the case so fixed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Changes:
* Introduced getter matching to thesetter for the KoProgressProxy* to KoDocument.
* Changed KoPart::openFile and KoPart::saveFile to NOT overwrite KoDocument's KoProgressProxy* if there is already one set.
* Be sure if KoPart::openFile and KoPart::saveFile set a KoProgressProxy* in KoDocument they set the KoDocument's KoProgressProxy* back to NULL once done rather then ending with a dangling pointer in KoDocument.
Motivation:
KoMainWindow is QtGui and so far handles all the progress-display logic. This patches changes that behavior to allow from outside to inject an own KoProgressProxy and not have KoDocument overwrite that again. This enables display of loading/saving progress in all non KoMainWindow-based applications like Coffice or Calligra Active. Coffice already contains some code to proper display that progress. In short: Inherit from KoProgessProxy (to be able to forward/evaluate that setValue or use it direct to fill your progressbar) and after you got the KoPart do myKoPartInstance->document()->setProgressProxy(myProgressProxyInstance). You not need to reset that later on on every load/save.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/main/KoDocument.h <span style="color: grey">(287a56d)</span></li>
<li>libs/main/KoDocument.cpp <span style="color: grey">(13e7258)</span></li>
<li>libs/main/KoPart.cpp <span style="color: grey">(d1e86e5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109700/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>