<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109651/">http://git.reviewboard.kde.org/r/109651/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have only a small issue. After that you are free to push</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109651/diff/3/?file=121435#file121435line160" style="color: black; font-weight: bold; text-decoration: underline;">libs/textlayout/KoStyleThumbnailer.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QImage KoStyleThumbnailer::thumbnail(KoCharacterStyle *characterStyle, KoParagraphStyle *paragraphStyle, QSize size, bool recreateThumbnail, KoStyleThumbnailerFlags flags)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">157</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt"><span class="hl">int</span></span> <span class="n">paragraphStyleId</span> <span class="o">=</span> <span class="p">(</span><span class="n">paragraphStyle</span><span class="p">)</span><span class="o"><span class="hl">?</span></span><span class="n">paragraphStyle</span><span class="o"><span class="hl">-></span></span><span class="n"><span class="hl">styleId</span></span><span class="p"><span class="hl">()</span></span><span class="o"><span class="hl">:</span></span><span class="mi"><span class="hl">0</span></span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">160</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt"><span class="hl">unsigned</span></span><span class="hl"> </span><span class="kt"><span class="hl">long</span></span> <span class="n">paragraphStyleId</span> <span class="o">=</span> <span class="p">(</span><span class="n">paragraphStyle</span><span class="p">)</span> <span class="o"><span class="hl">?</span></span><span class="hl"> </span><span class="k"><span class="hl">reinterpret_cast</span></span><span class="o"><span class="hl"><</span></span><span class="kt"><span class="hl">unsigned</span></span><span class="hl"> </span><span class="kt"><span class="hl">long</span></span><span class="o"><span class="hl">></span></span><span class="p"><span class="hl">(</span></span><span class="n">paragraphStyle</span><span class="p"><span class="hl">)</span></span><span class="hl"> </span><span class="o"><span class="hl">:</span></span><span class="hl"> </span><span class="mi"><span class="hl">0L</span></span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">paragraphStyleId seems a misnomer now</pre>
</div>
<br />
<p>- C.</p>
<br />
<p>On March 25th, 2013, 5:28 a.m. UTC, Thorsten Zachmann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Pierre Stirnweiss.</div>
<div>By Thorsten Zachmann.</div>
<p style="color: grey;"><i>Updated March 25, 2013, 5:28 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch tries to fix the problems/crashes which happen in the style manager.
To get the simple crash open the default document and click on the edit button of the None (character style)
The patch uses a different model for the style manager and temporary styles that get modified to only apply the changes once the user applies them.
The model changes the internal pointer to the temporary files once they are selected and when applied resets to the original ones.
However the styles preview in the styles manager list is updated immediately.
The patch simplifies the handling quite a bit.
I did not know that Pierre was also working on that so I publish it now so we have something we can discuss.
If you like this I would like to backport it to 2.6 as it fixes quite some grave bugs compared to what we have now.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested modification without saving.
Tested applying.
Tested Ok.
Tested Canceling
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/kotext/styles/KoCharacterStyle.h <span style="color: grey">(2fdde12)</span></li>
<li>libs/textlayout/KoStyleThumbnailer.cpp <span style="color: grey">(436b243)</span></li>
<li>plugins/textshape/CMakeLists.txt <span style="color: grey">(084628c)</span></li>
<li>plugins/textshape/dialogs/CharacterGeneral.h <span style="color: grey">(e6d99db)</span></li>
<li>plugins/textshape/dialogs/CharacterGeneral.cpp <span style="color: grey">(d3eead6)</span></li>
<li>plugins/textshape/dialogs/ParagraphGeneral.h <span style="color: grey">(1a78376)</span></li>
<li>plugins/textshape/dialogs/ParagraphGeneral.cpp <span style="color: grey">(ad30369)</span></li>
<li>plugins/textshape/dialogs/StyleManager.h <span style="color: grey">(dec3b6b)</span></li>
<li>plugins/textshape/dialogs/StyleManager.cpp <span style="color: grey">(9c82c11)</span></li>
<li>plugins/textshape/dialogs/StylesManagerModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/StylesManagerModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/StylesSortFilterProxyModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/StylesSortFilterProxyModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109651/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>