<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109666/">http://git.reviewboard.kde.org/r/109666/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit a4e8800471b0a7ef0f0277a7188b89e1401806b7 by Friedrich W. H. Kossebau to branch calligra/2.6.</pre>
<br />
<p>- Commit</p>
<br />
<p>On March 24th, 2013, 8:27 p.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Cyrille Berger Skott.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated March 24, 2013, 8:27 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Seems there is a bug in the XMLGUI system. Reported as https://bugs.kde.org/show_bug.cgi?id=317211
Also:
* Better set the xmlui file as early as possible in the view class (ust a gut feeling, as it seemed to work the old way as well)
* For default menus there is no need to add the title text, so removed it.
* For the translator also add a nice context info with the string "Shapes"</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works for me :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>braindump/data/braindumpui.rc <span style="color: grey">(005fb98)</span></li>
<li>braindump/data/braindumpview.rc <span style="color: grey">(999c949)</span></li>
<li>braindump/src/View.cpp <span style="color: grey">(ec1a0bd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109666/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>