<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109615/">http://git.reviewboard.kde.org/r/109615/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit dc6ec22ffe9b56b91b9de596c501d68579d3ad23 by Friedrich W. H. Kossebau to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On March 23rd, 2013, 9:39 p.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated March 23, 2013, 9:39 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Each filter in filters/ got turned into a product with the naming pattern "FILTER_A_TO_B", to hint in the name from which file/app to which file/app the filter works (I was surprised how many file->file filters there are).
Patch also turns the core calligra libs into a product "CALLIGRA_LIBS", as there are other products that do not rely on them, so possibly someone might want to skip these. At least it is also interesting to see what relies on them and what not.
Most checks are also fetched into the toplevel CMakeLists.txt, for consistency and overview. Also Poppler, WPG & Co. were checked more than once.
Really quite a long list of products. But it should help us to keep an overview what is provided by Calligra, instead of having stuff buried somewhere in deep folders.
BTW:
I wonder if meta products like "Words" should not also be able to result in all useful stuff to be built, like the suiting filters. That would need the addition of another tag next to "NEEDS", e.g. "LIKES", "WANTS" or "WISHES".</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Still builds fine for all default productsets for me.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(c4e14e7)</span></li>
<li>cmake/productsets/active.cmake <span style="color: grey">(c366a6a)</span></li>
<li>cmake/productsets/all.cmake <span style="color: grey">(5f27fd4)</span></li>
<li>cmake/productsets/creative.cmake <span style="color: grey">(94d1768)</span></li>
<li>cmake/productsets/desktop.cmake <span style="color: grey">(a732e36)</span></li>
<li>devtools/cstester/visualimagecompare/CMakeLists.txt <span style="color: grey">(6c46c62)</span></li>
<li>filters/CMakeLists.txt <span style="color: grey">(82bb2f1)</span></li>
<li>filters/flow/CMakeLists.txt <span style="color: grey">(ed12fd2)</span></li>
<li>filters/flow/visio/CMakeLists.txt <span style="color: grey">(c279d75)</span></li>
<li>filters/flow/visio/import/CMakeLists.txt <span style="color: grey">(a20db2a)</span></li>
<li>filters/karbon/CMakeLists.txt <span style="color: grey">(ee99220)</span></li>
<li>filters/karbon/karbon1.x/CMakeLists.txt <span style="color: grey">(517480a)</span></li>
<li>filters/karbon/svg/CMakeLists.txt <span style="color: grey">(09ada07)</span></li>
<li>filters/karbon/wmf/CMakeLists.txt <span style="color: grey">(e7fff92)</span></li>
<li>filters/karbon/wpg/CMakeLists.txt <span style="color: grey">(351fd37)</span></li>
<li>filters/karbon/xfig/CMakeLists.txt <span style="color: grey">(2e62248)</span></li>
<li>filters/plan/mpxj/CMakeLists.txt <span style="color: grey">(52c331d)</span></li>
<li>filters/sheets/CMakeLists.txt <span style="color: grey">(dc9bb06)</span></li>
<li>filters/sheets/csv/CMakeLists.txt <span style="color: grey">(f6a5183)</span></li>
<li>filters/sheets/excel/CMakeLists.txt <span style="color: grey">(3f0f5d9)</span></li>
<li>filters/sheets/excel/import/CMakeLists.txt <span style="color: grey">(97661d3)</span></li>
<li>filters/sheets/excel/sidewinder/CMakeLists.txt <span style="color: grey">(a35211d)</span></li>
<li>filters/sheets/gnumeric/CMakeLists.txt <span style="color: grey">(ea65d20)</span></li>
<li>filters/sheets/html/CMakeLists.txt <span style="color: grey">(aa54222)</span></li>
<li>filters/sheets/latex/CMakeLists.txt <span style="color: grey">(36cf84c)</span></li>
<li>filters/sheets/opencalc/CMakeLists.txt <span style="color: grey">(125d0db)</span></li>
<li>filters/sheets/xlsx/CMakeLists.txt <span style="color: grey">(5feddf2)</span></li>
<li>filters/stage/CMakeLists.txt <span style="color: grey">(91b07d8)</span></li>
<li>filters/stage/kpr2odf/CMakeLists.txt <span style="color: grey">(8cd64b9)</span></li>
<li>filters/stage/powerpoint/CMakeLists.txt <span style="color: grey">(bc91c63)</span></li>
<li>filters/stage/pptx/CMakeLists.txt <span style="color: grey">(a2d8f39)</span></li>
<li>filters/words/CMakeLists.txt <span style="color: grey">(51aebb8)</span></li>
<li>filters/words/ascii/CMakeLists.txt <span style="color: grey">(f4dbf37)</span></li>
<li>filters/words/docx/CMakeLists.txt <span style="color: grey">(8a341a0)</span></li>
<li>filters/words/epub/CMakeLists.txt <span style="color: grey">(53513a1)</span></li>
<li>filters/words/msword-odf/CMakeLists.txt <span style="color: grey">(b1d6adc)</span></li>
<li>filters/words/rtf/CMakeLists.txt <span style="color: grey">(954fbfd)</span></li>
<li>filters/words/rtf/import/CMakeLists.txt <span style="color: grey">(aa0a94d)</span></li>
<li>filters/words/wordperfect/CMakeLists.txt <span style="color: grey">(ad6de17)</span></li>
<li>filters/words/wordperfect/import/CMakeLists.txt <span style="color: grey">(6b15094)</span></li>
<li>filters/words/works/CMakeLists.txt <span style="color: grey">(c279d75)</span></li>
<li>filters/words/works/import/CMakeLists.txt <span style="color: grey">(7a11da8)</span></li>
<li>krita/plugins/formats/CMakeLists.txt <span style="color: grey">(4b9090d)</span></li>
<li>krita/plugins/formats/ora/CMakeLists.txt <span style="color: grey">(a285498)</span></li>
<li>libs/CMakeLists.txt <span style="color: grey">(8e23b21)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109615/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>