<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109649/">http://git.reviewboard.kde.org/r/109649/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">in theory nothing against it, but maybe it's a bit more insecure because what happens if a tool emits done when it was made temporary from the outside. previously nothing, but now it may get out of sync. Not a big problem, but maybe something for you to think about</pre>
 <br />









<p>- C.</p>


<br />
<p>On March 21st, 2013, 8:02 p.m. UTC, Dmitry Kazakov wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Calligra.</div>
<div>By Dmitry Kazakov.</div>


<p style="color: grey;"><i>Updated March 21, 2013, 8:02 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In this big patch I need a review for a small part only (on the last page of diff viewer). There is a change to KoToolManager. I made two methods for temporary switching public. Before the change only a tool-based-class could switch the tool temporarily. Now everyone can do it.

This change is needed to allow activation of the Color Picker tool from the filter dialog in Krita. When the dialog is shown, the picker is temporarily activated. When the dialog is gone, the tool is switched back.</pre>
  </td>
 </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>krita/image/kis_base_processor.h <span style="color: grey">(a135075)</span></li>

 <li>krita/image/kis_base_processor.cpp <span style="color: grey">(7ec48ec)</span></li>

 <li>krita/image/kis_config_widget.h <span style="color: grey">(87d1d3a)</span></li>

 <li>krita/image/kis_config_widget.cpp <span style="color: grey">(87a9aae)</span></li>

 <li>krita/plugins/extensions/shiva/shivafilter.h <span style="color: grey">(9e0630d)</span></li>

 <li>krita/plugins/extensions/shiva/shivafilter.cpp <span style="color: grey">(8617005)</span></li>

 <li>krita/plugins/extensions/shiva/shivagenerator.h <span style="color: grey">(96fe730)</span></li>

 <li>krita/plugins/extensions/shiva/shivagenerator.cpp <span style="color: grey">(89c9497)</span></li>

 <li>krita/plugins/filters/blur/kis_blur_filter.h <span style="color: grey">(4546485)</span></li>

 <li>krita/plugins/filters/blur/kis_blur_filter.cpp <span style="color: grey">(ba9c07d)</span></li>

 <li>krita/plugins/filters/blur/kis_gaussian_blur_filter.h <span style="color: grey">(6cc214e)</span></li>

 <li>krita/plugins/filters/blur/kis_gaussian_blur_filter.cpp <span style="color: grey">(d2dd8a1)</span></li>

 <li>krita/plugins/filters/blur/kis_lens_blur_filter.h <span style="color: grey">(3c607d6)</span></li>

 <li>krita/plugins/filters/blur/kis_lens_blur_filter.cpp <span style="color: grey">(775efd6)</span></li>

 <li>krita/plugins/filters/blur/kis_motion_blur_filter.h <span style="color: grey">(2ae9f0e)</span></li>

 <li>krita/plugins/filters/blur/kis_motion_blur_filter.cpp <span style="color: grey">(e415244)</span></li>

 <li>krita/plugins/filters/colors/kis_color_to_alpha.h <span style="color: grey">(71c3bee)</span></li>

 <li>krita/plugins/filters/colors/kis_color_to_alpha.cpp <span style="color: grey">(73eaf0f)</span></li>

 <li>krita/plugins/filters/colors/kis_wdg_color_to_alpha.h <span style="color: grey">(757c601)</span></li>

 <li>krita/plugins/filters/colors/kis_wdg_color_to_alpha.cpp <span style="color: grey">(5029522)</span></li>

 <li>krita/plugins/filters/colors/wdgcolortoalphabase.ui <span style="color: grey">(0a2b8ff)</span></li>

 <li>krita/plugins/filters/colorsfilters/kis_brightness_contrast_filter.h <span style="color: grey">(31c88b5)</span></li>

 <li>krita/plugins/filters/colorsfilters/kis_brightness_contrast_filter.cpp <span style="color: grey">(4375d9c)</span></li>

 <li>krita/plugins/filters/colorsfilters/kis_hsv_adjustment_filter.h <span style="color: grey">(0a818fa)</span></li>

 <li>krita/plugins/filters/colorsfilters/kis_hsv_adjustment_filter.cpp <span style="color: grey">(5b5bc3a)</span></li>

 <li>krita/plugins/filters/colorsfilters/kis_perchannel_filter.h <span style="color: grey">(59ee020)</span></li>

 <li>krita/plugins/filters/colorsfilters/kis_perchannel_filter.cpp <span style="color: grey">(85f72c3)</span></li>

 <li>krita/plugins/filters/dodgeburn/DodgeBurn.h <span style="color: grey">(7ef27f2)</span></li>

 <li>krita/plugins/filters/dodgeburn/DodgeBurn.cpp <span style="color: grey">(b2ae46c)</span></li>

 <li>krita/plugins/filters/embossfilter/kis_emboss_filter.h <span style="color: grey">(3b71978)</span></li>

 <li>krita/plugins/filters/embossfilter/kis_emboss_filter.cpp <span style="color: grey">(17611af)</span></li>

 <li>krita/plugins/filters/fastcolortransfer/fastcolortransfer.h <span style="color: grey">(23cccfd)</span></li>

 <li>krita/plugins/filters/fastcolortransfer/fastcolortransfer.cpp <span style="color: grey">(5dab33f)</span></li>

 <li>krita/plugins/filters/imageenhancement/kis_simple_noise_reducer.h <span style="color: grey">(c3bb4b9)</span></li>

 <li>krita/plugins/filters/imageenhancement/kis_simple_noise_reducer.cpp <span style="color: grey">(e514c13)</span></li>

 <li>krita/plugins/filters/imageenhancement/kis_wavelet_noise_reduction.h <span style="color: grey">(577172d)</span></li>

 <li>krita/plugins/filters/imageenhancement/kis_wavelet_noise_reduction.cpp <span style="color: grey">(2ddd372)</span></li>

 <li>krita/plugins/filters/levelfilter/kis_level_filter.h <span style="color: grey">(751d8baf4)</span></li>

 <li>krita/plugins/filters/levelfilter/kis_level_filter.cpp <span style="color: grey">(c13f859)</span></li>

 <li>krita/plugins/filters/noisefilter/noisefilter.h <span style="color: grey">(35c654a)</span></li>

 <li>krita/plugins/filters/noisefilter/noisefilter.cpp <span style="color: grey">(ef66c9d)</span></li>

 <li>krita/plugins/filters/oilpaintfilter/kis_oilpaint_filter.h <span style="color: grey">(e3d5ccc)</span></li>

 <li>krita/plugins/filters/oilpaintfilter/kis_oilpaint_filter.cpp <span style="color: grey">(3c3e7ee)</span></li>

 <li>krita/plugins/filters/phongbumpmap/kis_phong_bumpmap_config_widget.h <span style="color: grey">(85016da)</span></li>

 <li>krita/plugins/filters/phongbumpmap/kis_phong_bumpmap_config_widget.cpp <span style="color: grey">(3416f7d)</span></li>

 <li>krita/plugins/filters/phongbumpmap/kis_phong_bumpmap_filter.h <span style="color: grey">(ffe5b0b)</span></li>

 <li>krita/plugins/filters/phongbumpmap/kis_phong_bumpmap_filter.cpp <span style="color: grey">(68047ad)</span></li>

 <li>krita/plugins/filters/pixelizefilter/kis_pixelize_filter.h <span style="color: grey">(8b2356a)</span></li>

 <li>krita/plugins/filters/pixelizefilter/kis_pixelize_filter.cpp <span style="color: grey">(1ab5604)</span></li>

 <li>krita/plugins/filters/raindropsfilter/kis_raindrops_filter.h <span style="color: grey">(54302d4)</span></li>

 <li>krita/plugins/filters/raindropsfilter/kis_raindrops_filter.cpp <span style="color: grey">(e54fb84)</span></li>

 <li>krita/plugins/filters/randompickfilter/randompickfilter.h <span style="color: grey">(6f7ef59)</span></li>

 <li>krita/plugins/filters/randompickfilter/randompickfilter.cpp <span style="color: grey">(72dac1b)</span></li>

 <li>krita/plugins/filters/roundcorners/kis_round_corners_filter.h <span style="color: grey">(5fbd1a9)</span></li>

 <li>krita/plugins/filters/roundcorners/kis_round_corners_filter.cpp <span style="color: grey">(69a521a)</span></li>

 <li>krita/plugins/filters/smalltilesfilter/kis_small_tiles_filter.h <span style="color: grey">(d7a63fd)</span></li>

 <li>krita/plugins/filters/smalltilesfilter/kis_small_tiles_filter.cpp <span style="color: grey">(5acf358)</span></li>

 <li>krita/plugins/filters/sobelfilter/kis_sobel_filter.h <span style="color: grey">(c89262f)</span></li>

 <li>krita/plugins/filters/sobelfilter/kis_sobel_filter.cpp <span style="color: grey">(ede9dc9)</span></li>

 <li>krita/plugins/filters/unsharp/kis_unsharp_filter.h <span style="color: grey">(74a6546)</span></li>

 <li>krita/plugins/filters/unsharp/kis_unsharp_filter.cpp <span style="color: grey">(316c3d0)</span></li>

 <li>krita/plugins/filters/wavefilter/wavefilter.h <span style="color: grey">(7c92b51)</span></li>

 <li>krita/plugins/filters/wavefilter/wavefilter.cpp <span style="color: grey">(9ca6475)</span></li>

 <li>krita/plugins/generators/solid/colorgenerator.h <span style="color: grey">(f208bcc)</span></li>

 <li>krita/plugins/generators/solid/colorgenerator.cpp <span style="color: grey">(e24c3cc)</span></li>

 <li>krita/plugins/paintops/libpaintop/kis_filter_option.cpp <span style="color: grey">(ec147bf)</span></li>

 <li>krita/plugins/tools/defaulttools/kis_tool_colorpicker.h <span style="color: grey">(2c9b600)</span></li>

 <li>krita/plugins/tools/defaulttools/kis_tool_colorpicker.cc <span style="color: grey">(ea0c493)</span></li>

 <li>krita/ui/dialogs/kis_dlg_adj_layer_props.h <span style="color: grey">(77ccc7a)</span></li>

 <li>krita/ui/dialogs/kis_dlg_adj_layer_props.cc <span style="color: grey">(b997855)</span></li>

 <li>krita/ui/dialogs/kis_dlg_adjustment_layer.h <span style="color: grey">(69face4)</span></li>

 <li>krita/ui/dialogs/kis_dlg_adjustment_layer.cc <span style="color: grey">(c8b402e)</span></li>

 <li>krita/ui/dialogs/kis_dlg_filter.h <span style="color: grey">(34c9ab5)</span></li>

 <li>krita/ui/dialogs/kis_dlg_filter.cpp <span style="color: grey">(b354269)</span></li>

 <li>krita/ui/dialogs/kis_dlg_generator_layer.h <span style="color: grey">(e9d17ab)</span></li>

 <li>krita/ui/dialogs/kis_dlg_generator_layer.cpp <span style="color: grey">(a9a0de7)</span></li>

 <li>krita/ui/forms/wdgfilterdialog.ui <span style="color: grey">(6a122c9)</span></li>

 <li>krita/ui/kis_layer_manager.cc <span style="color: grey">(8ee525d)</span></li>

 <li>krita/ui/kis_mask_manager.h <span style="color: grey">(2d3d621)</span></li>

 <li>krita/ui/kis_mask_manager.cc <span style="color: grey">(1661d76)</span></li>

 <li>krita/ui/recorder/kis_recorded_filter_action_editor.cc <span style="color: grey">(5a6adab)</span></li>

 <li>krita/ui/widgets/kis_filter_selector_widget.h <span style="color: grey">(1fb954e)</span></li>

 <li>krita/ui/widgets/kis_filter_selector_widget.cc <span style="color: grey">(0107bb2)</span></li>

 <li>krita/ui/widgets/kis_wdg_generator.h <span style="color: grey">(93a171a)</span></li>

 <li>krita/ui/widgets/kis_wdg_generator.cpp <span style="color: grey">(b13a41d)</span></li>

 <li>libs/flake/KoToolManager.h <span style="color: grey">(929f127)</span></li>

 <li>libs/flake/KoToolManager.cpp <span style="color: grey">(d2db044)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109649/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>