<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109573/">http://git.reviewboard.kde.org/r/109573/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 29be2c930af51b8a2e231a86a6e55d4ddbca9c3a by Friedrich W. H. Kossebau to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On March 18th, 2013, 9:47 p.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Inge Wallin.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated March 18, 2013, 9:47 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Preparing the productization of the filters I found that the kchart filter genericimageexport is not built.
Its build is guarded by SHOULD_BUILD_KCHART, but that is nowhere else set/used, that is why nobody might have noticed so far.
This patch also removes filters/libdialogfilter which has been only referenced from that filter, so is not used as well.
Would note the removal in OBSOLETE.TXT as usual.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/CMakeLists.txt <span style="color: grey">(8bcd640)</span></li>
<li>filters/kchart/CMakeLists.txt <span style="color: grey">(bec23fc)</span></li>
<li>filters/kchart/genericimageexport/CMakeLists.txt <span style="color: grey">(fb34b1b)</span></li>
<li>filters/kchart/genericimageexport/genericimageexport.h <span style="color: grey">(a699e80)</span></li>
<li>filters/kchart/genericimageexport/genericimageexport.cpp <span style="color: grey">(c35f896)</span></li>
<li>filters/kchart/genericimageexport/kchart_bmp_export.desktop <span style="color: grey">(5dff846)</span></li>
<li>filters/kchart/genericimageexport/kchart_jpeg_export.desktop <span style="color: grey">(88f9362)</span></li>
<li>filters/kchart/genericimageexport/kchart_mng_export.desktop <span style="color: grey">(144e0d4)</span></li>
<li>filters/kchart/genericimageexport/kchart_png_export.desktop <span style="color: grey">(5b966f2)</span></li>
<li>filters/kchart/genericimageexport/kchart_xbm_export.desktop <span style="color: grey">(0583d1c)</span></li>
<li>filters/kchart/genericimageexport/kchart_xpm_export.desktop <span style="color: grey">(bbc0f47)</span></li>
<li>filters/libdialogfilter/exportsizedia.h <span style="color: grey">(1f56903)</span></li>
<li>filters/libdialogfilter/exportsizedia.cpp <span style="color: grey">(e4a0a45)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109573/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>