<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109358/">http://git.reviewboard.kde.org/r/109358/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 9th, 2013, 10:32 a.m. UTC, <b>Lukáš Tvrdý</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109358/diff/1/?file=117957#file117957line134" style="color: black; font-weight: bold; text-decoration: underline;">CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">123</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">target_link_libraries</span><span class="p">(</span><span class="s">kdeinit_krita</span> <span class="s">k<span class="hl">ritaui</span></span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">134</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">target_link_libraries</span><span class="p">(</span><span class="s">kdeinit_krita</span> <span class="s">k<span class="hl">omain</span></span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why this changes?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixed</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 9th, 2013, 10:32 a.m. UTC, <b>Lukáš Tvrdý</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109358/diff/1/?file=117968#file117968line87" style="color: black; font-weight: bold; text-decoration: underline;">image/kis_default_bounds.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KisSelectionDefaultBounds::~KisSelectionDefaultBounds()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">87</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm">/******************************************************************/</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I would remove this commented parted</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hm, actually, it was Dmitry who added that stuff. I think it only got moved around.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 9th, 2013, 10:32 a.m. UTC, <b>Lukáš Tvrdý</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109358/diff/1/?file=117983#file117983line32" style="color: black; font-weight: bold; text-decoration: underline;">plugins/assistants/RulerAssistant/kis_ruler_assistant_tool.cc</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">32</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#ifndef QT_NO_DBUS</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can you explain this ifdefing coding related to QT_NO_DBUS?
Why it is needed to have all this blocks ifdefed?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That's because kio needs dbus, and we want to be able to compile sketch (and krita) without dbus on Windows and OSX.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 9th, 2013, 10:32 a.m. UTC, <b>Lukáš Tvrdý</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109358/diff/1/?file=117985#file117985line129" style="color: black; font-weight: bold; text-decoration: underline;">plugins/extensions/bigbrother/bigbrother.cc</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void BigBrotherPlugin::slotSave()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">129</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">updater</span><span class="o">-></span><span class="n">start</span><span class="p">(</span><span class="mi">1</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">129</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">updater</span><span class="o">-></span><span class="n">start</span><span class="p">(</span><span class="mi">1</span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="n"><span class="hl">i18n</span></span><span class="p"><span class="hl">(</span></span><span class="s"><span class="hl">"Playing back macro"</span></span><span class="p"><span class="hl">)</span>);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Replaying macro?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, that's what it is:
dbgPlugins << "Play the macro";
KoProgressUpdater* updater = m_view->createProgressUpdater();
- updater->start(1);
+ updater->start(1, i18n("Playing back macro"));
Basically, we need to have this text to show what's happening when doing progress. So, following the comments in the code, text was added.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 9th, 2013, 10:32 a.m. UTC, <b>Lukáš Tvrdý</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109358/diff/1/?file=117989#file117989line26" style="color: black; font-weight: bold; text-decoration: underline;">plugins/extensions/share/dlg_login.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">26</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">qDebug</span><span class="p">()</span> <span class="o"><<</span> <span class="s">"URL ="</span> <span class="o"><<</span> <span class="n">url</span> <span class="o"><<</span> <span class="n">m_deviant</span><span class="o">-></span><span class="n">token</span><span class="p">()</span> <span class="o"><<</span> <span class="s">","</span> <span class="o"><<</span> <span class="n">m_accessToken</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I would emove qDebug and use kdebug instead?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">fixed.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 9th, 2013, 10:32 a.m. UTC, <b>Lukáš Tvrdý</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109358/diff/1/?file=117992#file117992line64" style="color: black; font-weight: bold; text-decoration: underline;">plugins/extensions/share/imageshare.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">64</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">// </span><span class="cs">TODO</span><span class="c1"> change this once we have this information from dA... broken response is fun...</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Do you have the response from dA?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Dan -- that's really for you to answer.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 9th, 2013, 10:32 a.m. UTC, <b>Lukáš Tvrdý</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109358/diff/1/?file=117992#file117992line141" style="color: black; font-weight: bold; text-decoration: underline;">plugins/extensions/share/imageshare.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">141</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">qDebug</span><span class="p">()</span> <span class="o"><<</span> <span class="s">"openBrowser"</span> <span class="o"><<</span> <span class="n">url</span> <span class="o"><<</span> <span class="n">m_deviantArt</span><span class="o">-></span><span class="n">token</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can you remove all qDebug occuriences or replace them with kdebug?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Done.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 9th, 2013, 10:32 a.m. UTC, <b>Lukáš Tvrdý</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109358/diff/1/?file=117997#file117997line1" style="color: black; font-weight: bold; text-decoration: underline;">plugins/extensions/share/o2deviantart.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm">/*</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can be this code found in some library?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It's basic BSD license, so a copy should be fine. It is not in any library used.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 9th, 2013, 10:32 a.m. UTC, <b>Lukáš Tvrdý</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109358/diff/1/?file=118013#file118013line16" style="color: black; font-weight: bold; text-decoration: underline;">plugins/formats/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">16</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">macro_optional_find_package</span><span class="p">(</span><span class="s">JPEG</span><span class="p">)</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Are you removing JPEG support?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No, this is just a duplicated find_package -- we have another earlier on.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 9th, 2013, 10:32 a.m. UTC, <b>Lukáš Tvrdý</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109358/diff/1/?file=118014#file118014line9" style="color: black; font-weight: bold; text-decoration: underline;">plugins/formats/jpeg/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">9</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">set</span><span class="p">(</span><span class="s">libkritaconverter_LIB_SRCS</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is this intended?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, jpeg support was moved to krita/ui, parallel to krita/png</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 9th, 2013, 10:32 a.m. UTC, <b>Lukáš Tvrdý</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109358/diff/1/?file=118014#file118014line43" style="color: black; font-weight: bold; text-decoration: underline;">plugins/formats/jpeg/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">43</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nb">target_link_libraries</span><span class="p">(</span><span class="s">kritajpegexport</span> <span class="s">kritaui</span> <span class="s">jpeg</span> <span class="o">${</span><span class="nv">LCMS2_LIBRARIES</span><span class="o">}</span> <span class="o">${</span><span class="nv">EXIV2_LIBRARIES</span><span class="o">}</span> <span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">34</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nb">target_link_libraries</span><span class="p">(</span><span class="s">kritajpegexport</span> <span class="s">kritaui</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">also this is inteded change?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 9th, 2013, 10:32 a.m. UTC, <b>Lukáš Tvrdý</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109358/diff/1/?file=118028#file118028line2" style="color: black; font-weight: bold; text-decoration: underline;">plugins/tools/defaulttools/kis_tool_movetooloptionswidget.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">2</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> <one line to give the program's name and a brief idea of what it does.></span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove or add some line here</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixed.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 9th, 2013, 10:32 a.m. UTC, <b>Lukáš Tvrdý</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109358/diff/1/?file=118030#file118030line67" style="color: black; font-weight: bold; text-decoration: underline;">plugins/tools/selectiontools/kis_tool_select_elliptical.cc</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KisToolSelectElliptical::finishEllipse(const QRectF &rect)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">67</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QTimer</span><span class="o">::</span><span class="n">singleShot</span><span class="p">(</span><span class="mi">0</span><span class="p">,</span> <span class="n">kisCanvas</span><span class="o">-></span><span class="n">view</span><span class="p">()</span><span class="o">-></span><span class="n">selectionManager</span><span class="p">(),</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">deselect</span><span class="p">()));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is this race condition real?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yes, definitely.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 9th, 2013, 10:32 a.m. UTC, <b>Lukáš Tvrdý</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109358/diff/1/?file=118044#file118044line51" style="color: black; font-weight: bold; text-decoration: underline;">plugins/tools/tool_transform2/tool_transform.cc</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">K_EXPORT_PLUGIN(ToolTransformFactory("krita"))</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">49</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">qmlRegisterUncreatableType</span><span class="o"><</span><span class="n">KisToolTransform</span><span class="o">></span><span class="p">(</span><span class="s">"org.krita.sketch"</span><span class="p">,</span> <span class="mi">1</span><span class="p">,</span> <span class="mi">0</span><span class="p">,</span> <span class="s">"TransformTool"</span><span class="p">,</span> <span class="s">"This class is only used for enum values."</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Do we want to mix QML and tools code? I don't find it correct</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Arjen will look at that, as well as the duplicated getters/setters.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 9th, 2013, 10:32 a.m. UTC, <b>Lukáš Tvrdý</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I made first round of brief review. I did not test the code.
I don't see any obvious regression from the functionality point of view.
I don't understand why JPEG and MemoryLeakTracer is removed in this patch.
OAuth2 dA code should be probably external dependency if it is possible,
the licence is confusing for me too, is it ok for inclusion?
General advice:
o avoid to use qDebug()
o fix TODOs/FIXME before merging to master</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We probably need to:
a) skip the deviant art integration
b) make one big patch
I've been cleaning up the patch already a bit, but need to do that in the branch now.</pre>
<br />
<p>- Boudewijn</p>
<br />
<p>On March 8th, 2013, 3:21 p.m. UTC, Dan Leinir Turthra Jensen wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Dan Leinir Turthra Jensen.</div>
<p style="color: grey;"><i>Updated March 8, 2013, 3:21 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The first of a series of batches of changes from the Krita Sketch branch. This is everything inside krita, except for sketch and the ui directory.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(f8943b7)</span></li>
<li>config-qjson.h.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/CMakeLists.txt <span style="color: grey">(c621b5f)</span></li>
<li>data/paintoppresets/Pencil_HB.kpp <span style="color: grey">(0855da8)</span></li>
<li>data/shaders/CMakeLists.txt <span style="color: grey">(3b40741)</span></li>
<li>data/shaders/gl2.frag <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/shaders/gl2.vert <span style="color: grey">(PRE-CREATION)</span></li>
<li>image/CMakeLists.txt <span style="color: grey">(0d4b2f8)</span></li>
<li>image/commands/kis_image_command.h <span style="color: grey">(e316bf9)</span></li>
<li>image/commands/kis_set_global_selection_command.cpp <span style="color: grey">(d806cd6)</span></li>
<li>image/kis_default_bounds.h <span style="color: grey">(d51124b)</span></li>
<li>image/kis_default_bounds.cpp <span style="color: grey">(5e61ad1)</span></li>
<li>image/kis_filter_weights_applicator.h <span style="color: grey">(7689de0)</span></li>
<li>image/kis_image.h <span style="color: grey">(1b70680)</span></li>
<li>image/kis_image.cc <span style="color: grey">(73c0cfb)</span></li>
<li>image/kis_processing_visitor.cpp <span style="color: grey">(5761544)</span></li>
<li>image/kis_shared_ptr.h <span style="color: grey">(85aee50)</span></li>
<li>image/recorder/kis_macro_player.cc <span style="color: grey">(5cc848f)</span></li>
<li>image/recorder/kis_recorded_node_action.cc <span style="color: grey">(455c82e)</span></li>
<li>image/tests/kis_filter_weights_buffer_test.cpp <span style="color: grey">(6e2401a)</span></li>
<li>image/tests/kis_fixed_point_maths_test.cpp <span style="color: grey">(ef1f312)</span></li>
<li>main.cc <span style="color: grey">(a40958f)</span></li>
<li>pics/CMakeLists.txt <span style="color: grey">(d7ce005)</span></li>
<li>pics/icon-kritasketch-256.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/icon-kritasketch.svg <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/assistants/RulerAssistant/kis_ruler_assistant_tool.h <span style="color: grey">(e3bee14)</span></li>
<li>plugins/assistants/RulerAssistant/kis_ruler_assistant_tool.cc <span style="color: grey">(34b8a71)</span></li>
<li>plugins/extensions/CMakeLists.txt <span style="color: grey">(4084890)</span></li>
<li>plugins/extensions/bigbrother/bigbrother.cc <span style="color: grey">(f59e55e)</span></li>
<li>plugins/extensions/dropshadow/kis_dropshadow_plugin.cc <span style="color: grey">(0722c3e)</span></li>
<li>plugins/extensions/share/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/extensions/share/dlg_login.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/extensions/share/dlg_login.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/extensions/share/dlg_login.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/extensions/share/imageshare.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/extensions/share/imageshare.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/extensions/share/imageshare.rc <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/extensions/share/kritaimageshare.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/extensions/share/o2.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/extensions/share/o2.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/extensions/share/o2deviantart.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/extensions/share/o2deviantart.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/extensions/share/o2reply.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/extensions/share/o2reply.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/extensions/share/o2replyserver.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/extensions/share/o2replyserver.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/extensions/share/o2requestor.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/extensions/share/o2requestor.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/extensions/share/simplecrypt.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/extensions/share/simplecrypt.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/extensions/share/stash.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/extensions/share/stash.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/extensions/share/submit.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/extensions/share/submitdlg.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/extensions/share/submitdlg.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/filters/unsharp/kis_unsharp_filter.cpp <span style="color: grey">(316c3d0)</span></li>
<li>plugins/formats/CMakeLists.txt <span style="color: grey">(4b9090d)</span></li>
<li>plugins/formats/jpeg/CMakeLists.txt <span style="color: grey">(6bee059)</span></li>
<li>plugins/formats/jpeg/iccjpeg.h <span style="color: grey">(a3747b8)</span></li>
<li>plugins/formats/jpeg/iccjpeg.c <span style="color: grey">(1f6c4b1)</span></li>
<li>plugins/formats/jpeg/kis_jpeg_converter.h <span style="color: grey">(e080d23)</span></li>
<li>plugins/formats/jpeg/kis_jpeg_converter.cc <span style="color: grey">(33ec941)</span></li>
<li>plugins/formats/jpeg/kis_jpeg_destination.h <span style="color: grey">(d575158)</span></li>
<li>plugins/formats/jpeg/kis_jpeg_destination.cpp <span style="color: grey">(4bde42b)</span></li>
<li>plugins/formats/jpeg/kis_jpeg_source.h <span style="color: grey">(acddee0)</span></li>
<li>plugins/formats/jpeg/kis_jpeg_source.cpp <span style="color: grey">(ae89209)</span></li>
<li>plugins/tools/defaulttools/CMakeLists.txt <span style="color: grey">(0840796)</span></li>
<li>plugins/tools/defaulttools/kis_tool_brush.h <span style="color: grey">(dbf5c37)</span></li>
<li>plugins/tools/defaulttools/kis_tool_brush.cc <span style="color: grey">(fad20b5)</span></li>
<li>plugins/tools/defaulttools/kis_tool_move.h <span style="color: grey">(362add0)</span></li>
<li>plugins/tools/defaulttools/kis_tool_move.cc <span style="color: grey">(2cf9890)</span></li>
<li>plugins/tools/defaulttools/kis_tool_movetooloptionswidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/tools/defaulttools/kis_tool_movetooloptionswidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/tools/selectiontools/kis_tool_select_elliptical.cc <span style="color: grey">(4c071a2)</span></li>
<li>plugins/tools/selectiontools/kis_tool_select_polygonal.h <span style="color: grey">(cdfc0f6)</span></li>
<li>plugins/tools/selectiontools/kis_tool_select_polygonal.cc <span style="color: grey">(fb97f3d)</span></li>
<li>plugins/tools/selectiontools/kis_tool_select_rectangular.h <span style="color: grey">(b826bba)</span></li>
<li>plugins/tools/selectiontools/kis_tool_select_rectangular.cc <span style="color: grey">(97854963)</span></li>
<li>plugins/tools/tool_crop/CMakeLists.txt <span style="color: grey">(e84978d)</span></li>
<li>plugins/tools/tool_crop/kis_tool_crop.h <span style="color: grey">(dfce084)</span></li>
<li>plugins/tools/tool_crop/kis_tool_crop.cc <span style="color: grey">(65c9458)</span></li>
<li>plugins/tools/tool_crop/kistoolcropconfigwidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/tools/tool_crop/kistoolcropconfigwidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/tools/tool_transform2/CMakeLists.txt <span style="color: grey">(7a6c19b)</span></li>
<li>plugins/tools/tool_transform2/kis_tool_transform.h <span style="color: grey">(4ce6c6a)</span></li>
<li>plugins/tools/tool_transform2/kis_tool_transform.cc <span style="color: grey">(e7c4f52)</span></li>
<li>plugins/tools/tool_transform2/kis_tool_transform_config_widget.h <span style="color: grey">(5b7f932)</span></li>
<li>plugins/tools/tool_transform2/tool_transform.cc <span style="color: grey">(9372cfd)</span></li>
<li>plugins/tools/tool_transform2/tool_transform_args.h <span style="color: grey">(8e5befd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109358/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>