<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109320/">http://git.reviewboard.kde.org/r/109320/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Boudewijn Rempt.</div>
<div>By Inge Wallin.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch normalizes the SIGNAL and SLOT signatures in krita/ui. There were >200 issues in all of krita so I limited this batch to krita/ui. This is approximately half of the unnormalized signatures in all of krita so there will be a batch 2 if this is ok'ed.
As a side note, before this patch, I passed the 1000-issues-fixed mark. :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds correctly but there should be some testing and manual inspection.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/ui/canvas/kis_canvas2.cpp <span style="color: grey">(bb41065)</span></li>
<li>krita/ui/dialogs/kis_dlg_generator_layer.cpp <span style="color: grey">(a9a0de7)</span></li>
<li>krita/ui/flake/kis_dummies_facade_base.cpp <span style="color: grey">(12ab999)</span></li>
<li>krita/ui/flake/kis_shape_controller.cpp <span style="color: grey">(5b56b10)</span></li>
<li>krita/ui/kis_canvas_resource_provider.cpp <span style="color: grey">(fb317c6)</span></li>
<li>krita/ui/kis_control_frame.cpp <span style="color: grey">(262e197)</span></li>
<li>krita/ui/kis_node_model.cpp <span style="color: grey">(76e03d5)</span></li>
<li>krita/ui/kis_popup_palette.cpp <span style="color: grey">(0deb1fb)</span></li>
<li>krita/ui/kis_view2.cpp <span style="color: grey">(b864f90)</span></li>
<li>krita/ui/tests/modeltest.cpp <span style="color: grey">(5d0b9de)</span></li>
<li>krita/ui/widgets/kis_categorized_list_view.cpp <span style="color: grey">(d839c598)</span></li>
<li>krita/ui/widgets/kis_paintop_presets_chooser_popup.cpp <span style="color: grey">(d7f2984)</span></li>
<li>krita/ui/widgets/kis_paintop_presets_popup.cpp <span style="color: grey">(18da08e)</span></li>
<li>krita/ui/widgets/kis_scratch_pad.cpp <span style="color: grey">(2aac338)</span></li>
<li>krita/ui/widgets/squeezedcombobox.cpp <span style="color: grey">(36c4b9f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109320/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>