<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109260/">http://git.reviewboard.kde.org/r/109260/</a>
     </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit c51857f01df5c7a28617248d2b7ee741bde3f56e by Inge Wallin to branch master.</pre>
 <br />









<p>- Commit</p>


<br />
<p>On March 3rd, 2013, 3:30 p.m. UTC, Inge Wallin wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Calligra and Thorsten Zachmann.</div>
<div>By Inge Wallin.</div>


<p style="color: grey;"><i>Updated March 3, 2013, 3:30 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a normalization of SIGNAL and SLOT calls that is done with fixsrc.py.  By now I think it's 99% certain that it's correct but I still want somebody who knows the code to look through it.
</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It builds just like before.  No new failing tests.</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>stage/part/KPrAnimationDirector.cpp <span style="color: grey">(4b3a50d)</span></li>

 <li>stage/part/KPrHtmlExport.cpp <span style="color: grey">(9a9fc1c)</span></li>

 <li>stage/part/KPrPart.cpp <span style="color: grey">(84e4867)</span></li>

 <li>stage/part/KPrPresentationDrawWidget.cpp <span style="color: grey">(28c0264)</span></li>

 <li>stage/part/KPrPresentationTool.cpp <span style="color: grey">(3875f82)</span></li>

 <li>stage/part/KPrPresenterViewSlidesInterface.cpp <span style="color: grey">(1980981)</span></li>

 <li>stage/part/KPrPresenterViewToolWidget.cpp <span style="color: grey">(a4243c7)</span></li>

 <li>stage/part/KPrPresenterViewWidget.cpp <span style="color: grey">(d699c66)</span></li>

 <li>stage/part/KPrView.cpp <span style="color: grey">(078b34b)</span></li>

 <li>stage/part/KPrViewAdaptor.cpp <span style="color: grey">(1fd9051)</span></li>

 <li>stage/part/KPrViewModePreviewPageEffect.cpp <span style="color: grey">(45e33a6)</span></li>

 <li>stage/part/KPrViewModeSlidesSorter.cpp <span style="color: grey">(55b0e22)</span></li>

 <li>stage/part/dockers/KPrPageLayoutDocker.cpp <span style="color: grey">(e0e3113)</span></li>

 <li>stage/part/dockers/KPrPreviewWidget.cpp <span style="color: grey">(34bca0e)</span></li>

 <li>stage/part/tests/ModelTest.cpp <span style="color: grey">(2494481)</span></li>

 <li>stage/part/tools/animationtool/KPrAnimationSelectorWidget.cpp <span style="color: grey">(e603461)</span></li>

 <li>stage/part/tools/animationtool/KPrAnimationsTimeLineView.cpp <span style="color: grey">(98add38)</span></li>

 <li>stage/part/tools/animationtool/KPrClickActionDocker.cpp <span style="color: grey">(39167fd)</span></li>

 <li>stage/part/tools/animationtool/KPrPageEffectDocker.cpp <span style="color: grey">(e892dd1)</span></li>

 <li>stage/part/tools/animationtool/KPrShapeAnimationDocker.cpp <span style="color: grey">(e6039ae)</span></li>

 <li>stage/part/ui/KPrConfigureSlideShowDialog.cpp <span style="color: grey">(1b046bd)</span></li>

 <li>stage/plugins/eventactions/sound/KPrSoundEventAction.cpp <span style="color: grey">(1fbb3f4)</span></li>

 <li>stage/plugins/eventactions/sound/KPrSoundEventActionWidget.cpp <span style="color: grey">(34e4267)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109260/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>