<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109284/">http://git.reviewboard.kde.org/r/109284/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 4bf913362651381f5368c4ae1db041a4df07d643 by Inge Wallin to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On March 4th, 2013, 8:44 p.m. UTC, Inge Wallin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Marijn Kruisselbrink.</div>
<div>By Inge Wallin.</div>
<p style="color: grey;"><i>Updated March 4, 2013, 8:44 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Normalize all SIGNAL and SLOT signatures in sheets. I asked Mek beforehand and he said he liked it and would look at the diff.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It builds correctly but it should probably be tested too. I haven't done that. One risk is that the filter(s) use some connections that need to be normalized too.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>sheets/Map.cpp <span style="color: grey">(66c950c)</span></li>
<li>sheets/MapModel.cpp <span style="color: grey">(f2610c7)</span></li>
<li>sheets/NamedAreaManager.cpp <span style="color: grey">(c980a71)</span></li>
<li>sheets/Sheet.cpp <span style="color: grey">(6ae75fa)</span></li>
<li>sheets/SheetAccessModel.cpp <span style="color: grey">(7b80318)</span></li>
<li>sheets/commands/SpellCheckCommand.cpp <span style="color: grey">(c762428)</span></li>
<li>sheets/dialogs/AddNamedAreaDialog.cpp <span style="color: grey">(090ec34)</span></li>
<li>sheets/dialogs/ConditionalDialog.cpp <span style="color: grey">(2728527)</span></li>
<li>sheets/dialogs/ConsolidateDialog.cpp <span style="color: grey">(d9d708b)</span></li>
<li>sheets/dialogs/DatabaseDialog.cpp <span style="color: grey">(bc25c4c)</span></li>
<li>sheets/dialogs/FormulaDialog.cpp <span style="color: grey">(5d8acfb)</span></li>
<li>sheets/dialogs/GotoDialog.cpp <span style="color: grey">(9ae4be2)</span></li>
<li>sheets/dialogs/LayoutDialog.cpp <span style="color: grey">(69772dd)</span></li>
<li>sheets/dialogs/LinkDialog.cpp <span style="color: grey">(f5f7332)</span></li>
<li>sheets/dialogs/NamedAreaDialog.cpp <span style="color: grey">(87d597c)</span></li>
<li>sheets/dialogs/ShowColRowDialog.cpp <span style="color: grey">(0aa073b)</span></li>
<li>sheets/dialogs/ShowDialog.cpp <span style="color: grey">(e703e3d)</span></li>
<li>sheets/dialogs/StyleManagerDialog.cpp <span style="color: grey">(b932002)</span></li>
<li>sheets/interfaces/SheetAdaptor.cpp <span style="color: grey">(97bd61d)</span></li>
<li>sheets/part/CanvasItem.cpp <span style="color: grey">(e7577b5)</span></li>
<li>sheets/part/Doc.cpp <span style="color: grey">(c9d60cf)</span></li>
<li>sheets/part/HeaderItems.cpp <span style="color: grey">(b589542)</span></li>
<li>sheets/part/HeaderWidgets.cpp <span style="color: grey">(9fb14bb)</span></li>
<li>sheets/part/View.cpp <span style="color: grey">(0ad5be8)</span></li>
<li>sheets/part/dialogs/PreferenceDialog.cpp <span style="color: grey">(36a91ee)</span></li>
<li>sheets/plugins/calendar/CalendarTool.cpp <span style="color: grey">(71c4332)</span></li>
<li>sheets/plugins/scripting/ScriptingListener.cpp <span style="color: grey">(508fb5d)</span></li>
<li>sheets/shape/SheetsEditor.cpp <span style="color: grey">(2cc3247)</span></li>
<li>sheets/shape/TableShape.cpp <span style="color: grey">(43777eb)</span></li>
<li>sheets/ui/CellEditor.cpp <span style="color: grey">(b0ca432)</span></li>
<li>sheets/ui/CellToolBase.cpp <span style="color: grey">(7591d7a)</span></li>
<li>sheets/ui/FunctionCompletion.cpp <span style="color: grey">(b3a4d9b)</span></li>
<li>sheets/ui/LocationComboBox.cpp <span style="color: grey">(7a9d827)</span></li>
<li>sheets/ui/MapViewModel.cpp <span style="color: grey">(e66b211)</span></li>
<li>sheets/ui/RegionSelector.cpp <span style="color: grey">(42e711e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109284/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>