<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109108/">http://git.reviewboard.kde.org/r/109108/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit bd2db0cce11765df23a8638a4501d674da78d05c by Friedrich W. H. Kossebau to branch calligra/2.6.</pre>
<br />
<p>- Commit</p>
<br />
<p>On February 22nd, 2013, 11:42 p.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Shantanu Tushar.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Feb. 22, 2013, 11:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Follow-up to http://git.reviewboard.kde.org/r/108996
Inside CalligraActive code the mimetypes are hardcoded a second time, in the overloads of CAAbstractDocumentHandler::supportedMimetypes().
This seems needed, because Calligra Active as a single app supports three kinds of documents, so first has to check by the mimetypes which of the three
document kind handler has to be used.
Attached patch is a workaround for the principal problem, syncs the list of mimetypes in the handler with those in calligraactive.desktop .
See also email "Problems with Calligra Active and mimetypes" to mailinglist calligra-devel.
Okay to backport to 2.6?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Applied patch for package for Plasma Active, loads a lot more files now
(already merged into main repo, see https://build.pub.meego.com/package/files?package=calligra&project=Project%3AKDE%3ADevel )</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>active/src/CAPresentationHandler.cpp <span style="color: grey">(319c60f)</span></li>
<li>active/src/CASpreadsheetHandler.cpp <span style="color: grey">(62670e8)</span></li>
<li>active/src/CATextDocumentHandler.cpp <span style="color: grey">(5f4db02)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109108/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>