<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109071/">http://git.reviewboard.kde.org/r/109071/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Feb. 24, 2013, 12:11 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added use of macros for easier to read code, and moved product set definitions completely into toplevel CMakeLists.txt (sure, quite long now, but read on...)
Actually those product set definitions could be done in included cmake files, especially if the filters will be also included into the product set definitions.
With one separate file per product set this will make it even easier to define your own product set, without having to hack the buildsystem.
And those separate files could also be generated from a product set/build configuration tool, like Jaros?aw proposed to have.
But lets do it in little steps and start with this patch :)
Separating the "app/" for Stage and Words is waiting the final "Ship it" at https://git.reviewboard.kde.org/r/109082/ (hint, hint...), so this patch would be rebased and committed only once that other is committed.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">PRODUCTSET is a substitute for the old non-exclusive options CREATIVEONLY and TINY (which then are handled exclusively, eek), with migration support for CREATIVEONLY flag. Predefined hardcoded productsets are ACTIVE, CREATIVE, DESKTOP, and ALL (as fallback and default).
Patch also turns buildsystem to have a SHOULD_BUILD for each product (app/plugin), which then all get turned on centrally in groups depending on the productset, instead of everywhere having overlapping and hard to oversee if-else blocks deciding what gets build and what not.
Not the perfect final solution, but a first step into the right direction IMHO.
Known issues:
* BUILD_AUTHOR is not yet set
Patch can be also tested as branch addProductSetBuildParameter-kossebau.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>stage/part/stage.desktop <span style="color: grey">(447858f)</span></li>
<li>words/CMakeLists.txt <span style="color: grey">(e6336a2)</span></li>
<li>words/app/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/app/Info.plist.template <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/app/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/app/words.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/CMakeLists.txt <span style="color: grey">(56b8c6f)</span></li>
<li>words/part/Info.plist.template <span style="color: grey">(97e1728)</span></li>
<li>words/part/main.cpp <span style="color: grey">(875eb5d)</span></li>
<li>words/part/words.desktop <span style="color: grey">(35bc4c3)</span></li>
<li>CMakeLists.txt <span style="color: grey">(564c0a0)</span></li>
<li>devtools/CMakeLists.txt <span style="color: grey">(f0e7b62)</span></li>
<li>extras/CMakeLists.txt <span style="color: grey">(70edca7)</span></li>
<li>filters/CMakeLists.txt <span style="color: grey">(5acecef)</span></li>
<li>filters/sheets/CMakeLists.txt <span style="color: grey">(351a8e2)</span></li>
<li>filters/words/CMakeLists.txt <span style="color: grey">(0c2107c)</span></li>
<li>libs/CMakeLists.txt <span style="color: grey">(2036cf5)</span></li>
<li>plugins/CMakeLists.txt <span style="color: grey">(0e87b1e)</span></li>
<li>sheets/CMakeLists.txt <span style="color: grey">(9f96e41)</span></li>
<li>stage/CMakeLists.txt <span style="color: grey">(94dd31c)</span></li>
<li>stage/app/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/app/Info.plist.template <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/app/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/app/stage.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/CMakeLists.txt <span style="color: grey">(de57a0f)</span></li>
<li>stage/part/Info.plist.template <span style="color: grey">(857a8d7)</span></li>
<li>stage/part/main.cpp <span style="color: grey">(5ef9509)</span></li>
<li>3rdparty/CMakeLists.txt <span style="color: grey">(a300bd2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109071/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>