<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109057/">http://git.reviewboard.kde.org/r/109057/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 20th, 2013, 9:29 p.m. UTC, <b>Jarosław Staniek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109057/diff/1/?file=114555#file114555line130" style="color: black; font-weight: bold; text-decoration: underline;">kexi/formeditor/editlistviewdialog.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">EditListViewDialog::EditListViewDialog(QWidget *parent)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">130</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span><span class="n">m_propSet</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">propertyChanged</span><span class="p">(</span><span class="n">KoProperty</span><span class="o">::</span><span class="n">Set</span><span class="hl"> </span><span class="o"><span class="hl">&</span></span><span class="hl"> </span><span class="n">KoProperty</span><span class="o">::</span><span class="n">Property</span><span class="o"><span class="hl">&</span></span><span class="p">)),</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">130</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span><span class="n">m_propSet</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">propertyChanged</span><span class="p">(</span><span class="n">KoProperty</span><span class="o">::</span><span class="n">SetKoProperty</span><span class="o">::</span><span class="n">Property</span><span class="p">)),</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">missing ','</pre>
</blockquote>
<p>On February 21st, 2013, 8:48 a.m. UTC, <b>Inge Wallin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hmm, seems there was no comment even before. I'm surprised that it ever worked. :)</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It's for (currently) unused widget, that's why we missed this bug. So right that's your good catch anyway :)</pre>
<br />
<p>- Jarosław</p>
<br />
<p>On February 20th, 2013, 5:33 p.m. UTC, Inge Wallin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Jarosław Staniek.</div>
<div>By Inge Wallin.</div>
<p style="color: grey;"><i>Updated Feb. 20, 2013, 5:33 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch does signature normalization for SIGNAL and SLOT macros in kexi.
I did it after Jaroslaw asked me, otherwise I would have waited until after the similar patch for Plan was either ok'ed or denied.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not tested. Should be at least inspected but probably also tested by some Kexi developer.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/widget/tableview/kexitableview.cpp <span style="color: grey">(6f3559f)</span></li>
<li>kexi/widget/tableview/kexitableviewheader.cpp <span style="color: grey">(3405bbe)</span></li>
<li>kexi/widget/relations/KexiRelationsTableContainer_p.cpp <span style="color: grey">(bf0ebe5)</span></li>
<li>kexi/widget/relations/KexiRelationsView.cpp <span style="color: grey">(6e47811)</span></li>
<li>kexi/widget/tableview/kexiblobtableedit.cpp <span style="color: grey">(286d068)</span></li>
<li>kexi/widget/tableview/kexicomboboxbase.cpp <span style="color: grey">(7a15e48)</span></li>
<li>kexi/widget/tableview/kexicomboboxpopup.cpp <span style="color: grey">(6239a88)</span></li>
<li>kexi/widget/tableview/kexicomboboxtableedit.cpp <span style="color: grey">(0279280)</span></li>
<li>kexi/widget/tableview/kexidatatableview.cpp <span style="color: grey">(93da5b6)</span></li>
<li>kexi/widget/tableview/kexiinputtableedit.cpp <span style="color: grey">(d75e3d5)</span></li>
<li>kexi/widget/kexieditor.cpp <span style="color: grey">(cf7026c)</span></li>
<li>kexi/widget/navigator/KexiProjectNavigator.cpp <span style="color: grey">(0692225)</span></li>
<li>kexi/widget/pixmapcollection.cpp <span style="color: grey">(f529cbe)</span></li>
<li>kexi/widget/relations/KexiRelationsScrollArea.cpp <span style="color: grey">(e7a1f0f)</span></li>
<li>kexi/widget/relations/KexiRelationsTableContainer.cpp <span style="color: grey">(5ae28099)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawarepropertyset.cpp <span style="color: grey">(75ce03c)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawareview.cpp <span style="color: grey">(8aa9553)</span></li>
<li>kexi/widget/fields/KexiFieldComboBox.cpp <span style="color: grey">(edd7dc3)</span></li>
<li>kexi/widget/fields/KexiFieldListView.cpp <span style="color: grey">(ebf6074)</span></li>
<li>kexi/widget/KexiDataSourceComboBox.cpp <span style="color: grey">(6066bca)</span></li>
<li>kexi/widget/KexiFileWidget.cpp <span style="color: grey">(d014f8f)</span></li>
<li>kexi/widget/KexiNameWidget.cpp <span style="color: grey">(6157b33)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawareobjectiface.cpp <span style="color: grey">(deeb867)</span></li>
<li>kexi/plugins/tables/kexilookupcolumnpage.cpp <span style="color: grey">(09550e7)</span></li>
<li>kexi/plugins/tables/kexitabledesignerview.cpp <span style="color: grey">(4f49d21)</span></li>
<li>kexi/plugins/tables/kexitablepart.cpp <span style="color: grey">(8cbf0ba)</span></li>
<li>kexi/plugins/forms/widgets/kexidbdatetimeedit.cpp <span style="color: grey">(e22188f)</span></li>
<li>kexi/plugins/forms/widgets/kexidbimagebox.cpp <span style="color: grey">(ef29751)</span></li>
<li>kexi/plugins/forms/widgets/kexidblineedit.cpp <span style="color: grey">(a711dd7)</span></li>
<li>kexi/plugins/forms/widgets/kexidbtimeedit.cpp <span style="color: grey">(aa00958)</span></li>
<li>kexi/plugins/forms/widgets/mapbrowser/MapBrowserWidget.cpp <span style="color: grey">(a772667)</span></li>
<li>kexi/plugins/importexport/csv/kexicsvexportwizard.cpp <span style="color: grey">(58020ae)</span></li>
<li>kexi/plugins/importexport/csv/kexicsvimportdialog.cpp <span style="color: grey">(fe6beb7)</span></li>
<li>kexi/plugins/importexport/csv/kexicsvwidgets.cpp <span style="color: grey">(e175a25)</span></li>
<li>kexi/plugins/queries/kexiquerydesignerguieditor.cpp <span style="color: grey">(6a36eb8)</span></li>
<li>kexi/plugins/queries/kexiquerypart.cpp <span style="color: grey">(1407756)</span></li>
<li>kexi/plugins/scripting/kexiscripting/kexiscriptdesignview.cpp <span style="color: grey">(93b6b7b)</span></li>
<li>kexi/plugins/shapes/relationdesign/kexirelationdesigntool.cpp <span style="color: grey">(da32fee)</span></li>
<li>kexi/plugins/autoforms/widgets/AutoLineEdit.cpp <span style="color: grey">(38ac33f)</span></li>
<li>kexi/plugins/forms/kexidatasourcepage.cpp <span style="color: grey">(d55d205)</span></li>
<li>kexi/plugins/forms/kexiformmanager.cpp <span style="color: grey">(105979a)</span></li>
<li>kexi/plugins/forms/kexiformpart.cpp <span style="color: grey">(b276eb7)</span></li>
<li>kexi/plugins/forms/kexiformview.cpp <span style="color: grey">(3ffc0a8)</span></li>
<li>kexi/plugins/forms/widgets/kexidbdateedit.cpp <span style="color: grey">(5400ff3)</span></li>
<li>kexi/main/kexifinddialog.cpp <span style="color: grey">(3734329)</span></li>
<li>kexi/main/kexistatusbar.cpp <span style="color: grey">(6d4b447)</span></li>
<li>kexi/main/startup/KexiStartupDialog.cpp <span style="color: grey">(011a6a1)</span></li>
<li>kexi/main/startup/KexiStartupFileDialog_win.cpp <span style="color: grey">(286b874)</span></li>
<li>kexi/main/startup/KexiStartupFileHandler.cpp <span style="color: grey">(6ba57c4)</span></li>
<li>kexi/main/startup/KexiStartup_p.cpp <span style="color: grey">(4c4f8da)</span></li>
<li>kexi/migration/AlterSchemaWidget.cpp <span style="color: grey">(ef9f9f5)</span></li>
<li>kexi/mobile/KexiMobileMainWindow.cpp <span style="color: grey">(7a9360d)</span></li>
<li>kexi/formeditor/form.cpp <span style="color: grey">(36fc833)</span></li>
<li>kexi/formeditor/richtextdialog.cpp <span style="color: grey">(e28bcd8)</span></li>
<li>kexi/formeditor/tabstopdialog.cpp <span style="color: grey">(134447a)</span></li>
<li>kexi/formeditor/widgetlibrary.cpp <span style="color: grey">(e8bcd58)</span></li>
<li>kexi/main/KexiMainWindow.cpp <span style="color: grey">(50d59c5)</span></li>
<li>kexi/formeditor/WidgetTreeWidget.cpp <span style="color: grey">(10ff5d6)</span></li>
<li>kexi/formeditor/connectiondialog.cpp <span style="color: grey">(ebaad90)</span></li>
<li>kexi/formeditor/editlistviewdialog.cpp <span style="color: grey">(ea9559c)</span></li>
<li>kexi/formeditor/factories/containerfactory.cpp <span style="color: grey">(f55055e)</span></li>
<li>kexi/core/kexisharedactionhost.cpp <span style="color: grey">(7e9e406)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109057/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>