<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109082/">http://git.reviewboard.kde.org/r/109082/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, C. Boemann and Thorsten Zachmann.</div>
<div>By Friedrich W. H. Kossebau.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Splitting out the app-related files from the part/ directory makes the sources easier to grasp (should also help beginners with Calligra code). And it also results in having the complete sources for the product "Stage executable" and "Words executable" in a separate dir structure, so decision about building it or not is not some if-defed longer span in a CMakeLists.txt file (of part/), but instead can be done in simply-to-overlook lines in the dir level above, like
--- 8< ---
if (SHOULD_BUILD_WORDS_APP)
add_subdirectory( app )
endif (SHOULD_BUILD_WORDS_APP)
--- 8< ---
In preparation for https://git.reviewboard.kde.org/r/109071/ which currently also includes this changes.
Possibly should be done for all programs which have such a part/ dir and still include the app-related files there. But for now only Sheets, Stage and Words are to be separated in two products each, the core/part (also used by CalligraActive) and the executable (not needed with CalligraActive).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>stage/CMakeLists.txt <span style="color: grey">(94dd31c)</span></li>
<li>stage/app/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/app/Info.plist.template <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/app/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/app/stage.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/CMakeLists.txt <span style="color: grey">(de57a0f)</span></li>
<li>stage/part/Info.plist.template <span style="color: grey">(857a8d7)</span></li>
<li>stage/part/main.cpp <span style="color: grey">(5ef9509)</span></li>
<li>stage/part/stage.desktop <span style="color: grey">(447858f)</span></li>
<li>words/CMakeLists.txt <span style="color: grey">(e6336a2)</span></li>
<li>words/app/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/app/Info.plist.template <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/app/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/app/words.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/CMakeLists.txt <span style="color: grey">(56b8c6f)</span></li>
<li>words/part/Info.plist.template <span style="color: grey">(97e1728)</span></li>
<li>words/part/main.cpp <span style="color: grey">(875eb5d)</span></li>
<li>words/part/words.desktop <span style="color: grey">(35bc4c3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109082/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>