<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108994/">http://git.reviewboard.kde.org/r/108994/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit cceca089f2c732532b9375b17583b85364613028 by Inge Wallin to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On February 17th, 2013, 3:44 p.m. UTC, Inge Wallin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Shantanu Tushar.</div>
<div>By Inge Wallin.</div>
<p style="color: grey;"><i>Updated Feb. 17, 2013, 3:44 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I added a tool to normalize SIGNAL and SLOT signatures to tools/fixsrc.py. This patch is the result of the first run of this tool. I chose to start with Calligra Active because it had the shortest list of unnormalized connects.
I can't see anything wrong with the output but I'm not comfortable with this concept yet to just commit it, hence this review request.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>active/src/CAPAView.cpp <span style="color: grey">(1d6f9d4)</span></li>
<li>active/src/CAPresentationHandler.cpp <span style="color: grey">(b0ff628)</span></li>
<li>active/src/CASpreadsheetHandler.cpp <span style="color: grey">(ccbe9a5)</span></li>
<li>active/src/CATextDocumentHandler.cpp <span style="color: grey">(1b36c4d)</span></li>
<li>active/src/MainWindow.cpp <span style="color: grey">(c77ea23)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108994/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>