<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108870/">http://git.reviewboard.kde.org/r/108870/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit b25faa381be44b6fc35583812bb1b1037a8d0db5 by Friedrich W. H. Kossebau to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On February 9th, 2013, 2:13 a.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Dag Andersen and Marijn Kruisselbrink.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Feb. 9, 2013, 2:13 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As discussed on ml calligra-devel (http://lists.kde.org/?t=135930419600001&r=1&w=2), it's time to jump to 4.6.0 as minimal KDE Platform dependency.
Once Inge can report he has upgraded, this should go into master.
Patch also cleans up all then dead code branches. And additionally ports the remaining calls of deprecated KCalendarSystem methods. Sadly there is one call (KCalendarSystem::weekNumber(...)) which only gets deprecated with a substitute call in KDE Platform 4.7, so a few KDE_IS_VERSION have to go in again.
Mainly effected are Plan's and Sheets' code, so cc: the maintainers to give the patch an extra check.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No changes in local "make test" run.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(0d8dfc0)</span></li>
<li>filters/plan/mpxj/import/mpxjimport.cpp <span style="color: grey">(cebe50d)</span></li>
<li>filters/sheets/opencalc/opencalcexport.cc <span style="color: grey">(46d7c59)</span></li>
<li>kexi/formeditor/widgetfactory.cpp <span style="color: grey">(3dc9cfa)</span></li>
<li>kexi/kexiutils/KexiCategorizedView.h <span style="color: grey">(57eb945)</span></li>
<li>libs/main/KoApplication.cpp <span style="color: grey">(da90d2b)</span></li>
<li>libs/main/KoMainWindow.cpp <span style="color: grey">(625a742)</span></li>
<li>libs/main/config/KoConfigGridPage.cpp <span style="color: grey">(aa3394b)</span></li>
<li>plan/kpttaskdefaultpanel.cpp <span style="color: grey">(3b54e42)</span></li>
<li>plan/libs/kernel/KPlatoXmlLoaderBase.cpp <span style="color: grey">(fe78979)</span></li>
<li>plan/libs/kernel/kptcommand.cpp <span style="color: grey">(852faad)</span></li>
<li>plan/libs/kernel/kptdebug.cpp <span style="color: grey">(80f0ef3)</span></li>
<li>plan/libs/kernel/kptproject.cpp <span style="color: grey">(d67ff53)</span></li>
<li>plan/libs/models/kcalendar/kdatepicker.cpp <span style="color: grey">(df82168)</span></li>
<li>plan/libs/models/kcalendar/kdatetable.cpp <span style="color: grey">(378242b)</span></li>
<li>plan/libs/models/kptcalendarmodel.cpp <span style="color: grey">(06a4737)</span></li>
<li>plan/libs/ui/kptmainprojectpanel.cpp <span style="color: grey">(fa47fc1)</span></li>
<li>plan/libs/ui/kptresourcedialog.cpp <span style="color: grey">(a25a936)</span></li>
<li>plan/libs/ui/kptsummarytaskgeneralpanel.cpp <span style="color: grey">(540a28f)</span></li>
<li>plan/libs/ui/kpttaskgeneralpanel.cpp <span style="color: grey">(1123cf9)</span></li>
<li>plan/libs/ui/locale/localemon.cpp <span style="color: grey">(eece046)</span></li>
<li>plan/plugins/scripting/ScriptingPart.cpp <span style="color: grey">(c198e46)</span></li>
<li>plan/workpackage/debugarea.cpp <span style="color: grey">(725007b)</span></li>
<li>sheets/Localization.cpp <span style="color: grey">(28caec1)</span></li>
<li>sheets/ValueFormatter.cpp <span style="color: grey">(a9850da)</span></li>
<li>sheets/plugins/calendar/CalendarTool.cpp <span style="color: grey">(00950e3)</span></li>
<li>sheets/ui/CellToolBase.cpp <span style="color: grey">(ac0a43f)</span></li>
<li>sheets/ui/CellToolBase_p.cpp <span style="color: grey">(aa4312f)</span></li>
<li>tools/calligra/main.cpp <span style="color: grey">(cc30ffa)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108870/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>