<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108937/">http://git.reviewboard.kde.org/r/108937/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks ok to me -- I'm not sure I grasp the old situation, but the new situation makes sense.</pre>
<br />
<p>- Boudewijn</p>
<br />
<p>On February 13th, 2013, 6:15 a.m. UTC, Thorsten Zachmann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and C. Boemann.</div>
<div>By Thorsten Zachmann.</div>
<p style="color: grey;"><i>Updated Feb. 13, 2013, 6:15 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix memory leak in KoShapeContainer.
This fixes a big memoryleak resulting in quite a lot of shapes not getting deleted when the document is deleted.
This also fixes crashes on shutdown currently seen in cstester in quite some calligra words files.
Problem for the crashes is that some shapes and QTextDocuments while others still trigger relayouting which uses the no longer deleted objects.
The patch fixes that by deleting the shapes and making sure there is no relayout when the stuff is deleted.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with cstester and the crashes seen before are gone.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/ui/flake/kis_shape_layer.cc <span style="color: grey">(796b53c)</span></li>
<li>libs/flake/KoShapeContainer.cpp <span style="color: grey">(93be3e1)</span></li>
<li>libs/kopageapp/KoPAPageBase.cpp <span style="color: grey">(0b89a7b)</span></li>
<li>words/part/frames/KWFrame.cpp <span style="color: grey">(552b04c)</span></li>
<li>words/part/frames/KWFrameSet.h <span style="color: grey">(20b1bfc)</span></li>
<li>words/part/frames/KWFrameSet.cpp <span style="color: grey">(c002f4e)</span></li>
<li>words/part/frames/KWTextFrameSet.cpp <span style="color: grey">(f600a5b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108937/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>