<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107100/">http://git.reviewboard.kde.org/r/107100/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 6th, 2013, 10:53 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Has this been commited? It's has Ship it! but still shows as open in reviewboard.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'll do so on behalf of Dimitrios.</pre>
<br />
<p>- Jarosław</p>
<br />
<p>On November 21st, 2012, 10:49 p.m. UTC, Dimitrios Tanis wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Oleg Kukharchuk, Adam Pigg, and Jarosław Staniek.</div>
<div>By Dimitrios Tanis.</div>
<p style="color: grey;"><i>Updated Nov. 21, 2012, 10:49 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When trying to create/open/import a project that requires a database server driver, if none is found display a message informing about it and giving general instructions what to do.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works when no db server driver present. IMHO though this solution is not elegant at all as it is implemented in 3 different places.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=131092">131092</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/kexiutils/utils.cpp <span style="color: grey">(4f101e1)</span></li>
<li>kexi/main/startup/KexiNewProjectAssistant.h <span style="color: grey">(af89ef2)</span></li>
<li>kexi/main/startup/KexiNewProjectAssistant.cpp <span style="color: grey">(75efbc1)</span></li>
<li>kexi/main/startup/KexiOpenProjectAssistant.h <span style="color: grey">(595b0bb)</span></li>
<li>kexi/main/startup/KexiOpenProjectAssistant.cpp <span style="color: grey">(6af1e01)</span></li>
<li>kexi/widget/CMakeLists.txt <span style="color: grey">(841794e)</span></li>
<li>kexi/widget/KexiConnectionSelectorWidget.h <span style="color: grey">(43bd7cc)</span></li>
<li>kexi/widget/KexiConnectionSelectorWidget.cpp <span style="color: grey">(fd5c414)</span></li>
<li>kexi/widget/KexiServerDriverNotFoundMessage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/widget/KexiServerDriverNotFoundMessage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/kexiutils/utils.h <span style="color: grey">(140ed7b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107100/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/107100/s/800/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/10/29/kexi-nodrivers1_400x100.png" style="border: 1px black solid;" alt="" /></a>
<a href="http://git.reviewboard.kde.org/r/107100/s/801/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/10/29/kexi-nodrivers2_400x100.png" style="border: 1px black solid;" alt="" /></a>
<a href="http://git.reviewboard.kde.org/r/107100/s/802/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/10/29/kexi-nodrivers3_400x100.png" style="border: 1px black solid;" alt="" /></a>
<a href="http://git.reviewboard.kde.org/r/107100/s/839/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/11/20/kexi-nodrivers1_2_400x100.png" style="border: 1px black solid;" alt="" /></a>
<a href="http://git.reviewboard.kde.org/r/107100/s/840/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/11/20/kexi-nodrivers2_2_400x100.png" style="border: 1px black solid;" alt="" /></a>
<a href="http://git.reviewboard.kde.org/r/107100/s/841/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/11/20/kexi-nodrivers3_2_400x100.png" style="border: 1px black solid;" alt="" /></a>
<a href="http://git.reviewboard.kde.org/r/107100/s/842/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/11/21/kexi-nodrivers1_3_400x100.png" style="border: 1px black solid;" alt="" /></a>
<a href="http://git.reviewboard.kde.org/r/107100/s/843/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/11/21/kexi-nodrivers2_3_400x100.png" style="border: 1px black solid;" alt="" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>