<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108710/">http://git.reviewboard.kde.org/r/108710/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 2nd, 2013, 9:31 p.m. UTC, <b>Boudewijn Rempt</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hm... This class was used in some places previously, like the tonemapping plugin. It's still used (sort of) in some code in the krita2-plugins repo, but those aren't being built at the moment, as far as I know.</pre>
</blockquote>
<p>On February 5th, 2013, 7:35 p.m. UTC, <b>Boudewijn Rempt</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Let's just remove the unused code -- for the kritaplugins we can always make a copy of the class in there, when we get down to fixing the build.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Okay, will remove the file then, together with the small unit test.</pre>
<br />
<p>- Friedrich W. H.</p>
<br />
<p>On February 2nd, 2013, 4:21 a.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Boudewijn Rempt.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Feb. 2, 2013, 4:21 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The class KisGenericColorSpace has two methods which do not exactly match the signatures of methods with the same name in the base-class KoColorSpace: convertToQImage(...) and convertPixelsTo(...). Both miss the additional parameter "KoColorConversionTransformation::ConversionFlags conversionFlags".
So if that is on purpose, both overriden methods from KoColorSpace should be added with "using" in the private or protected section of KisGenericColorSpace, to unhide them and thus get rid of compiler warnings.
But I wonder if KisGenericColorSpace is used at all: grepping for it only showed KisGenericColorSpaceTest to use it. Perhaps time for removal of the whole class then? Or is it for 3rd-party users of the Krita libs?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/image/kis_generic_colorspace.h <span style="color: grey">(011477a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108710/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>