<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108096/">http://git.reviewboard.kde.org/r/108096/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Adam Pigg and Jarosław Staniek.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Feb. 4, 2013, 10:18 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Integrated Jaros?aw's feedback.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Reworked KoReport section editor dialogs, especially Ok/Cancel/Close dialog buttons. Oh, and now also these:
* base on KDialog
* put labels in front of QCheckboxes
* follow KDE UI guidelines for all text strings
* disable buttons when no-ops
* only offer columns for section grouping which are not used yet
* do not leave an empty group on clicking Cancel during process of adding a new section group
* skip empty field/key when offering fields for grouping
* make API of ReportSectionDetail consistent (GroupSection where just Section was used)
* removed any manually set spacings/margins, besides the 0 margins, looks less strange now
Better now? :)
And okay to backport to 2.6, without the string changes?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Used in Kexi, works better as before.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/koreport/wrtembed/detailgroupsectiondialog.h <span style="color: grey">(df5504e)</span></li>
<li>libs/koreport/wrtembed/detailgroupsectiondialog.cpp <span style="color: grey">(ec0c84c)</span></li>
<li>libs/koreport/wrtembed/detailgroupsectiondialog.ui <span style="color: grey">(32f4700)</span></li>
<li>libs/koreport/wrtembed/reportsectiondetail.h <span style="color: grey">(3079d5a)</span></li>
<li>libs/koreport/wrtembed/reportsectiondetail.cpp <span style="color: grey">(5163611)</span></li>
<li>libs/koreport/wrtembed/reportsectiondetailgroup.h <span style="color: grey">(94cebf4)</span></li>
<li>libs/koreport/wrtembed/sectioneditor.h <span style="color: grey">(97a20c6)</span></li>
<li>libs/koreport/wrtembed/sectioneditor.cpp <span style="color: grey">(e7b9205)</span></li>
<li>libs/koreport/wrtembed/sectioneditor.ui <span style="color: grey">(ba9a337)</span></li>
<li>plan/libs/ui/reports/reportview.cpp <span style="color: grey">(dee77a6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108096/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>