<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108725/">http://git.reviewboard.kde.org/r/108725/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 3rd, 2013, 10:20 a.m. UTC, <b>C. Boemann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Okay, I've now tested in words, stage and sheets with all the combinations I can think which might have problems with this.
Not finding, and I like you solution as well, although the manual tweaks needed for modebox and krita are a little bit concerning, because when will it be needed the next time.
Can yuo elaborate a bit in the api dox please.
You can commit when you have done that, and you are also allowed to backport after a grace period of a few days
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What do you want to add to the api dox?
The changes in the applications are just unnecessary because of a non-standard way they use some things. For example the Modebox was setup after the canvas controller had already initialized the dockers, so it was buggy even before my change. </pre>
<br />
<p>- Sven</p>
<br />
<p>On February 3rd, 2013, 4:35 a.m. UTC, Sven Langkamp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Sven Langkamp.</div>
<p style="color: grey;"><i>Updated Feb. 3, 2013, 4:35 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The patch fixes the unset problem of request 108683. The previous patch had some side effect on Sheets. Now before unset it's check if the canvas of the KoCanvasObserve matches the one which is unset.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixes the bug in Krita. Didn't see side effects on other applications.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=314029">314029</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/plugins/extensions/dockers/flipbook/flipbookdocker_dock.cpp <span style="color: grey">(9bc51da)</span></li>
<li>libs/flake/KoCanvasControllerWidget.cpp <span style="color: grey">(a85337a)</span></li>
<li>libs/flake/KoCanvasObserverBase.h <span style="color: grey">(927897c)</span></li>
<li>libs/flake/KoCanvasObserverBase.cpp <span style="color: grey">(954fc2e)</span></li>
<li>libs/main/KoModeBox.cpp <span style="color: grey">(1c81fa2)</span></li>
<li>sheets/part/View.cpp <span style="color: grey">(3adb2f5)</span></li>
<li>words/part/KWGui.cpp <span style="color: grey">(607db56)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108725/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>