<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108698/">http://git.reviewboard.kde.org/r/108698/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Huge request :) but actually most is file moves so looks quite good imho.
I probably should test it so I neeed some more time for that. However looking through the code I see no problems</pre>
<br />
<p>- C.</p>
<br />
<p>On February 1st, 2013, 1:16 p.m. UTC, Boudewijn Rempt wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Boudewijn Rempt.</div>
<p style="color: grey;"><i>Updated Feb. 1, 2013, 1:16 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch moves the rdf code from komain to a kordf library, and only words and calligraactive link to that. There is one tricky bit, the rdf page in the document info dialog, but that's fixed as well. There's now no ifdeffing anymore in kotext for rdf either.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Manual tests + unittests.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(34ff56d)</span></li>
<li>active/CMakeLists.txt <span style="color: grey">(7cabbef)</span></li>
<li>krita/plugins/formats/qml/qml_export.cc <span style="color: grey">(800d13c)</span></li>
<li>krita/ui/kis_doc2.h <span style="color: grey">(e4d2249)</span></li>
<li>krita/ui/kis_doc2.cc <span style="color: grey">(f0dcc28)</span></li>
<li>libs/CMakeLists.txt <span style="color: grey">(2a880c9)</span></li>
<li>libs/kotext/KoDocumentRdfBase.h <span style="color: grey">(211b3a8)</span></li>
<li>libs/kotext/KoTextEditor.cpp <span style="color: grey">(98f22b8)</span></li>
<li>libs/kotext/KoTextOdfSaveHelper.cpp <span style="color: grey">(f7cbf9a)</span></li>
<li>libs/kotext/KoTextSopranoRdfModel_p.h <span style="color: grey">(80ae5bb)</span></li>
<li>libs/kotext/commands/TextPasteCommand.cpp <span style="color: grey">(d203b5a)</span></li>
<li>libs/kotext/opendocument/KoTextSharedSavingData.cpp <span style="color: grey">(3fb3d51)</span></li>
<li>libs/main/CMakeLists.txt <span style="color: grey">(9b54bfb)</span></li>
<li>libs/main/KoDocument.h <span style="color: grey">(ed8d1b7)</span></li>
<li>libs/main/KoDocument.cpp <span style="color: grey">(66ad868)</span></li>
<li>libs/main/KoDocumentInfoDlg.h <span style="color: grey">(c93e3f5)</span></li>
<li>libs/main/KoDocumentInfoDlg.cpp <span style="color: grey">(9870341)</span></li>
<li>libs/main/KoMainWindow.cpp <span style="color: grey">(01689ac)</span></li>
<li>libs/main/rdf/InsertSemanticObjectActionBase.h <span style="color: grey">(86dc07a)</span></li>
<li>libs/main/rdf/InsertSemanticObjectActionBase.cpp <span style="color: grey">(23d7e6a)</span></li>
<li>libs/main/rdf/InsertSemanticObjectCreateAction.h <span style="color: grey">(344e307)</span></li>
<li>libs/main/rdf/InsertSemanticObjectCreateAction.cpp <span style="color: grey">(2ba731f)</span></li>
<li>libs/main/rdf/InsertSemanticObjectReferenceAction.h <span style="color: grey">(607468c)</span></li>
<li>libs/main/rdf/InsertSemanticObjectReferenceAction.cpp <span style="color: grey">(45a4a3f)</span></li>
<li>libs/main/rdf/KoChangeTrackerDisabledRAII.h <span style="color: grey">(5ac98bd)</span></li>
<li>libs/main/rdf/KoChangeTrackerDisabledRAII.cpp <span style="color: grey">(8511646)</span></li>
<li>libs/main/rdf/KoDocumentRdf.h <span style="color: grey">(2c1d196)</span></li>
<li>libs/main/rdf/KoDocumentRdf.cpp <span style="color: grey">(6cceae6)</span></li>
<li>libs/main/rdf/KoDocumentRdfEditWidget.h <span style="color: grey">(bb7c10f)</span></li>
<li>libs/main/rdf/KoDocumentRdfEditWidget.cpp <span style="color: grey">(b779729)</span></li>
<li>libs/main/rdf/KoDocumentRdfEditWidget.ui <span style="color: grey">(ea343f8)</span></li>
<li>libs/main/rdf/KoDocumentRdfEditWidgetBase.h <span style="color: grey">(8362bc8)</span></li>
<li>libs/main/rdf/KoDocumentRdfEditWidgetBase.cpp <span style="color: grey">(36a6ce2)</span></li>
<li>libs/main/rdf/KoRdfCalendarEvent.h <span style="color: grey">(60dcfa3)</span></li>
<li>libs/main/rdf/KoRdfCalendarEvent.cpp <span style="color: grey">(6658a6c)</span></li>
<li>libs/main/rdf/KoRdfCalendarEventEditWidget.ui <span style="color: grey">(2ad3024)</span></li>
<li>libs/main/rdf/KoRdfCalendarEventTreeWidgetItem.h <span style="color: grey">(8209962)</span></li>
<li>libs/main/rdf/KoRdfCalendarEventTreeWidgetItem.cpp <span style="color: grey">(56a9f14)</span></li>
<li>libs/main/rdf/KoRdfFoaF.h <span style="color: grey">(6892133)</span></li>
<li>libs/main/rdf/KoRdfFoaF.cpp <span style="color: grey">(7c85717)</span></li>
<li>libs/main/rdf/KoRdfFoaFEditWidget.ui <span style="color: grey">(e938036)</span></li>
<li>libs/main/rdf/KoRdfFoaFTreeWidgetItem.h <span style="color: grey">(47ae0ec)</span></li>
<li>libs/main/rdf/KoRdfFoaFTreeWidgetItem.cpp <span style="color: grey">(4198ba1)</span></li>
<li>libs/main/rdf/KoRdfLocation.h <span style="color: grey">(2d0851d)</span></li>
<li>libs/main/rdf/KoRdfLocation.cpp <span style="color: grey">(77f78c7)</span></li>
<li>libs/main/rdf/KoRdfLocationEditWidget.h <span style="color: grey">(6c27635)</span></li>
<li>libs/main/rdf/KoRdfLocationEditWidget.cpp <span style="color: grey">(fcdcb30)</span></li>
<li>libs/main/rdf/KoRdfLocationEditWidget.ui <span style="color: grey">(8315aa5)</span></li>
<li>libs/main/rdf/KoRdfLocationEditWidgetMarble.ui <span style="color: grey">(49dc790)</span></li>
<li>libs/main/rdf/KoRdfLocationTreeWidgetItem.h <span style="color: grey">(c37619a)</span></li>
<li>libs/main/rdf/KoRdfLocationTreeWidgetItem.cpp <span style="color: grey">(35bf3b6)</span></li>
<li>libs/main/rdf/KoRdfLocationViewWidget.ui <span style="color: grey">(42ada4d)</span></li>
<li>libs/main/rdf/KoRdfLocationViewWidgetMarble.ui <span style="color: grey">(9323e4a)</span></li>
<li>libs/main/rdf/KoRdfPrefixMapping.h <span style="color: grey">(49cedb3)</span></li>
<li>libs/main/rdf/KoRdfPrefixMapping.cpp <span style="color: grey">(d6d3479)</span></li>
<li>libs/main/rdf/KoRdfSemanticItem.h <span style="color: grey">(8bd6fa8)</span></li>
<li>libs/main/rdf/KoRdfSemanticItem.cpp <span style="color: grey">(5b10fde)</span></li>
<li>libs/main/rdf/KoRdfSemanticItemViewSite.h <span style="color: grey">(5bd81ac)</span></li>
<li>libs/main/rdf/KoRdfSemanticItemViewSite.cpp <span style="color: grey">(045e347)</span></li>
<li>libs/main/rdf/KoRdfSemanticItem_p.h <span style="color: grey">(4e00f76)</span></li>
<li>libs/main/rdf/KoRdfSemanticTree.h <span style="color: grey">(9bd4578)</span></li>
<li>libs/main/rdf/KoRdfSemanticTree.cpp <span style="color: grey">(c824e02)</span></li>
<li>libs/main/rdf/KoRdfSemanticTreeWidgetItem.h <span style="color: grey">(962f0ec)</span></li>
<li>libs/main/rdf/KoRdfSemanticTreeWidgetItem.cpp <span style="color: grey">(f13dc57)</span></li>
<li>libs/main/rdf/KoSemanticStylesheet.h <span style="color: grey">(831acb6)</span></li>
<li>libs/main/rdf/KoSemanticStylesheet.cpp <span style="color: grey">(ed0072c)</span></li>
<li>libs/main/rdf/KoSemanticStylesheetsEditor.h <span style="color: grey">(35365a6)</span></li>
<li>libs/main/rdf/KoSemanticStylesheetsEditor.cpp <span style="color: grey">(0c345cb)</span></li>
<li>libs/main/rdf/KoSemanticStylesheetsEditor.ui <span style="color: grey">(3ef5b9a)</span></li>
<li>libs/main/rdf/KoSopranoTableModel.h <span style="color: grey">(bc0344a)</span></li>
<li>libs/main/rdf/KoSopranoTableModel.cpp <span style="color: grey">(8a92beb)</span></li>
<li>libs/main/rdf/KoSopranoTableModelDelegate.h <span style="color: grey">(b8822ca)</span></li>
<li>libs/main/rdf/KoSopranoTableModelDelegate.cpp <span style="color: grey">(46dc34a)</span></li>
<li>libs/main/rdf/RdfForward.h <span style="color: grey">(b847027)</span></li>
<li>libs/main/rdf/RdfSemanticTreeWidgetAction.h <span style="color: grey">(c5aec3c)</span></li>
<li>libs/main/rdf/RdfSemanticTreeWidgetAction.cpp <span style="color: grey">(3ea3e48)</span></li>
<li>libs/main/rdf/RdfSemanticTreeWidgetSelectAction.h <span style="color: grey">(57e7e89)</span></li>
<li>libs/main/rdf/RdfSemanticTreeWidgetSelectAction.cpp <span style="color: grey">(8788946)</span></li>
<li>libs/main/tests/CMakeLists.txt <span style="color: grey">(768d033)</span></li>
<li>libs/main/tests/TestKoDocumentRdf.h <span style="color: grey">(237a6ab)</span></li>
<li>libs/main/tests/TestKoDocumentRdf.cpp <span style="color: grey">(3d05b85)</span></li>
<li>libs/main/tests/TestSemanticItem.h <span style="color: grey">(1a9bd60)</span></li>
<li>libs/main/tests/rdf_test.h <span style="color: grey">(8f6948a)</span></li>
<li>libs/main/tests/rdf_test.cpp <span style="color: grey">(2f58d0d)</span></li>
<li>libs/rdf/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/InsertSemanticObjectActionBase.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/InsertSemanticObjectActionBase.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/InsertSemanticObjectCreateAction.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/InsertSemanticObjectCreateAction.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/InsertSemanticObjectReferenceAction.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/InsertSemanticObjectReferenceAction.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoChangeTrackerDisabledRAII.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoChangeTrackerDisabledRAII.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoDocumentRdf.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoDocumentRdf.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoDocumentRdfEditWidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoDocumentRdfEditWidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoDocumentRdfEditWidget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoRdfCalendarEvent.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoRdfCalendarEvent.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoRdfCalendarEventEditWidget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoRdfCalendarEventTreeWidgetItem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoRdfCalendarEventTreeWidgetItem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoRdfFoaF.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoRdfFoaF.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoRdfFoaFEditWidget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoRdfFoaFTreeWidgetItem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoRdfFoaFTreeWidgetItem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoRdfLocation.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoRdfLocation.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoRdfLocationEditWidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoRdfLocationEditWidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoRdfLocationEditWidget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoRdfLocationEditWidgetMarble.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoRdfLocationTreeWidgetItem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoRdfLocationTreeWidgetItem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoRdfLocationViewWidget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoRdfLocationViewWidgetMarble.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoRdfPrefixMapping.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoRdfPrefixMapping.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoRdfSemanticItem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoRdfSemanticItem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoRdfSemanticItemViewSite.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoRdfSemanticItemViewSite.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoRdfSemanticItem_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoRdfSemanticTree.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoRdfSemanticTree.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoRdfSemanticTreeWidgetItem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoRdfSemanticTreeWidgetItem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoSemanticStylesheet.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoSemanticStylesheet.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoSemanticStylesheetsEditor.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoSemanticStylesheetsEditor.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoSemanticStylesheetsEditor.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoSopranoTableModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoSopranoTableModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoSopranoTableModelDelegate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoSopranoTableModelDelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/RdfForward.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/RdfSemanticTreeWidgetAction.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/RdfSemanticTreeWidgetAction.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/RdfSemanticTreeWidgetSelectAction.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/RdfSemanticTreeWidgetSelectAction.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/kordf_export.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/tests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/tests/TestKoDocumentRdf.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/tests/TestKoDocumentRdf.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/tests/TestSemanticItem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/tests/rdf_test.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/tests/rdf_test.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/reporting/CMakeLists.txt <span style="color: grey">(5497811)</span></li>
<li>plugins/reporting/maps/CMakeLists.txt <span style="color: grey">(3e2d5f0)</span></li>
<li>words/part/CMakeLists.txt <span style="color: grey">(a31ed09)</span></li>
<li>words/part/KWDocument.h <span style="color: grey">(3b60ed7)</span></li>
<li>words/part/KWDocument.cpp <span style="color: grey">(8430180)</span></li>
<li>words/part/KWFactory.cpp <span style="color: grey">(ec08271)</span></li>
<li>words/part/KWOdfLoader.cpp <span style="color: grey">(977832b)</span></li>
<li>words/part/KWOdfWriter.cpp <span style="color: grey">(7c5beaf)</span></li>
<li>words/part/KWView.cpp <span style="color: grey">(77be4b9)</span></li>
<li>words/part/author/CAuFactory.cpp <span style="color: grey">(be20262)</span></li>
<li>words/part/dockers/KWRdfDocker.h <span style="color: grey">(7618449)</span></li>
<li>words/part/dockers/KWRdfDockerTree.cpp <span style="color: grey">(4d13842)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108698/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>