<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108459/">http://git.reviewboard.kde.org/r/108459/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 25th, 2013, 4:25 a.m. UTC, <b>Thorsten Zachmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108459/diff/7/?file=108921#file108921line96" style="color: black; font-weight: bold; text-decoration: underline;">libs/kotext/KoAnchorInlineObject.h</a>
<span style="font-weight: normal;">
(Diff revision 7)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">96</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="nf">saveOdf</span><span class="p">(</span><span class="n">KoShapeSavingContext</span> <span class="o">&</span><span class="n">context</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This function should be const.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ah but it's reimplemented so will have to be changed in many other places too then</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 25th, 2013, 4:25 a.m. UTC, <b>Thorsten Zachmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108459/diff/7/?file=108934#file108934line49" style="color: black; font-weight: bold; text-decoration: underline;">libs/kotext/commands/ChangeAnchorPropertiesCommand.cpp</a>
<span style="font-weight: normal;">
(Diff revision 7)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">ChangeAnchorPropertiesCommand::~ChangeAnchorPropertiesCommand()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">44</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="p">{</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">49</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Should that not delete the m_newLocation/m_oldLocation depending on which one is set when destructing to avoid a memory leak?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I guess but then we risk double deletion, so I'd rather just let the system clean it up</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 25th, 2013, 4:25 a.m. UTC, <b>Thorsten Zachmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108459/diff/7/?file=108944#file108944line861" style="color: black; font-weight: bold; text-decoration: underline;">libs/kotext/opendocument/KoTextWriter_p.cpp</a>
<span style="font-weight: normal;">
(Diff revision 7)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KoTextWriter::Private::saveParagraph(const QTextBlock &block, int from, int to)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">861</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">int</span> <span class="n">changeId</span> <span class="o">=</span> <span class="n">charFormat</span><span class="p">.</span><span class="n">intProperty</span><span class="p">(</span><span class="n">KoCharacterStyle</span><span class="o">::</span><span class="n">ChangeTrackerId</span><span class="p">);</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">862</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KoTextAnchor</span> <span class="o">*</span><span class="n">textAnchor</span> <span class="o">=</span> <span class="k">dynamic_cast</span><span class="o"><</span><span class="n">KoTextAnchor</span> <span class="o">*></span><span class="p">(</span><span class="n">inlineObject</span><span class="p">);</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">863</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">changeTracker</span> <span class="o">&&</span> <span class="n">changeTracker</span><span class="o">-></span><span class="n">saveFormat</span><span class="p">()</span> <span class="o">==</span> <span class="n">KoChangeTracker</span><span class="o">::</span><span class="n">DELTAXML</span><span class="p">)</span> <span class="p">{</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">864</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">textAnchor</span> <span class="o">&&</span> <span class="n">changeId</span> <span class="o">&&</span> <span class="n">changeTracker</span><span class="o">-></span><span class="n">elementById</span><span class="p">(</span><span class="n">changeId</span><span class="p">)</span><span class="o">-></span><span class="n">getChangeType</span><span class="p">()</span> <span class="o">==</span> <span class="n">KoGenChange</span><span class="o">::</span><span class="n">InsertChange</span><span class="p">)</span> <span class="p">{</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">865</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">textAnchor</span><span class="o">-></span><span class="n">shape</span><span class="p">()</span><span class="o">-></span><span class="n">setAdditionalAttribute</span><span class="p">(</span><span class="s">"delta:insertion-change-idref"</span><span class="p">,</span> <span class="n">changeTransTable</span><span class="p">.</span><span class="n">value</span><span class="p">(</span><span class="n">changeId</span><span class="p">));</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">866</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">textAnchor</span><span class="o">-></span><span class="n">shape</span><span class="p">()</span><span class="o">-></span><span class="n">setAdditionalAttribute</span><span class="p">(</span><span class="s">"delta:insertion-type"</span><span class="p">,</span> <span class="s">"insert-with-content"</span><span class="p">);</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">867</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">}</span> <span class="k">else</span> <span class="k">if</span> <span class="p">(</span><span class="n">textAnchor</span> <span class="o">&&</span> <span class="n">changeId</span> <span class="o">&&</span> <span class="n">changeTracker</span><span class="o">-></span><span class="n">elementById</span><span class="p">(</span><span class="n">changeId</span><span class="p">)</span><span class="o">-></span><span class="n">getChangeType</span><span class="p">()</span> <span class="o">==</span> <span class="n">KoGenChange</span><span class="o">::</span><span class="n">DeleteChange</span><span class="p">)</span> <span class="p">{</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">868</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">writer</span><span class="o">-></span><span class="n">startElement</span><span class="p">(</span><span class="s">"delta:removed-content"</span><span class="p">,</span> <span class="nb">false</span><span class="p">);</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">869</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">writer</span><span class="o">-></span><span class="n">addAttribute</span><span class="p">(</span><span class="s">"delta:removal-change-idref"</span><span class="p">,</span> <span class="n">changeTransTable</span><span class="p">.</span><span class="n">value</span><span class="p">(</span><span class="n">changeId</span><span class="p">));</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">870</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">}</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">871</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">}</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">872</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">873</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">inlineObject</span><span class="o">-></span><span class="n">saveOdf</span><span class="p">(</span><span class="n">context</span><span class="p">);</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">861</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">inlineObject</span><span class="o">-></span><span class="n">saveOdf</span><span class="p">(</span><span class="n">context</span><span class="p">);</span></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">874</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">875</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">changeTracker</span> <span class="o">&&</span> <span class="n">changeTracker</span><span class="o">-></span><span class="n">saveFormat</span><span class="p">()</span> <span class="o">==</span> <span class="n">KoChangeTracker</span><span class="o">::</span><span class="n">DELTAXML</span><span class="p">)</span> <span class="p">{</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">876</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">textAnchor</span> <span class="o">&&</span> <span class="n">changeId</span> <span class="o">&&</span> <span class="n">changeTracker</span><span class="o">-></span><span class="n">elementById</span><span class="p">(</span><span class="n">changeId</span><span class="p">)</span><span class="o">-></span><span class="n">getChangeType</span><span class="p">()</span> <span class="o">==</span> <span class="n">KoGenChange</span><span class="o">::</span><span class="n">InsertChange</span><span class="p">)</span> <span class="p">{</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">877</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">textAnchor</span><span class="o">-></span><span class="n">shape</span><span class="p">()</span><span class="o">-></span><span class="n">removeAdditionalAttribute</span><span class="p">(</span><span class="s">"delta:insertion-change-idref"</span><span class="p">);</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">878</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">textAnchor</span><span class="o">-></span><span class="n">shape</span><span class="p">()</span><span class="o">-></span><span class="n">removeAdditionalAttribute</span><span class="p">(</span><span class="s">"delta:insertion-type"</span><span class="p">);</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">879</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">}</span> <span class="k">else</span> <span class="k">if</span> <span class="p">(</span><span class="n">textAnchor</span> <span class="o">&&</span> <span class="n">changeId</span> <span class="o">&&</span> <span class="n">changeTracker</span><span class="o">-></span><span class="n">elementById</span><span class="p">(</span><span class="n">changeId</span><span class="p">)</span><span class="o">-></span><span class="n">getChangeType</span><span class="p">()</span> <span class="o">==</span> <span class="n">KoGenChange</span><span class="o">::</span><span class="n">DeleteChange</span><span class="p">)</span> <span class="p">{</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">880</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">writer</span><span class="o">-></span><span class="n">endElement</span><span class="p">();</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">881</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">}</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">882</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">}</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is that a change belonging to this work?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not really but once the change tracking branch is removing changetracking code, this will make it much easier to merge - and this code has never been called since before 2.4</pre>
<br />
<p>- C.</p>
<br />
<p>On January 23rd, 2013, 9:35 a.m. UTC, C. Boemann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Thorsten Zachmann.</div>
<div>By C. Boemann.</div>
<p style="color: grey;"><i>Updated Jan. 23, 2013, 9:35 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> Change KoTextAnchor into two new classes
KoShapeANchor - which in theory should be moved to flake later
KoAnchorInlineObject - which is the kotext part responsible for being an inline object
No realy user visible changes coming out of this but it's nessesary ground work for the next step
I have had to disable several commands so we loos that functionality
This will be reenabled with the following commits which adds a third class
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've create two small documents and they load fine.
I'd like Thorsten to run cstester on this to be sure
This review is not for final approval - as i need a second step, but it's a nice logical point to do a review
In several commands i've disabled some stuff because it would be a vaste of time to fix it only to break it again with part2.
But loading and saving and display should be just as good as before, and the code so far should make sense - so please review that</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/kotext/CMakeLists.txt <span style="color: grey">(8b358ec)</span></li>
<li>libs/kotext/KoAnchorInlineObject.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kotext/KoAnchorInlineObject.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kotext/KoAnchorTextRange.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kotext/KoAnchorTextRange.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kotext/KoShapeAnchor.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kotext/KoShapeAnchor.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kotext/KoTextAnchor.h <span style="color: grey">(4ec3f03)</span></li>
<li>libs/kotext/KoTextAnchor.cpp <span style="color: grey">(1f2e8c5)</span></li>
<li>libs/kotext/KoTextEditor.h <span style="color: grey">(10c59a6)</span></li>
<li>libs/kotext/KoTextEditor.cpp <span style="color: grey">(1929e07)</span></li>
<li>libs/kotext/KoTextRange.h <span style="color: grey">(78515d9)</span></li>
<li>libs/kotext/KoTextRange.cpp <span style="color: grey">(61cbfa2)</span></li>
<li>libs/kotext/commands/ChangeAnchorPropertiesCommand.h <span style="color: grey">(f1448ad)</span></li>
<li>libs/kotext/commands/ChangeAnchorPropertiesCommand.cpp <span style="color: grey">(50e9f55)</span></li>
<li>libs/kotext/commands/ChangeTrackedDeleteCommand.cpp <span style="color: grey">(966d990)</span></li>
<li>libs/kotext/commands/DeleteAnchorsCommand.h <span style="color: grey">(d98b858)</span></li>
<li>libs/kotext/commands/DeleteAnchorsCommand.cpp <span style="color: grey">(d32f5f1)</span></li>
<li>libs/kotext/commands/DeleteCommand.h <span style="color: grey">(a0004a6)</span></li>
<li>libs/kotext/commands/DeleteCommand.cpp <span style="color: grey">(5d39f4f7)</span></li>
<li>libs/kotext/opendocument/KoTextLoader.cpp <span style="color: grey">(29165e1)</span></li>
<li>libs/kotext/opendocument/KoTextSharedLoadingData.h <span style="color: grey">(b247992)</span></li>
<li>libs/kotext/opendocument/KoTextSharedLoadingData.cpp <span style="color: grey">(ff609d1)</span></li>
<li>libs/kotext/opendocument/KoTextWriter_p.h <span style="color: grey">(f3466e1)</span></li>
<li>libs/kotext/opendocument/KoTextWriter_p.cpp <span style="color: grey">(39cf629)</span></li>
<li>libs/textlayout/AnchorStrategy.h <span style="color: grey">(f0853f1)</span></li>
<li>libs/textlayout/AnchorStrategy.cpp <span style="color: grey">(a7dbec1)</span></li>
<li>libs/textlayout/FloatingAnchorStrategy.h <span style="color: grey">(090efea)</span></li>
<li>libs/textlayout/FloatingAnchorStrategy.cpp <span style="color: grey">(1364df1)</span></li>
<li>libs/textlayout/InlineAnchorStrategy.h <span style="color: grey">(24d3051)</span></li>
<li>libs/textlayout/InlineAnchorStrategy.cpp <span style="color: grey">(c21f62b)</span></li>
<li>libs/textlayout/KoTextDocumentLayout.h <span style="color: grey">(ef7c197)</span></li>
<li>libs/textlayout/KoTextDocumentLayout.cpp <span style="color: grey">(dcb4c8a)</span></li>
<li>libs/textlayout/KoTextLayoutArea.cpp <span style="color: grey">(4f96f19)</span></li>
<li>libs/textlayout/KoTextShapeContainerModel.h <span style="color: grey">(93b8a4d)</span></li>
<li>libs/textlayout/KoTextShapeContainerModel.cpp <span style="color: grey">(f19efa5)</span></li>
<li>libs/textlayout/KoTextShapeData.cpp <span style="color: grey">(9d096ef)</span></li>
<li>plugins/textshape/commands/ShowChangesCommand.cpp <span style="color: grey">(a486c113)</span></li>
<li>words/part/KWDocument.h <span style="color: grey">(dc64e5e)</span></li>
<li>words/part/KWDocument.cpp <span style="color: grey">(67f808d)</span></li>
<li>words/part/KWOdfSharedLoadingData.h <span style="color: grey">(7893cb9)</span></li>
<li>words/part/KWOdfSharedLoadingData.cpp <span style="color: grey">(58f533b)</span></li>
<li>words/part/KWOdfWriter.cpp <span style="color: grey">(c9c72f7)</span></li>
<li>words/part/KWRootAreaProvider.cpp <span style="color: grey">(9a86d5d)</span></li>
<li>words/part/KWView.h <span style="color: grey">(e86cc5c)</span></li>
<li>words/part/KWView.cpp <span style="color: grey">(c9405df)</span></li>
<li>words/part/commands/KWShapeCreateCommand.h <span style="color: grey">(a6e2852)</span></li>
<li>words/part/commands/KWShapeCreateCommand.cpp <span style="color: grey">(4781c390)</span></li>
<li>words/part/dialogs/KWAnchoringProperties.h <span style="color: grey">(14ac2d4)</span></li>
<li>words/part/dialogs/KWAnchoringProperties.cpp <span style="color: grey">(fe97a23)</span></li>
<li>words/part/frames/KWFrame.h <span style="color: grey">(757c4ec)</span></li>
<li>words/part/frames/KWFrame.cpp <span style="color: grey">(e30e8f0)</span></li>
<li>words/part/frames/KWFrameLayout.cpp <span style="color: grey">(5ad85ed)</span></li>
<li>words/part/frames/KWTextFrameSet.cpp <span style="color: grey">(1088541)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108459/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>