<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108569/">http://git.reviewboard.kde.org/r/108569/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 24th, 2013, 9:13 a.m. UTC, <b>C. Boemann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In general good quality, but some issues were identified
I also think we can retire the stroke/fill docker. The fillconfig and strokeconfig widgets handle those things now.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">For that, we need a sort of the backround tool combined with the slide design docker you are working on.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 24th, 2013, 9:13 a.m. UTC, <b>C. Boemann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108569/diff/1/?file=109044#file109044line146" style="color: black; font-weight: bold; text-decoration: underline;">libs/widgets/KoResourcePopupAction.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">146</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QSize</span> <span class="n">iconSize</span><span class="p">(</span><span class="mi">16</span><span class="p">,</span><span class="mi">16</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">how about making this as wide as the widget</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't find a way to change the icon size. No setIconSize.
It's the same problem in the color action popup.</pre>
<br />
<p>- Jean-Nicolas</p>
<br />
<p>On January 23rd, 2013, 10:25 p.m. UTC, Jean-Nicolas Artaud wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Jean-Nicolas Artaud.</div>
<p style="color: grey;"><i>Updated Jan. 23, 2013, 10:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch totally changes the design of the tools config widget use. This new way of doing had been discussed with several people (boemann and a UI designer worked 8 hours at the aKademy, and this part is one of the main thing to do. The manipulation of shapes on pages and slides is way easier now. The good widgets appear to you when you select a tool, and you know directly have what you need and want to manipulate the shapes!
- If you select a tool, it will open the config widgets associated.
- As you can see on the screenshots, all the tools needs their own widgets.
- Stroke, Fill and Shadow config widgets are the main one.
- A same config widget can be used with several tools.
- Snap Settings had been removed from config widgets and added as a Docker -- the opposite way that the StrokeDocker for instance.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested in the flake-configwidgets-boemann branch, on words and stage, with several documents, and different kind of shapes.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>karbon/plugins/tools/CalligraphyTool/KarbonCalligraphyOptionWidget.h <span style="color: grey">(1c07423)</span></li>
<li>karbon/plugins/tools/CalligraphyTool/KarbonCalligraphyTool.h <span style="color: grey">(7de7a14)</span></li>
<li>karbon/plugins/tools/CalligraphyTool/KarbonCalligraphyTool.cpp <span style="color: grey">(4833d86)</span></li>
<li>krita/CMakeLists.txt <span style="color: grey">(835f90d)</span></li>
<li>libs/basicflakes/CMakeLists.txt <span style="color: grey">(de004d7)</span></li>
<li>libs/basicflakes/tools/KoCreatePathTool.cpp <span style="color: grey">(043ec2e)</span></li>
<li>libs/basicflakes/tools/KoPencilTool.h <span style="color: grey">(85172bf)</span></li>
<li>libs/basicflakes/tools/KoPencilTool.cpp <span style="color: grey">(a56b988)</span></li>
<li>libs/flake/tools/KoPathTool.cpp <span style="color: grey">(9dd8caf)</span></li>
<li>libs/main/KoModeBox.cpp <span style="color: grey">(1c81fa2)</span></li>
<li>libs/textlayout/KoTextLayoutRootAreaProvider.cpp <span style="color: grey">(f21b5c4)</span></li>
<li>libs/widgets/CMakeLists.txt <span style="color: grey">(10e4e09)</span></li>
<li>libs/widgets/KoFillConfigWidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/widgets/KoFillConfigWidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/widgets/KoResourcePopupAction.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/widgets/KoResourcePopupAction.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/widgets/KoShadowConfigWidget.h <span style="color: grey">(332e97a)</span></li>
<li>libs/widgets/KoShadowConfigWidget.cpp <span style="color: grey">(e9e9502)</span></li>
<li>libs/widgets/KoShadowConfigWidget.ui <span style="color: grey">(4378813)</span></li>
<li>libs/widgets/KoStrokeConfigWidget.h <span style="color: grey">(559c65f)</span></li>
<li>libs/widgets/KoStrokeConfigWidget.cpp <span style="color: grey">(d0a8eb9)</span></li>
<li>plugins/defaultTools/connectionTool/ConnectionTool.cpp <span style="color: grey">(eec40fc)</span></li>
<li>plugins/defaultTools/defaulttool/DefaultTool.cpp <span style="color: grey">(db7c489)</span></li>
<li>plugins/dockers/CMakeLists.txt <span style="color: grey">(ddb4695)</span></li>
<li>plugins/dockers/Plugin.cpp <span style="color: grey">(09394f9)</span></li>
<li>plugins/dockers/shadowdocker/ShadowDocker.h <span style="color: grey">(a26b2b4)</span></li>
<li>plugins/dockers/shadowdocker/ShadowDocker.cpp <span style="color: grey">(010673d)</span></li>
<li>plugins/dockers/strokedocker/StrokeDocker.h <span style="color: grey">(776a675)</span></li>
<li>plugins/dockers/strokedocker/StrokeDocker.cpp <span style="color: grey">(991756e)</span></li>
<li>plugins/dockers/strokedocker/StrokeDockerFactory.h <span style="color: grey">(d8ef237)</span></li>
<li>plugins/dockers/strokedocker/StrokeDockerFactory.cpp <span style="color: grey">(d761851)</span></li>
<li>plugins/dockers/strokedocker/pics/CMakeLists.txt <span style="color: grey">(f3e737e)</span></li>
<li>plugins/dockers/strokedocker/pics/hi16-action-cap_butt.png <span style="color: grey">(6c8dbad)</span></li>
<li>plugins/dockers/strokedocker/pics/hi16-action-cap_round.png <span style="color: grey">(72423c0)</span></li>
<li>plugins/dockers/strokedocker/pics/hi16-action-cap_square.png <span style="color: grey">(e2204ae)</span></li>
<li>plugins/dockers/strokedocker/pics/hi16-action-join_bevel.png <span style="color: grey">(8ddfb27)</span></li>
<li>plugins/dockers/strokedocker/pics/hi16-action-join_miter.png <span style="color: grey">(b6dfa00)</span></li>
<li>plugins/dockers/strokedocker/pics/hi16-action-join_round.png <span style="color: grey">(756db8c)</span></li>
<li>plugins/dockers/styledocker/StrokeFillWidget.h <span style="color: grey">(b6b5b73)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108569/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/23/DefaultTools.jpg">Default Tools config widgets</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/23/NewDockersList.jpg">New docker list</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/23/PathDrawingTool.jpg">Freehand path drawing tool config widgets</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/23/SnapSettings.jpg">Snap Settings Docker</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>