<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108491/">http://git.reviewboard.kde.org/r/108491/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 20th, 2013, 4:07 a.m. UTC, <b>C. Boemann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">looks very good, except could you please move the command to kotext/commands instead</pre>
</blockquote>
<p>On January 20th, 2013, 5:24 a.m. UTC, <b>Gopalakrishna Bhat</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The reason it is there is because of translation requirement for 2.6. In kotext this will be a new string breaking string freeze.
I'm ok with doing the move to kotext if you do not want this to go into 2.6</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just break string freeze, it's more important to have this crash fixed (the right way) than having some untranslated strings. The translations will probably catch up with 2.6.1 anyway
</pre>
<br />
<p>- C.</p>
<br />
<p>On January 19th, 2013, 4:40 p.m. UTC, Gopalakrishna Bhat wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and C. Boemann.</div>
<div>By Gopalakrishna Bhat.</div>
<p style="color: grey;"><i>Updated Jan. 19, 2013, 4:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Implements Undo/Redo of paragraph settings as a command in the process fixing bug 312318.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=312318">312318</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/kotext/KoTextEditor.h <span style="color: grey">(5c78240)</span></li>
<li>libs/kotext/KoTextEditor.cpp <span style="color: grey">(414b5dc)</span></li>
<li>libs/kotext/commands/ChangeListCommand.cpp <span style="color: grey">(d036d6e)</span></li>
<li>plugins/textshape/CMakeLists.txt <span style="color: grey">(1126de0)</span></li>
<li>plugins/textshape/commands/ParagraphSettingsCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/commands/ParagraphSettingsCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/ParagraphSettingsDialog.cpp <span style="color: grey">(4bd7a2c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108491/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>