<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108420/">http://git.reviewboard.kde.org/r/108420/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 18th, 2013, 3:07 p.m. UTC, <b>Dmitry Kazakov</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108420/diff/1/?file=107345#file107345line276" style="color: black; font-weight: bold; text-decoration: underline;">libs/widgets/KoZoomController.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KoZoomController::setZoom(KoZoomMode::Mode mode, qreal zoom, qreal resolutionX, qreal resolutionY, const QPointF &stillPoint)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">276</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">// now that we have the final offset, let's emit some signals</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">277</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">d</span><span class="o">-></span><span class="n">canvasController</span><span class="o">-></span><span class="n">proxyObject</span><span class="o">-></span><span class="n">emitCanvasOffsetXChanged</span><span class="p">(</span><span class="n">d</span><span class="o">-></span><span class="n">canvasController</span><span class="o">-></span><span class="n">canvasOffsetX</span><span class="p">());</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">278</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">d</span><span class="o">-></span><span class="n">canvasController</span><span class="o">-></span><span class="n">proxyObject</span><span class="o">-></span><span class="n">emitCanvasOffsetYChanged</span><span class="p">(</span><span class="n">d</span><span class="o">-></span><span class="n">canvasController</span><span class="o">-></span><span class="n">canvasOffsetY</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have such a feeling that this explicit signal emission can be removed, because all the code paths above end up with recenterPreferred() or setPreferredCenter(), which should emit the signals as well. So we probably get duplicated signals here.
Could you check whether it works without these lines?
The rest is ok to commit.
</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yes it works just as well without - so removing them - not uploading new diff - cna i get a ship it then?</pre>
<br />
<p>- C.</p>
<br />
<p>On January 15th, 2013, 5:04 a.m. UTC, C. Boemann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Inge Wallin.</div>
<div>By C. Boemann.</div>
<p style="color: grey;"><i>Updated Jan. 15, 2013, 5:04 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> Introduce a "Fit Text Width" zoom mode
This also changes how the other "fit" modes work: We now zoom in to the fit the
max pagesize of the currently shown pages. Previously we zoomed in to the max
pagesize of the entire document.
The page counter in the lower left of Words' window now show the scroll position
and not the cursorposition. Previously it was a weird mix
The page counter also now shows ranges so that if pages 3,4,5 are shown, the counter
says "3-5 of 47"
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">only in words, and since it touches libs too I'd like some feedback</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/widgets/KoZoomAction.cpp <span style="color: grey">(589b4c7)</span></li>
<li>libs/widgets/KoZoomController.h <span style="color: grey">(864abb4)</span></li>
<li>libs/widgets/KoZoomController.cpp <span style="color: grey">(7cb6f06)</span></li>
<li>libs/widgets/KoZoomMode.h <span style="color: grey">(cfaeed8)</span></li>
<li>libs/widgets/KoZoomMode.cpp <span style="color: grey">(81ffdf4)</span></li>
<li>words/part/KWStatusBar.cpp <span style="color: grey">(f3de247)</span></li>
<li>words/part/KWView.h <span style="color: grey">(253b8021)</span></li>
<li>words/part/KWView.cpp <span style="color: grey">(988dba4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108420/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>