<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108459/">http://git.reviewboard.kde.org/r/108459/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Thorsten Zachmann.</div>
<div>By C. Boemann.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> Change KoTextAnchor into two new classes
KoShapeANchor - which in theory should be moved to flake later
KoAnchorInlineObject - which is the kotext part responsible for being an inline object
No realy user visible changes coming out of this but it's nessesary ground work for the next step
I have had to disable several commands so we loos that functionality
This will be reenabled with the following commits which adds a third class
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've create two small documents and they load fine.
I'd like Thorsten to run cstester on this to be sure
This review is not for final approval - as i need a second step, but it's a nice logical point to do a review
In several commands i've disabled some stuff because it would be a vaste of time to fix it only to break it again with part2.
But loading and saving and display should be just as good as before, and the code so far should make sense - so please review that</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/kotext/CMakeLists.txt <span style="color: grey">(d465769)</span></li>
<li>libs/kotext/KoAnchorInlineObject.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kotext/KoAnchorInlineObject.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kotext/KoShapeAnchor.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kotext/KoShapeAnchor.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kotext/KoTextAnchor.h <span style="color: grey">(e2dd89d)</span></li>
<li>libs/kotext/KoTextAnchor.cpp <span style="color: grey">(1f2e8c5)</span></li>
<li>libs/kotext/KoTextEditor.h <span style="color: grey">(ad97dcd)</span></li>
<li>libs/kotext/KoTextEditor.cpp <span style="color: grey">(414b5dc)</span></li>
<li>libs/kotext/commands/ChangeAnchorPropertiesCommand.h <span style="color: grey">(f1448ad)</span></li>
<li>libs/kotext/commands/ChangeAnchorPropertiesCommand.cpp <span style="color: grey">(50e9f55)</span></li>
<li>libs/kotext/commands/ChangeTrackedDeleteCommand.cpp <span style="color: grey">(966d990)</span></li>
<li>libs/kotext/commands/DeleteAnchorsCommand.h <span style="color: grey">(d98b858)</span></li>
<li>libs/kotext/commands/DeleteAnchorsCommand.cpp <span style="color: grey">(4d4cbcf)</span></li>
<li>libs/kotext/commands/DeleteCommand.h <span style="color: grey">(a0004a6)</span></li>
<li>libs/kotext/commands/DeleteCommand.cpp <span style="color: grey">(5d39f4f7)</span></li>
<li>libs/kotext/opendocument/KoTextLoader.cpp <span style="color: grey">(d024996)</span></li>
<li>libs/kotext/opendocument/KoTextSharedLoadingData.h <span style="color: grey">(b247992)</span></li>
<li>libs/kotext/opendocument/KoTextSharedLoadingData.cpp <span style="color: grey">(ff609d1)</span></li>
<li>libs/kotext/opendocument/KoTextWriter_p.h <span style="color: grey">(f3466e1)</span></li>
<li>libs/kotext/opendocument/KoTextWriter_p.cpp <span style="color: grey">(39cf629)</span></li>
<li>libs/textlayout/AnchorStrategy.h <span style="color: grey">(f0853f1)</span></li>
<li>libs/textlayout/AnchorStrategy.cpp <span style="color: grey">(a7dbec1)</span></li>
<li>libs/textlayout/FloatingAnchorStrategy.h <span style="color: grey">(090efea)</span></li>
<li>libs/textlayout/FloatingAnchorStrategy.cpp <span style="color: grey">(1364df1)</span></li>
<li>libs/textlayout/InlineAnchorStrategy.h <span style="color: grey">(24d3051)</span></li>
<li>libs/textlayout/InlineAnchorStrategy.cpp <span style="color: grey">(c21f62b)</span></li>
<li>libs/textlayout/KoTextDocumentLayout.h <span style="color: grey">(b954dd2)</span></li>
<li>libs/textlayout/KoTextDocumentLayout.cpp <span style="color: grey">(15548d7)</span></li>
<li>libs/textlayout/KoTextShapeContainerModel.h <span style="color: grey">(93b8a4d)</span></li>
<li>libs/textlayout/KoTextShapeContainerModel.cpp <span style="color: grey">(f19efa5)</span></li>
<li>libs/textlayout/KoTextShapeData.cpp <span style="color: grey">(9d096ef)</span></li>
<li>plugins/textshape/commands/ShowChangesCommand.cpp <span style="color: grey">(a486c113)</span></li>
<li>words/part/KWDocument.h <span style="color: grey">(dc64e5e)</span></li>
<li>words/part/KWDocument.cpp <span style="color: grey">(67f808d)</span></li>
<li>words/part/KWOdfSharedLoadingData.h <span style="color: grey">(7893cb9)</span></li>
<li>words/part/KWOdfSharedLoadingData.cpp <span style="color: grey">(58f533b)</span></li>
<li>words/part/KWOdfWriter.cpp <span style="color: grey">(c9c72f7)</span></li>
<li>words/part/KWRootAreaProvider.cpp <span style="color: grey">(9a86d5d)</span></li>
<li>words/part/KWView.h <span style="color: grey">(1c4fd59)</span></li>
<li>words/part/KWView.cpp <span style="color: grey">(55651f9)</span></li>
<li>words/part/commands/KWShapeCreateCommand.h <span style="color: grey">(a6e2852)</span></li>
<li>words/part/commands/KWShapeCreateCommand.cpp <span style="color: grey">(4781c390)</span></li>
<li>words/part/dialogs/KWAnchoringProperties.h <span style="color: grey">(14ac2d4)</span></li>
<li>words/part/dialogs/KWAnchoringProperties.cpp <span style="color: grey">(fe97a23)</span></li>
<li>words/part/frames/KWFrame.h <span style="color: grey">(757c4ec)</span></li>
<li>words/part/frames/KWFrame.cpp <span style="color: grey">(e30e8f0)</span></li>
<li>words/part/frames/KWFrameLayout.cpp <span style="color: grey">(5ad85ed)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108459/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>