<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108353/">http://git.reviewboard.kde.org/r/108353/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The patch works for me to fix the bug as reported, so ship it, thanks.
But... it opened the path to the next crash:
selecting the char tab like in the bug reported, and then clicking the "New" button yields another crash, reported as https://bugs.kde.org/show_bug.cgi?id=313233
</pre>
<br />
<p>- Friedrich W. H.</p>
<br />
<p>On January 11th, 2013, 7:08 p.m. UTC, Pierre Stirnweiss wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, C. Boemann and Friedrich W. H. Kossebau.</div>
<div>By Pierre Stirnweiss.</div>
<p style="color: grey;"><i>Updated Jan. 11, 2013, 7:08 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">On an empty style list, the style manager dialog would pass around null styles (for preview,...). Add some test for null styles in some places solves the crash. I will work on a new dialog in the very near future, so even if the solution is not ideal (a big blank tab), it is the best we can do for 2.6.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=313031">313031</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/textshape/dialogs/FormattingPreview.cpp <span style="color: grey">(1ed3b83)</span></li>
<li>plugins/textshape/dialogs/StyleManager.cpp <span style="color: grey">(c561d35)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108353/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>