<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108220/">http://git.reviewboard.kde.org/r/108220/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 68355b7573b735c1731e041c1fb2481e82afeff9 by Friedrich W. H. Kossebau to branch calligra/2.6.</pre>
<br />
<p>- Commit</p>
<br />
<p>On January 6th, 2013, 4:03 a.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Yue Liu.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Jan. 6, 2013, 4:03 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KoPAView::initActions() is adding actions for selecting the "Master Page..." and setting the "Page Layout...", but they do not make it into the menu of Calligra Flow, because the flow.rc misses to have the proper entries "format_masterpage" and "format_pagelayout" (and these are also not part of "ui_standards.rc").
Attached patch adds a menu "Format" with the two entries, for consistency like Stage has (though Stage adds own menu entries as well).
Okay to also backport to 2.6?
There is one flaw, but that also exist with Stage now: switching to another format does not trigger a repaint. Has to be fixed separately.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>flow/part/flow.rc <span style="color: grey">(3e90a63)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108220/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>