<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108317/">http://git.reviewboard.kde.org/r/108317/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">So, global ship it?</pre>
<br />
<p>- Inge</p>
<br />
<p>On January 10th, 2013, 6:41 a.m., Inge Wallin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Inge Wallin.</div>
<p style="color: grey;"><i>Updated Jan. 10, 2013, 6:41 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds a final newline to some source files that don't have them. This is one of the issues that are flagged in the code checker at http://englishbreakfastnetwork.org/krazy/index.php?component=bundled-apps&module=calligra.
In all of Calligra there are lots of small issues like this, though this particular type is especially trivial. So I wrote a utility tools/fixsrc.py that is intended to find and fix things that are just too trivial to do manually.
But how shall we handle it? I applied the script in a place that I thought would not be very controversial: the filters. But how to continue? I can see several choices we need to make:
- Leave some of the issues be? In that case we should disable the check in EBN.
- Apply them to all the sources in one big swoop? Or per module?
- Backport or not? I would prefer to apply the same type of patch in at least master and 2.6 to maximize the backportability of other patches.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/words/msword-odf/wv2/src/olestream.cpp <span style="color: grey">(c778962)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/AbstractRtfOutput.h <span style="color: grey">(00ba298)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/AuthorPcdataDestination.h <span style="color: grey">(855367b)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/AuthorPcdataDestination.cpp <span style="color: grey">(edfad34)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/CategoryPcdataDestination.h <span style="color: grey">(45f233f)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/CategoryPcdataDestination.cpp <span style="color: grey">(ca4444f)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/ColorTableDestination.h <span style="color: grey">(01d7abf)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/CommentPcdataDestination.h <span style="color: grey">(683220f)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/CommentPcdataDestination.cpp <span style="color: grey">(3db8c61)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/CompanyPcdataDestination.h <span style="color: grey">(dc59149)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/CompanyPcdataDestination.cpp <span style="color: grey">(67fdaef)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/Destination.cpp <span style="color: grey">(faa3aa2)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/DocumentCommentPcdataDestination.h <span style="color: grey">(fdbc7e0)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/DocumentCommentPcdataDestination.cpp <span style="color: grey">(993cd42)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/DocumentDestination.cpp <span style="color: grey">(3b278b3)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/FontTableDestination.cpp <span style="color: grey">(2fda530)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/GeneratorPcdataDestination.h <span style="color: grey">(87a7373)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/GeneratorPcdataDestination.cpp <span style="color: grey">(d51cc1c)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/HLinkBasePcdataDestination.h <span style="color: grey">(f391cbd)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/HLinkBasePcdataDestination.cpp <span style="color: grey">(26a0646)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/IgnoredDestination.cpp <span style="color: grey">(d273880)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/InfoCreatedTimeDestination.h <span style="color: grey">(3134ef9)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/InfoCreatedTimeDestination.cpp <span style="color: grey">(9f0dbb0)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/InfoDestination.h <span style="color: grey">(518fbbd)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/InfoPrintedTimeDestination.h <span style="color: grey">(3c835f4)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/InfoPrintedTimeDestination.cpp <span style="color: grey">(3fb1b8f)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/InfoRevisedTimeDestination.h <span style="color: grey">(106cb37)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/InfoRevisedTimeDestination.cpp <span style="color: grey">(62fbf7c)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/InfoTimeDestination.h <span style="color: grey">(03fb8cb)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/InfoTimeDestination.cpp <span style="color: grey">(3f5e27c)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/KeywordsPcdataDestination.h <span style="color: grey">(41ac5b3)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/KeywordsPcdataDestination.cpp <span style="color: grey">(e843d9a)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/ManagerPcdataDestination.h <span style="color: grey">(0431a5f)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/ManagerPcdataDestination.cpp <span style="color: grey">(b16f474)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/OperatorPcdataDestination.h <span style="color: grey">(7c7b074)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/OperatorPcdataDestination.cpp <span style="color: grey">(510db79)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/PcdataDestination.h <span style="color: grey">(edd0e89)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/PcdataDestination.cpp <span style="color: grey">(b266aec)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/StyleSheetDestination.cpp <span style="color: grey">(a5d4f86)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/SubjectPcdataDestination.h <span style="color: grey">(508625a)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/SubjectPcdataDestination.cpp <span style="color: grey">(bdb51a0)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/TextDocumentRtfOutput.h <span style="color: grey">(5184ae8)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/TitlePcdataDestination.h <span style="color: grey">(d80c751)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/TitlePcdataDestination.cpp <span style="color: grey">(15abb42)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/Token.cpp <span style="color: grey">(84a5b0a)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/Tokenizer.h <span style="color: grey">(27a59bd)</span></li>
<li>filters/words/rtf/import/rtf-qt/src/UserPropsDestination.h <span style="color: grey">(846459a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108317/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>