<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108326/">http://git.reviewboard.kde.org/r/108326/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i like it but will not approve just yet</pre>
<br />
<p>- C.</p>
<br />
<p>On January 10th, 2013, 3:50 p.m., Boudewijn Rempt wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Boudewijn Rempt.</div>
<p style="color: grey;"><i>Updated Jan. 10, 2013, 3:50 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch updates the MinVersion and PluginVersion of all Calligra plugins (except for Sheets function plugins and Kexi plugins) to 27 (to reflect that current master will become 2.7). It changes the loading of plugins from <= MinVersion to == PluginVersion since we cannot reliably load any plugin that wasn't built against the current version.
The pigment plugins now no longer have an X-Flake-PluginVerson property, but X-Pigment-PLuginVersion.
I did some testing, but this patch needs careful considering since any error means that a plugin won't get loaded.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>active/calligraactive.desktop <span style="color: grey">(444dffe)</span></li>
<li>braindump/plugins/quickstates/braindumpquickstates.desktop <span style="color: grey">(dec7df8)</span></li>
<li>braindump/plugins/stateshape/stateshape.desktop <span style="color: grey">(cac621e)</span></li>
<li>braindump/plugins/webshape/webshape.desktop <span style="color: grey">(9141cd1)</span></li>
<li>braindump/src/View.cpp <span style="color: grey">(4247649)</span></li>
<li>flow/plugins/dockers/flowdockersplugin.desktop <span style="color: grey">(463bfb0)</span></li>
<li>karbon/plugins/dockers/karbondockersplugin.desktop <span style="color: grey">(e203c65)</span></li>
<li>karbon/plugins/filtereffects/karbonfiltereffects.desktop <span style="color: grey">(b12f1e3)</span></li>
<li>karbon/plugins/tools/karbontools.desktop <span style="color: grey">(44ad7dd)</span></li>
<li>kexi/plugins/shapes/relationdesign/kexirelationdesignshape.desktop <span style="color: grey">(64dfd2c)</span></li>
<li>krita/data/templates/comics/BD-EuroTemplate.desktop <span style="color: grey">(4737fc3)</span></li>
<li>krita/data/templates/comics/Comics-USTemplate.desktop <span style="color: grey">(9412894)</span></li>
<li>krita/data/templates/comics/Manga-JpTemplate.desktop <span style="color: grey">(a69be2a)</span></li>
<li>krita/data/templates/comics/a4_waffle_grid.desktop <span style="color: grey">(427efa5)</span></li>
<li>krita/image/brushengine/kis_paintop_registry.cc <span style="color: grey">(63b971c)</span></li>
<li>krita/image/filter/kis_filter_registry.cc <span style="color: grey">(85ad15b)</span></li>
<li>krita/image/generator/kis_generator_registry.cpp <span style="color: grey">(f4faa28)</span></li>
<li>krita/krita.desktop <span style="color: grey">(90ef6e4)</span></li>
<li>krita/kritapart.desktop <span style="color: grey">(c58f58f)</span></li>
<li>krita/plugins/assistants/RulerAssistant/kritarulerassistanttool.desktop <span style="color: grey">(7a911f6)</span></li>
<li>krita/plugins/colorspaces/extensions/krita_colorspaces_extensions_plugin.desktop <span style="color: grey">(1e0ebc9)</span></li>
<li>krita/plugins/extensions/bigbrother/kritabigbrother.desktop <span style="color: grey">(f9aca4c)</span></li>
<li>krita/plugins/extensions/colorrange/kritacolorrange.desktop <span style="color: grey">(747f819)</span></li>
<li>krita/plugins/extensions/colorspaceconversion/kritacolorspaceconversion.desktop <span style="color: grey">(642c1a8)</span></li>
<li>krita/plugins/extensions/compose/kritalayercompose.desktop <span style="color: grey">(c137c78)</span></li>
<li>krita/plugins/extensions/dockers/advancedcolorselector/krita_colorselectorng.desktop <span style="color: grey">(80433bb)</span></li>
<li>krita/plugins/extensions/dockers/artisticcolorselector/krita_artisticcolorselector.desktop <span style="color: grey">(471c747)</span></li>
<li>krita/plugins/extensions/dockers/channeldocker/krita_channeldocker.desktop <span style="color: grey">(939b430)</span></li>
<li>krita/plugins/extensions/dockers/compositiondocker/krita_compositiondocker.desktop <span style="color: grey">(d7dd014)</span></li>
<li>krita/plugins/extensions/dockers/defaultdockers/kritadefaultdockers.desktop <span style="color: grey">(1367cac)</span></li>
<li>krita/plugins/extensions/dockers/digitalmixer/krita_digitalmixer.desktop <span style="color: grey">(b5ae83b)</span></li>
<li>krita/plugins/extensions/dockers/dockerplugintemplate/krita_presetdocker.desktop <span style="color: grey">(9ba17ee)</span></li>
<li>krita/plugins/extensions/dockers/flipbook/krita_flipbookdocker.desktop <span style="color: grey">(342abef)</span></li>
<li>krita/plugins/extensions/dockers/historydocker/kritahistorydocker.desktop <span style="color: grey">(90c1f45)</span></li>
<li>krita/plugins/extensions/dockers/imagedocker/kritaimagedocker.desktop <span style="color: grey">(fc89643)</span></li>
<li>krita/plugins/extensions/dockers/lut/krita_lutdocker.desktop <span style="color: grey">(f89736a)</span></li>
<li>krita/plugins/extensions/dockers/patterndocker/krita_patterndocker.desktop <span style="color: grey">(881e3ed)</span></li>
<li>krita/plugins/extensions/dockers/presetdocker/krita_presetdocker.desktop <span style="color: grey">(9ba17ee)</span></li>
<li>krita/plugins/extensions/dockers/smallcolorselector/krita_smallcolorselector.desktop <span style="color: grey">(300e1fa)</span></li>
<li>krita/plugins/extensions/dockers/specificcolorselector/krita_specificcolorselector.desktop <span style="color: grey">(70f2be2)</span></li>
<li>krita/plugins/extensions/dockers/tasksetdocker/krita_tasksetdocker.desktop <span style="color: grey">(e6b7866)</span></li>
<li>krita/plugins/extensions/dropshadow/kritadropshadow.desktop <span style="color: grey">(b58633a)</span></li>
<li>krita/plugins/extensions/histogram/kritahistogram.desktop <span style="color: grey">(4f54481)</span></li>
<li>krita/plugins/extensions/imagesize/kritaimagesize.desktop <span style="color: grey">(9cc9a55)</span></li>
<li>krita/plugins/extensions/imagesplit/kritaimagesplit.desktop <span style="color: grey">(33b3d56)</span></li>
<li>krita/plugins/extensions/metadataeditor/kritametadataeditor.desktop <span style="color: grey">(df35d24)</span></li>
<li>krita/plugins/extensions/modify_selection/kritamodifyselection.desktop <span style="color: grey">(36c6ddf)</span></li>
<li>krita/plugins/extensions/rotateimage/kritarotateimage.desktop <span style="color: grey">(fd5d8fb)</span></li>
<li>krita/plugins/extensions/separate_channels/kritaseparatechannels.desktop <span style="color: grey">(5c70b6d)</span></li>
<li>krita/plugins/extensions/shearimage/kritashearimage.desktop <span style="color: grey">(8053eed)</span></li>
<li>krita/plugins/extensions/shiva/kritashivafilters.desktop <span style="color: grey">(114f154)</span></li>
<li>krita/plugins/extensions/shiva/kritashivagenerators.desktop <span style="color: grey">(84a6e14)</span></li>
<li>krita/plugins/filters/blur/kritablurfilter.desktop <span style="color: grey">(027ab2a)</span></li>
<li>krita/plugins/filters/colors/kritaextensioncolorsfilters.desktop <span style="color: grey">(ff8c134)</span></li>
<li>krita/plugins/filters/colorsfilters/kritacolorsfilter.desktop <span style="color: grey">(441ea40)</span></li>
<li>krita/plugins/filters/convolutionfilters/kritaconvolutionfilters.desktop <span style="color: grey">(5f6b910)</span></li>
<li>krita/plugins/filters/dodgeburn/kritadodgeburn.desktop <span style="color: grey">(7e0990c)</span></li>
<li>krita/plugins/filters/embossfilter/kritaembossfilter.desktop <span style="color: grey">(3ad3b28)</span></li>
<li>krita/plugins/filters/example/kritaexample.desktop <span style="color: grey">(1110cce)</span></li>
<li>krita/plugins/filters/fastcolortransfer/kritafastcolortransfer.desktop <span style="color: grey">(a05598b)</span></li>
<li>krita/plugins/filters/imageenhancement/kritaimageenhancement.desktop <span style="color: grey">(cff3555)</span></li>
<li>krita/plugins/filters/levelfilter/kritalevelfilter.desktop <span style="color: grey">(b7ce6b3)</span></li>
<li>krita/plugins/filters/noisefilter/kritanoisefilter.desktop <span style="color: grey">(f456c56)</span></li>
<li>krita/plugins/filters/oilpaintfilter/kritaoilpaintfilter.desktop <span style="color: grey">(370c200)</span></li>
<li>krita/plugins/filters/phongbumpmap/kritaphongbumpmapfilter.desktop <span style="color: grey">(0e054b1)</span></li>
<li>krita/plugins/filters/pixelizefilter/kritapixelizefilter.desktop <span style="color: grey">(f3ef12e)</span></li>
<li>krita/plugins/filters/raindropsfilter/kritaraindropsfilter.desktop <span style="color: grey">(1c481f5)</span></li>
<li>krita/plugins/filters/randompickfilter/kritarandompickfilter.desktop <span style="color: grey">(e52aba9)</span></li>
<li>krita/plugins/filters/roundcorners/kritaroundcornersfilter.desktop <span style="color: grey">(02f84b5)</span></li>
<li>krita/plugins/filters/smalltilesfilter/kritasmalltilesfilter.desktop <span style="color: grey">(f131a97)</span></li>
<li>krita/plugins/filters/sobelfilter/kritasobelfilter.desktop <span style="color: grey">(b8f068f)</span></li>
<li>krita/plugins/filters/unsharp/kritaunsharpfilter.desktop <span style="color: grey">(790778d)</span></li>
<li>krita/plugins/filters/wavefilter/kritawavefilter.desktop <span style="color: grey">(4fb613e)</span></li>
<li>krita/plugins/generators/solid/kritacolorgenerator.desktop <span style="color: grey">(8ca1809)</span></li>
<li>krita/plugins/paintops/chalk/kritachalkpaintop.desktop <span style="color: grey">(a828e36)</span></li>
<li>krita/plugins/paintops/colorsmudge/kritacolorsmudgepaintop.desktop <span style="color: grey">(c308a13)</span></li>
<li>krita/plugins/paintops/curvebrush/kritacurvepaintop.desktop <span style="color: grey">(57d82eb)</span></li>
<li>krita/plugins/paintops/defaultpaintops/kritadefaultpaintops.desktop <span style="color: grey">(4963f6a)</span></li>
<li>krita/plugins/paintops/deform/kritadeformpaintop.desktop <span style="color: grey">(287dfb0)</span></li>
<li>krita/plugins/paintops/dynadraw/kritadynapaintop.desktop <span style="color: grey">(dfa994e)</span></li>
<li>krita/plugins/paintops/experiment/kritaexperimentpaintop.desktop <span style="color: grey">(911f5b5)</span></li>
<li>krita/plugins/paintops/filterop/kritafilterop.desktop <span style="color: grey">(6fb4387)</span></li>
<li>krita/plugins/paintops/gridbrush/kritagridpaintop.desktop <span style="color: grey">(77591af)</span></li>
<li>krita/plugins/paintops/hairy/kritahairypaintop.desktop <span style="color: grey">(7e62394)</span></li>
<li>krita/plugins/paintops/hatching/kritahatchingpaintop.desktop <span style="color: grey">(48b85c1)</span></li>
<li>krita/plugins/paintops/libbrush/kis_brush_registry.cpp <span style="color: grey">(c063140)</span></li>
<li>krita/plugins/paintops/mypaint/kritamypaintpaintop.desktop <span style="color: grey">(7f7dc09)</span></li>
<li>krita/plugins/paintops/particle/kritaparticlepaintop.desktop <span style="color: grey">(e02ee70)</span></li>
<li>krita/plugins/paintops/sketch/kritasketchpaintop.desktop <span style="color: grey">(445efb8)</span></li>
<li>krita/plugins/paintops/spray/kritaspraypaintop.desktop <span style="color: grey">(d1a7a7a)</span></li>
<li>krita/plugins/tools/defaulttools/kritadefaulttools.desktop <span style="color: grey">(858065d)</span></li>
<li>krita/plugins/tools/selectiontools/kritaselectiontools.desktop <span style="color: grey">(b83a9a3)</span></li>
<li>krita/plugins/tools/tool_crop/kritatoolcrop.desktop <span style="color: grey">(0d3bb2c)</span></li>
<li>krita/plugins/tools/tool_dyna/kritatooldyna.desktop <span style="color: grey">(26c701b)</span></li>
<li>krita/plugins/tools/tool_grid/kritatoolgrid.desktop <span style="color: grey">(3acd999)</span></li>
<li>krita/plugins/tools/tool_perspectivegrid/kritatoolperspectivegrid.desktop <span style="color: grey">(2f2a047)</span></li>
<li>krita/plugins/tools/tool_polygon/kritatoolpolygon.desktop <span style="color: grey">(583c1c9)</span></li>
<li>krita/plugins/tools/tool_polyline/kritatoolpolyline.desktop <span style="color: grey">(3675fce)</span></li>
<li>krita/plugins/tools/tool_text/kritatooltext.desktop <span style="color: grey">(b22331d)</span></li>
<li>krita/plugins/tools/tool_transform2/kritatooltransform.desktop <span style="color: grey">(26df4f6)</span></li>
<li>krita/sdk/templates/docker/krita_APPNAMELC.desktop <span style="color: grey">(6175d62)</span></li>
<li>krita/sdk/templates/filter/kritaAPPNAMELC.desktop <span style="color: grey">(1eea95d)</span></li>
<li>krita/sdk/templates/tool/kritatoolAPPNAMELC.desktop <span style="color: grey">(b2db303)</span></li>
<li>krita/sdk/templates/view/kritaAPPNAMELC.desktop <span style="color: grey">(6175d62)</span></li>
<li>krita/ui/kis_factory2.cc <span style="color: grey">(5284f9d)</span></li>
<li>krita/ui/kis_view2.cpp <span style="color: grey">(f735776)</span></li>
<li>libs/basicflakes/plugin/basicflakesplugin.desktop <span style="color: grey">(8b0f232)</span></li>
<li>libs/flake/KoDockRegistry.cpp <span style="color: grey">(117d382)</span></li>
<li>libs/flake/KoEventActionRegistry.cpp <span style="color: grey">(100f701)</span></li>
<li>libs/flake/KoFilterEffectRegistry.cpp <span style="color: grey">(7230ca9)</span></li>
<li>libs/flake/KoInputDeviceHandlerRegistry.cpp <span style="color: grey">(6cfc37b)</span></li>
<li>libs/flake/KoShapeRegistry.cpp <span style="color: grey">(d48c9bb)</span></li>
<li>libs/flake/KoToolRegistry.cpp <span style="color: grey">(0e5ab80)</span></li>
<li>libs/flake/Mainpage.dox <span style="color: grey">(1866c9b)</span></li>
<li>libs/flake/filtereffect.desktop <span style="color: grey">(2aeac48)</span></li>
<li>libs/flake/flakeborder.desktop <span style="color: grey">(9fa6239)</span></li>
<li>libs/kopageapp/tools/backgroundTool/kopabackgroundtool.desktop <span style="color: grey">(0b5c4e1)</span></li>
<li>libs/koplugin/KoPluginLoader.h <span style="color: grey">(83f7265)</span></li>
<li>libs/kotext/KoInlineObjectRegistry.cpp <span style="color: grey">(9e5ebb9)</span></li>
<li>libs/kotext/KoTextEditingRegistry.cpp <span style="color: grey">(477388c)</span></li>
<li>libs/pigment/KoColorSpaceRegistry.cpp <span style="color: grey">(32b4e18)</span></li>
<li>libs/pigment/pigment.desktop <span style="color: grey">(9fa0494)</span></li>
<li>libs/pigment/pigmentextension.desktop <span style="color: grey">(1ad1a30)</span></li>
<li>plan/plugins/scripting/krossmoduleplan.desktop <span style="color: grey">(a880a23)</span></li>
<li>plugins/artistictextshape/artistictextshape.desktop <span style="color: grey">(afcba7a)</span></li>
<li>plugins/chartshape/chartshape.desktop <span style="color: grey">(f17ea48)</span></li>
<li>plugins/colorengines/lcms2/colorspaces/gray_u8/calligragrayaplugin.desktop <span style="color: grey">(aeacdfd)</span></li>
<li>plugins/colorengines/lcms2/kolcmsengine.desktop <span style="color: grey">(49cadf1)</span></li>
<li>plugins/commentshape/commentshape.desktop <span style="color: grey">(5fb7730)</span></li>
<li>plugins/defaultTools/defaulttools.desktop <span style="color: grey">(f9362df)</span></li>
<li>plugins/dockers/calligradockers.desktop <span style="color: grey">(bb581a6)</span></li>
<li>plugins/formulashape/formulashape.desktop <span style="color: grey">(f0a7835)</span></li>
<li>plugins/kexi/spreadsheet/keximigrate_spreadsheet.desktop <span style="color: grey">(4f09ce4)</span></li>
<li>plugins/musicshape/musicshape.desktop <span style="color: grey">(533723f)</span></li>
<li>plugins/pathshapes/pathshapes.desktop <span style="color: grey">(8735466)</span></li>
<li>plugins/pictureshape/pictureshape.desktop <span style="color: grey">(8537bb4)</span></li>
<li>plugins/pluginshape/pluginshape.desktop <span style="color: grey">(0272806)</span></li>
<li>plugins/spacenavigator/spacenavigator.desktop <span style="color: grey">(f0d5ce3)</span></li>
<li>plugins/staging/templateshape/templateshape.desktop <span style="color: grey">(eb72a46)</span></li>
<li>plugins/staging/threedshape/threedshape.desktop <span style="color: grey">(8b7817f)</span></li>
<li>plugins/textediting/autocorrection/autocorrect.desktop <span style="color: grey">(da2bd12)</span></li>
<li>plugins/textediting/changecase/changecase.desktop <span style="color: grey">(eb7d2fd)</span></li>
<li>plugins/textediting/spellcheck/spellcheck.desktop <span style="color: grey">(9720f28)</span></li>
<li>plugins/textediting/thesaurus/thesaurustool.desktop <span style="color: grey">(a4db8fb)</span></li>
<li>plugins/textshape/textshape.desktop <span style="color: grey">(f011ba1)</span></li>
<li>plugins/variables/textvariables.desktop <span style="color: grey">(13dfba8)</span></li>
<li>plugins/vectorshape/vectorshape.desktop <span style="color: grey">(ee546df)</span></li>
<li>plugins/videoshape/videoshape.desktop <span style="color: grey">(1e52292)</span></li>
<li>sheets/plugins/calendar/kspread_plugin_tool_calendar.desktop <span style="color: grey">(f6d7ac7)</span></li>
<li>sheets/plugins/scripting/krossmodulesheets.desktop <span style="color: grey">(28ef4d0)</span></li>
<li>sheets/shape/spreadsheetshape-deferred.desktop <span style="color: grey">(a304444)</span></li>
<li>sheets/shape/spreadsheetshape.desktop <span style="color: grey">(4980e6f)</span></li>
<li>stage/part/pageeffects/KPrPageEffectRegistry.cpp <span style="color: grey">(78b9750)</span></li>
<li>stage/part/shapeanimations/KPrShapeAnimationRegistry.cpp <span style="color: grey">(ef6e181)</span></li>
<li>stage/part/tools/animationtool/calligrastagetoolanimation.desktop <span style="color: grey">(f6892fa)</span></li>
<li>stage/plugins/eventactions/calligrastageeventactions.desktop <span style="color: grey">(02b465f)</span></li>
<li>stage/plugins/pageeffects/barwipe/kpr_pageeffect_barwipe.desktop <span style="color: grey">(8ed4249)</span></li>
<li>stage/plugins/pageeffects/clockwipe/kpr_pageeffect_clockwipe.desktop <span style="color: grey">(1fb7730)</span></li>
<li>stage/plugins/pageeffects/edgewipe/kpr_pageeffect_edgewipe.desktop <span style="color: grey">(b2c5d98)</span></li>
<li>stage/plugins/pageeffects/example/kpr_pageeffect_example.desktop <span style="color: grey">(f3d2e4f)</span></li>
<li>stage/plugins/pageeffects/fade/kpr_pageeffect_fade.desktop <span style="color: grey">(a2f6109)</span></li>
<li>stage/plugins/pageeffects/iriswipe/kpr_pageeffect_iriswipe.desktop <span style="color: grey">(9470780)</span></li>
<li>stage/plugins/pageeffects/matrixwipe/kpr_pageeffect_matrixwipe.desktop <span style="color: grey">(cbf1bfb)</span></li>
<li>stage/plugins/pageeffects/slidewipe/kpr_pageeffect_slidewipe.desktop <span style="color: grey">(499765b)</span></li>
<li>stage/plugins/pageeffects/spacerotation/kpr_pageeffect_spacerotation.desktop <span style="color: grey">(244d0d2)</span></li>
<li>stage/plugins/pageeffects/swapeffect/kpr_pageeffect_swapeffect.desktop <span style="color: grey">(2667410)</span></li>
<li>stage/plugins/shapeanimations/example/kpr_shapeanimation_example.desktop <span style="color: grey">(209cb75)</span></li>
<li>stage/plugins/variable/kprvariables.desktop <span style="color: grey">(1279be0)</span></li>
<li>words/plugins/scripting/krossmodulewords.desktop <span style="color: grey">(728994e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108326/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>