<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108228/">http://git.reviewboard.kde.org/r/108228/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 744f4745e59b3b3297da114c9f0b99faa71d53f7 by Friedrich W. H. Kossebau to branch calligra/2.6.</pre>
<br />
<p>- Commit</p>
<br />
<p>On January 6th, 2013, 2:44 p.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Thorsten Zachmann.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Jan. 6, 2013, 2:44 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently KoPAChangePageLayoutCommand & Co. call emitUpdate() on the document, but to no result, as noone is listening to the update() signal of the KoPADocument.
Attached patch changes that for KoPADocumentModel, KoPAView and KPrSlidesSorterDocumentModel. Any other view on KoPAPages I missed?
Simply calling update() everywhere might be inefficient, but follows the handling of any shape changes, so consistent :)
Okay to backport to 2.6?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/kopageapp/KoPADocumentModel.cpp <span style="color: grey">(f51b5e6)</span></li>
<li>libs/kopageapp/KoPAView.cpp <span style="color: grey">(62e9a7b)</span></li>
<li>stage/part/KPrSlidesSorterDocumentModel.cpp <span style="color: grey">(f860024)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108228/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>