<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107717/">http://git.reviewboard.kde.org/r/107717/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 14th, 2012, 4:33 p.m., <b>Marijn Kruisselbrink</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">LGTM</pre>
</blockquote>
<p>On December 19th, 2012, 10:44 a.m., <b>Philip Hoof</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When commtting please use this patch, to avoid conflict on my local branch, using git am (not patch -p1 < etc.diff):
http://mail.kde.org/pipermail/calligra-devel/attachments/20121214/1a18be63/attachment.patch
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi Philip,
could you please update the patch and resent it (calligra-devel or directly to me)? Tried to apply, but someone (well, even me) committed stuff in the meantime so your patch does no longer cleanly apply.
When updating, please also add a line "REVIEW: 107717" to the description, which will trigger the commit hook to close this review request.</pre>
<br />
<p>- Friedrich W. H.</p>
<br />
<p>On December 14th, 2012, 1:39 p.m., Philip Hoof wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Philip Hoof.</div>
<p style="color: grey;"><i>Updated Dec. 14, 2012, 1:39 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">From 6df02b31d66934ac57a4bce123bab8fcc0dbdf82 Mon Sep 17 00:00:00 2001
From: Philip Van Hoof <philip@codeminded.be>
Date: Fri, 14 Dec 2012 14:34:49 +0100
Subject: [PATCH] Move ElapsedTime class to a private header that wont be
installed
This also fixes a old-style-cast problem in the class's destructor
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>sheets/ElapsedTime_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>sheets/Global.h <span style="color: grey">(1759095)</span></li>
<li>sheets/RecalcManager.cpp <span style="color: grey">(c5674f2)</span></li>
<li>sheets/part/CanvasBase.cpp <span style="color: grey">(f973f40)</span></li>
<li>sheets/part/Headers.cpp <span style="color: grey">(f29408f)</span></li>
<li>sheets/part/View.cpp <span style="color: grey">(6a12d45)</span></li>
<li>sheets/DocBase.cpp <span style="color: grey">(d67c66d)</span></li>
<li>sheets/DependencyManager.cpp <span style="color: grey">(60e82e8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107717/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>