<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108131/">http://git.reviewboard.kde.org/r/108131/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit a7c2ae265188c04e5406c917d8573646dd6a4e17 by Friedrich W. H. Kossebau to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On January 3rd, 2013, 6:59 p.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Pierre Stirnweiss and C. Boemann.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Jan. 3, 2013, 6:59 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looked all day at those lines, until I had the need to do something about it :)
Okay?
For the visitor nethods I was not sure if the object to visit should be passed as ref or const ref, as the methods did not really say if they are supposed to be for read-only or modifying visits. So chose ref, to not restrict.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"make test" results as before.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/kotext/KoTextEditor.h <span style="color: grey">(e9e5234)</span></li>
<li>libs/kotext/KoTextEditor.cpp <span style="color: grey">(18a1972)</span></li>
<li>libs/kotext/KoTextEditor_format.cpp <span style="color: grey">(7bd345b)</span></li>
<li>libs/kotext/KoTextEditor_p.h <span style="color: grey">(823e888)</span></li>
<li>libs/kotext/KoTextEditor_undo.cpp <span style="color: grey">(73600d6)</span></li>
<li>libs/kotext/changetracker/KoChangeTracker.h <span style="color: grey">(65ed91f)</span></li>
<li>libs/kotext/changetracker/KoChangeTracker.cpp <span style="color: grey">(dda52c7)</span></li>
<li>libs/kotext/commands/DeleteCommand.cpp <span style="color: grey">(622062a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108131/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>