<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108097/">http://git.reviewboard.kde.org/r/108097/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 3rd, 2013, 5:04 a.m., <b>Inge Wallin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108097/diff/1/?file=104097#file104097line20" style="color: black; font-weight: bold; text-decoration: underline;">filters/words/ascii/ImportDialogUI.ui</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">20</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <number>6</number></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hmm, there seems to be 2 </property> removed but only 1 <property>. Wouldn't that give an invalid xml file?
</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">So right, good catch. Hit that before, but failed to update the patch, not only my branch, before uploading, sorry.</pre>
<br />
<p>- Friedrich W. H.</p>
<br />
<p>On January 3rd, 2013, 12:05 p.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Jan. 3, 2013, 12:05 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There are a few left-overs from <Qt4 times were it was fashion to use KDialog::spacingHint and KDialog::marginHint as well as hardcode the default spacing/margin with values that seemed sane (who imagined the code to still be in use with displays one did not even dream of).
No longer needed these days, as the styles care for proper spacings. Only exception is "margin=0", which means no margin here and is still useful and needed.
Spared out Kexi, Krita and Plan UI files in this RR, as they seem to be full of pixel-optimized layouting, will need more time for those.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looked at all UI files with designer, looked all okay/better.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/flow/imageexport/flow_imageexportwidget.ui <span style="color: grey">(05fe6f9)</span></li>
<li>filters/words/ascii/ImportDialogUI.ui <span style="color: grey">(eec1a36)</span></li>
<li>libs/main/KoDetailsPaneBase.ui <span style="color: grey">(1bb80f0)</span></li>
<li>libs/main/KoOpenPaneBase.ui <span style="color: grey">(b824720)</span></li>
<li>libs/main/config/KoConfigAuthorPage.ui <span style="color: grey">(2a3aea4)</span></li>
<li>libs/main/koDocumentInfoAboutWidget.ui <span style="color: grey">(1695ae4)</span></li>
<li>libs/main/koDocumentInfoAuthorWidget.ui <span style="color: grey">(c6a9da9)</span></li>
<li>libs/widgets/KoCsvImportDialog.ui <span style="color: grey">(645cf64)</span></li>
<li>plugins/textshape/dialogs/FontDecorations.ui <span style="color: grey">(2f9aca1)</span></li>
<li>plugins/variables/FixedDateFormat.ui <span style="color: grey">(ff181ac)</span></li>
<li>sheets/dialogs/DataFormatWidget.ui <span style="color: grey">(5205d22)</span></li>
<li>sheets/dialogs/FontWidget.ui <span style="color: grey">(d0cb129)</span></li>
<li>sheets/dialogs/PositionWidget.ui <span style="color: grey">(2b5dedb)</span></li>
<li>sheets/dialogs/ProtectionWidget.ui <span style="color: grey">(62f20d7)</span></li>
<li>sheets/dialogs/SpecialPasteWidget.ui <span style="color: grey">(623d107)</span></li>
<li>sheets/dialogs/SubtotalWidget.ui <span style="color: grey">(1a68bf7)</span></li>
<li>sheets/part/dialogs/SheetPropertiesWidget.ui <span style="color: grey">(bb73166)</span></li>
<li>sheets/part/dialogs/SheetSelectWidget.ui <span style="color: grey">(3842e7a)</span></li>
<li>sheets/plugins/scripting/scripts/htmlexportinfos.ui <span style="color: grey">(214ed86)</span></li>
<li>sheets/plugins/solver/SolverDetailsWidget.ui <span style="color: grey">(18a09d7)</span></li>
<li>sheets/plugins/solver/SolverMainWidget.ui <span style="color: grey">(d57e35b)</span></li>
<li>words/part/dialogs/KWStartupWidget.ui <span style="color: grey">(c198d88)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108097/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>