<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108049/">http://git.reviewboard.kde.org/r/108049/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 31st, 2012, 2:09 p.m., <b>Lukáš Tvrdý</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108049/diff/1/?file=103402#file103402line250" style="color: black; font-weight: bold; text-decoration: underline;">krita/ui/tool/kis_tool_freehand_helper.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KisToolFreehandHelper::initPaint(KoPointerEvent *event,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">168</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">}</span> <span class="k">else</span> <span class="p">{</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please, don't remove the option where you can completely turn off smoothing.
It can be useful for some brush engines that require raw mouse/tablet input and which do some kind of own smoothing or interpret the raw input somehow. E.g. experimental (Shape) brush engine in some settings is nice with non-smooth strokes.
There might exists some smoothing also on driver level? And users might want to test that smoothing too, so let's give him this option. </pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hm, well -- the issue is that we never actually give raw input. The old unsmoothed option paints a straight line between the positions we receive -- but doesn't really interpolate between those points.</pre>
<br />
<p>- Boudewijn</p>
<br />
<p>On December 31st, 2012, 1:01 p.m., Boudewijn Rempt wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Cyrille Berger Skott, Dmitry Kazakov, Lukáš Tvrdý, and Sven Langkamp.</div>
<div>By Boudewijn Rempt.</div>
<p style="color: grey;"><i>Updated Dec. 31, 2012, 1:01 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch ports the smoothing algorithm from http://www24.atwiki.jp/sigetch_2007/pages/17.html (as implemented in Gimp 2.8) to Krita. The previous smoothing algorithm now is the unsmoothed default, and the old completely unsmoothed option has gone.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Animtim has tested the branch:
14:00:14 < Animtim_> boud: perfect
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=281267">281267</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/image/brushengine/kis_paint_information.h <span style="color: grey">(0142a33)</span></li>
<li>krita/image/kis_distance_information.h <span style="color: grey">(c1ab409)</span></li>
<li>krita/plugins/paintops/libpaintop/sensors/kis_dynamic_sensors.cc <span style="color: grey">(16473f5)</span></li>
<li>krita/plugins/tools/defaulttools/kis_tool_brush.h <span style="color: grey">(f849233)</span></li>
<li>krita/plugins/tools/defaulttools/kis_tool_brush.cc <span style="color: grey">(536b81d)</span></li>
<li>krita/ui/tool/kis_tool_freehand.h <span style="color: grey">(ee915d8)</span></li>
<li>krita/ui/tool/kis_tool_freehand.cc <span style="color: grey">(5640a4b)</span></li>
<li>krita/ui/tool/kis_tool_freehand_helper.h <span style="color: grey">(4978c85)</span></li>
<li>krita/ui/tool/kis_tool_freehand_helper.cpp <span style="color: grey">(dde51ea)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108049/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>