<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108022/">http://git.reviewboard.kde.org/r/108022/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
 <br />







<p>- Pierre</p>


<br />
<p>On December 31st, 2012, 12:18 p.m., C. Boemann wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Calligra.</div>
<div>By C. Boemann.</div>


<p style="color: grey;"><i>Updated Dec. 31, 2012, 12:18 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Change the way we draw markings of speeling errors. Instead of using the qt way we draw it ourselve
This has the following benefits:
  - we don't have to relayout after finding spelling errors
  - we can have more than one type of marking (spelling, grammar, etc)

This commit also changes the way we ask for spellchecking to be performed. The old way had some
shortcommings that could lead to text not being checked at all
</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">played around with it</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>libs/kotext/KoTextBlockData.h <span style="color: grey">(05db499)</span></li>

 <li>libs/kotext/KoTextBlockData.cpp <span style="color: grey">(b1d7d5c)</span></li>

 <li>libs/kotext/KoTextEditingPlugin.h <span style="color: grey">(7b7b9dd)</span></li>

 <li>libs/textlayout/KoTextLayoutArea.h <span style="color: grey">(94c52ec)</span></li>

 <li>libs/textlayout/KoTextLayoutArea_paint.cpp <span style="color: grey">(2fc2131)</span></li>

 <li>libs/textlayout/KoTextLayoutRootAreaProvider.h <span style="color: grey">(d8c0614)</span></li>

 <li>libs/textlayout/KoTextLayoutRootAreaProvider.cpp <span style="color: grey">(7d27944)</span></li>

 <li>plugins/textediting/autocorrection/Autocorrect.h <span style="color: grey">(2a84506)</span></li>

 <li>plugins/textediting/autocorrection/Autocorrect.cpp <span style="color: grey">(e136216)</span></li>

 <li>plugins/textediting/changecase/Changecase.h <span style="color: grey">(8433be1)</span></li>

 <li>plugins/textediting/changecase/Changecase.cpp <span style="color: grey">(936957c)</span></li>

 <li>plugins/textediting/spellcheck/CMakeLists.txt <span style="color: grey">(a4dedef)</span></li>

 <li>plugins/textediting/spellcheck/SpellCheck.h <span style="color: grey">(ee2f7bf)</span></li>

 <li>plugins/textediting/spellcheck/SpellCheck.cpp <span style="color: grey">(4da7e7d)</span></li>

 <li>plugins/textediting/thesaurus/Thesaurus.h <span style="color: grey">(c5de5b0)</span></li>

 <li>plugins/textediting/thesaurus/Thesaurus.cpp <span style="color: grey">(b10a69d)</span></li>

 <li>plugins/textshape/SimpleRootAreaProvider.h <span style="color: grey">(8daf2f8)</span></li>

 <li>plugins/textshape/SimpleRootAreaProvider.cpp <span style="color: grey">(1f3b0fe)</span></li>

 <li>plugins/textshape/TextTool.h <span style="color: grey">(a8a525d)</span></li>

 <li>plugins/textshape/TextTool.cpp <span style="color: grey">(8d43e0a)</span></li>

 <li>words/part/KWRootAreaProvider.h <span style="color: grey">(1908b11)</span></li>

 <li>words/part/KWRootAreaProvider.cpp <span style="color: grey">(9e28045)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108022/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>