<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107996/">http://git.reviewboard.kde.org/r/107996/</a>
     </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit a8b3f36b39bc486fe5b7e92e0f0cee4c5c17b541 by Sven Langkamp to branch master.</pre>
 <br />







<p>- Commit</p>


<br />
<p>On December 29th, 2012, 2:23 a.m., Sven Langkamp wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Calligra.</div>
<div>By Sven Langkamp.</div>


<p style="color: grey;"><i>Updated Dec. 29, 2012, 2:23 a.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The change moves the pencil tool to basicflakes. It used in Krita like the path tool to allow the path to be painted with the current brush. Code is shared between Krita pencil and path tools.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested, works.</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>karbon/plugins/tools/CMakeLists.txt <span style="color: grey">(78ef2f3)</span></li>

 <li>karbon/plugins/tools/CalligraphyTool/KarbonCalligraphicShape.cpp <span style="color: grey">(b2870e8)</span></li>

 <li>karbon/plugins/tools/CalligraphyTool/KarbonCalligraphyTool.cpp <span style="color: grey">(c97158e)</span></li>

 <li>karbon/plugins/tools/CalligraphyTool/KarbonSimplifyPath.cpp <span style="color: grey">(d292508)</span></li>

 <li>karbon/plugins/tools/KarbonCurveFit.h <span style="color: grey">(10e5b20)</span></li>

 <li>karbon/plugins/tools/KarbonCurveFit.cpp <span style="color: grey">(bf92995)</span></li>

 <li>karbon/plugins/tools/KarbonPencilTool.h <span style="color: grey">(2455876)</span></li>

 <li>karbon/plugins/tools/KarbonPencilTool.cpp <span style="color: grey">(0812272)</span></li>

 <li>karbon/plugins/tools/KarbonPencilToolFactory.h <span style="color: grey">(f88ec27)</span></li>

 <li>karbon/plugins/tools/KarbonPencilToolFactory.cpp <span style="color: grey">(7d28f77)</span></li>

 <li>karbon/plugins/tools/KarbonToolsPlugin.cpp <span style="color: grey">(6ddb06f)</span></li>

 <li>krita/data/kritarc <span style="color: grey">(3d96fc9)</span></li>

 <li>krita/plugins/tools/defaulttools/CMakeLists.txt <span style="color: grey">(24ec519)</span></li>

 <li>krita/plugins/tools/defaulttools/default_tools.cc <span style="color: grey">(8ff87a0)</span></li>

 <li>krita/plugins/tools/defaulttools/kis_tool_path.h <span style="color: grey">(f32ee61)</span></li>

 <li>krita/plugins/tools/defaulttools/kis_tool_path.cc <span style="color: grey">(a464af4)</span></li>

 <li>krita/plugins/tools/defaulttools/kis_tool_pencil.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>krita/plugins/tools/defaulttools/kis_tool_pencil.cc <span style="color: grey">(PRE-CREATION)</span></li>

 <li>krita/ui/tool/kis_tool_shape.h <span style="color: grey">(6cdfbb8)</span></li>

 <li>krita/ui/tool/kis_tool_shape.cc <span style="color: grey">(046e0d5)</span></li>

 <li>libs/basicflakes/CMakeLists.txt <span style="color: grey">(48dcdee)</span></li>

 <li>libs/basicflakes/plugin/CMakeLists.txt <span style="color: grey">(e58bb53)</span></li>

 <li>libs/basicflakes/plugin/KoPencilToolFactory.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>libs/basicflakes/plugin/KoPencilToolFactory.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>libs/basicflakes/plugin/Plugin.cpp <span style="color: grey">(54672a9)</span></li>

 <li>libs/basicflakes/tools/KoPencilTool.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>libs/basicflakes/tools/KoPencilTool.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>libs/flake/CMakeLists.txt <span style="color: grey">(11de8f4)</span></li>

 <li>libs/flake/KoCurveFit.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>libs/flake/KoCurveFit.cpp <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107996/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>