<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107979/">http://git.reviewboard.kde.org/r/107979/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 6eebc2be9c303635fbaa6043ec2cdf90bdf6e4a4 by C. Boemann to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On December 28th, 2012, 1:13 p.m., C. Boemann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By C. Boemann.</div>
<p style="color: grey;"><i>Updated Dec. 28, 2012, 1:13 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This commit creates a basicflakes library, which for now holds only the KoCreatePathTool
Krita (used the class to make a superclass - for some special tools) is adapted to use the new library instead of flake.
The library also installs a plugin so the tool is available as before
Final change is that the CreatePath tool no longer has a snapping option widget (in master we already have a new docker which holds the snapping options)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Have reinstalled from scratch and seen that the tools are still there and works.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(ce8f560)</span></li>
<li>krita/CMakeLists.txt <span style="color: grey">(65f1653)</span></li>
<li>krita/plugins/tools/defaulttools/CMakeLists.txt <span style="color: grey">(6a38fc0)</span></li>
<li>krita/plugins/tools/selectiontools/CMakeLists.txt <span style="color: grey">(e77765a)</span></li>
<li>libs/CMakeLists.txt <span style="color: grey">(110c3eb)</span></li>
<li>libs/basicflakes/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/basicflakes/plugin/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/basicflakes/plugin/KoCreatePathToolFactory.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/basicflakes/plugin/KoCreatePathToolFactory.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/basicflakes/plugin/Plugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/basicflakes/plugin/Plugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/basicflakes/plugin/basicflakesplugin.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/basicflakes/tools/KoCreatePathTool.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/basicflakes/tools/KoCreatePathTool.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/basicflakes/tools/KoCreatePathTool_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/CMakeLists.txt <span style="color: grey">(62bc2dc)</span></li>
<li>libs/flake/KoToolRegistry.cpp <span style="color: grey">(0ceb40e)</span></li>
<li>libs/flake/tools/KoCreatePathTool.h <span style="color: grey">(5b0ae7e)</span></li>
<li>libs/flake/tools/KoCreatePathTool.cpp <span style="color: grey">(8dfbe34)</span></li>
<li>libs/flake/tools/KoCreatePathToolFactory.h <span style="color: grey">(1db235e)</span></li>
<li>libs/flake/tools/KoCreatePathToolFactory.cpp <span style="color: grey">(f14139c)</span></li>
<li>libs/flake/tools/KoCreatePathTool_p.h <span style="color: grey">(3bdedd7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107979/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>