<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107990/">http://git.reviewboard.kde.org/r/107990/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 6d9480005ab29f2ca4a69beb0fa02624fdd42de6 by Friedrich W. H. Kossebau to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On December 28th, 2012, 8:02 p.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Dec. 28, 2012, 8:02 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Motivated by the big number of "chances for improvements" reported by krazy for Calligra code and needing a break, here now have some more little code-cleanup.
Basically s/foreach(T t, tList)/foreach(const T &t, tList)/, with some careful looking at each case.
Not always in hot paths, but code gets copied around, so let's have all blueprints using the optimal code, it's only a small footprint and also helps with preventing any unwanted assignments/modifications to the loop value.
Any expensive keys() calls with QMap/QHash are ignored in this patch.
Ignored are also any usages with Q*Shared*Ptr-based types, no real idea what is better, creating another pointer instance or using a const-ref to the original pointer, hints welcome.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No changes in tests.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>active/src/MainWindow.cpp <span style="color: grey">(372761e)</span></li>
<li>filters/sheets/excel/sidewinder/objects.cpp <span style="color: grey">(ccbbffd)</span></li>
<li>filters/sheets/html/htmlimport.cc <span style="color: grey">(cb58365)</span></li>
<li>filters/sheets/xlsx/XlsxXmlWorksheetReader.cpp <span style="color: grey">(99c3eb5)</span></li>
<li>filters/words/epub/OdtHtmlConverter.cpp <span style="color: grey">(d4b7199)</span></li>
<li>filters/words/epub/exportepub2.cpp <span style="color: grey">(84d8a90)</span></li>
<li>filters/words/epub/exporthtml.cpp <span style="color: grey">(bdd33e7)</span></li>
<li>filters/words/mobi/OdtMobiHtmlConverter.cpp <span style="color: grey">(936679d)</span></li>
<li>filters/words/mobi/exportmobi.cpp <span style="color: grey">(662f4c3)</span></li>
<li>kexi/core/kexiactionproxy.cpp <span style="color: grey">(6b56384)</span></li>
<li>kexi/core/kexiprojectdata.cpp <span style="color: grey">(912255b)</span></li>
<li>kexi/core/kexitemplateloader.cpp <span style="color: grey">(dfae6bf)</span></li>
<li>kexi/formeditor/connectiondialog.cpp <span style="color: grey">(a3f48f9)</span></li>
<li>kexi/formeditor/widgetwithsubpropertiesinterface.cpp <span style="color: grey">(e57001e)</span></li>
<li>kexi/main/startup/KexiStartup.cpp <span style="color: grey">(0b23a1a)</span></li>
<li>kexi/plugins/scripting/kexidb/kexidbmodule.cpp <span style="color: grey">(a282ce0)</span></li>
<li>kexi/plugins/scripting/kexiscripting/kexiscriptdesignview.cpp <span style="color: grey">(4c405bb)</span></li>
<li>kexi/widget/fields/KexiFieldListModel.cpp <span style="color: grey">(3c17ce0)</span></li>
<li>kexi/widget/fields/KexiFieldListView.cpp <span style="color: grey">(591178e)</span></li>
<li>kexi/widget/kexicharencodingcombobox.cpp <span style="color: grey">(f33ceab)</span></li>
<li>kexi/widget/kexidbdrivercombobox.cpp <span style="color: grey">(b8e6641)</span></li>
<li>krita/image/brushengine/kis_paintop_registry.cc <span style="color: grey">(fc88b08)</span></li>
<li>krita/image/kis_filter_strategy.cc <span style="color: grey">(1e397d7)</span></li>
<li>krita/image/kis_math_toolbox.cpp <span style="color: grey">(8f465cb)</span></li>
<li>krita/image/kis_paint_layer.cc <span style="color: grey">(af16df2)</span></li>
<li>krita/image/metadata/kis_meta_data_filter_registry.cc <span style="color: grey">(e459524)</span></li>
<li>krita/image/metadata/kis_meta_data_filter_registry_model.cc <span style="color: grey">(172d5fc)</span></li>
<li>krita/image/metadata/kis_meta_data_io_backend.cc <span style="color: grey">(6462b18)</span></li>
<li>krita/image/metadata/kis_meta_data_merge_strategy_registry.cc <span style="color: grey">(c908560)</span></li>
<li>krita/image/recorder/kis_recorded_action_factory_registry.cc <span style="color: grey">(8303f98)</span></li>
<li>krita/image/recorder/kis_recorded_path_paint_action.cpp <span style="color: grey">(c145c35)</span></li>
<li>krita/image/tests/kis_walkers_test.cpp <span style="color: grey">(d806c87)</span></li>
<li>krita/image/tiles3/kis_memento_manager.cc <span style="color: grey">(4c4d8f6)</span></li>
<li>krita/plugins/extensions/imagesplit/imagesplit.cpp <span style="color: grey">(49d3454)</span></li>
<li>krita/plugins/filters/phongbumpmap/phong_pixel_processor.cpp <span style="color: grey">(3d0eac0)</span></li>
<li>krita/plugins/paintops/libbrush/kis_brush_registry.cpp <span style="color: grey">(44b7671)</span></li>
<li>krita/plugins/paintops/libpaintop/kis_pressure_opacity_option.cpp <span style="color: grey">(ac2efbc)</span></li>
<li>krita/plugins/paintops/mypaint/mypaint_brush_resource.cpp <span style="color: grey">(8d6d557)</span></li>
<li>krita/plugins/tools/selectiontools/kis_tool_select_magnetic.cc <span style="color: grey">(33d6da7)</span></li>
<li>krita/ui/canvas/kis_prescaled_projection.cpp <span style="color: grey">(2d7c541)</span></li>
<li>krita/ui/kis_node_model.cpp <span style="color: grey">(cd320f9)</span></li>
<li>krita/ui/kis_painting_assistant.cc <span style="color: grey">(1f619f2)</span></li>
<li>krita/ui/kis_ui_action_factory_registry.cpp <span style="color: grey">(ba9b221)</span></li>
<li>krita/ui/kis_view2.cpp <span style="color: grey">(193a466)</span></li>
<li>krita/ui/kisexiv2/kis_iptc_io.cpp <span style="color: grey">(aaab941)</span></li>
<li>krita/ui/recorder/kis_recorded_action_creator_factory_registry.cc <span style="color: grey">(3325d8c)</span></li>
<li>krita/ui/widgets/kis_color_space_selector.cc <span style="color: grey">(cfa9f8c)</span></li>
<li>krita/ui/widgets/kis_custom_image_widget.cc <span style="color: grey">(42adf70)</span></li>
<li>krita/ui/widgets/kis_preset_selector_strip.cpp <span style="color: grey">(9c1bd52)</span></li>
<li>libs/db/connection.cpp <span style="color: grey">(97f1234)</span></li>
<li>libs/flake/KoInputDeviceHandlerRegistry.cpp <span style="color: grey">(ff89ac6)</span></li>
<li>libs/kopageapp/KoPAView.cpp <span style="color: grey">(af15c5d)</span></li>
<li>libs/kotext/BibliographyGenerator.cpp <span style="color: grey">(15808cb)</span></li>
<li>libs/kotext/KoTextRdfCore.cpp <span style="color: grey">(3cf32be)</span></li>
<li>libs/kotext/ToCBibGeneratorInfo.cpp <span style="color: grey">(26462da)</span></li>
<li>libs/kotext/opendocument/KoTextWriter_p.cpp <span style="color: grey">(c302522)</span></li>
<li>libs/main/KoFindText.cpp <span style="color: grey">(fd4a691)</span></li>
<li>libs/main/KoModeBox.cpp <span style="color: grey">(fc2852f)</span></li>
<li>libs/main/KoProgressUpdater.cpp <span style="color: grey">(37d148d)</span></li>
<li>libs/main/KoView.cpp <span style="color: grey">(8fbdf1c)</span></li>
<li>libs/odf/KoCellValue.cpp <span style="color: grey">(0c9b379)</span></li>
<li>libs/odf/KoOdfBibliographyConfiguration.cpp <span style="color: grey">(ed567d1)</span></li>
<li>libs/odf/KoShadowStyle.cpp <span style="color: grey">(801116c)</span></li>
<li>libs/textlayout/KoTextLayoutArea.cpp <span style="color: grey">(e672b37)</span></li>
<li>libs/textlayout/RunAroundHelper.cpp <span style="color: grey">(18b4247)</span></li>
<li>libs/widgets/KoCsvImportDialog.cpp <span style="color: grey">(08fb839)</span></li>
<li>libs/widgets/KoResourceServerProvider.cpp <span style="color: grey">(2d927dc)</span></li>
<li>libs/widgets/KoResourceTagging.cpp <span style="color: grey">(85049e4)</span></li>
<li>plan/libs/kernel/kptschedule.cpp <span style="color: grey">(3a81227)</span></li>
<li>plan/libs/kernel/kptschedulerplugin.cpp <span style="color: grey">(5771222)</span></li>
<li>plugins/chartshape/tests/odf/TestLoadingBase.cpp <span style="color: grey">(ede37aa0)</span></li>
<li>plugins/musicshape/core/tests/MusicXmlWriterTest.cpp <span style="color: grey">(7a41bb0)</span></li>
<li>plugins/staging/googledocs/googledocumentservice.cpp <span style="color: grey">(0a34ffc)</span></li>
<li>plugins/textshape/TextTool.cpp <span style="color: grey">(148806c)</span></li>
<li>plugins/textshape/dialogs/BibliographyConfigureDialog.cpp <span style="color: grey">(bed2c6b)</span></li>
<li>plugins/textshape/dialogs/BibliographyTemplate.cpp <span style="color: grey">(03fc0e1)</span></li>
<li>plugins/textshape/dialogs/InsertBibliographyDialog.cpp <span style="color: grey">(0ab89fa)</span></li>
<li>plugins/textshape/dialogs/SimpleParagraphWidget.cpp <span style="color: grey">(7a9b191)</span></li>
<li>sheets/DependencyManager.cpp <span style="color: grey">(60e82e8)</span></li>
<li>sheets/FunctionModuleRegistry.cpp <span style="color: grey">(6aa2dd2)</span></li>
<li>sheets/StyleManager.cpp <span style="color: grey">(0754afc)</span></li>
<li>sheets/commands/AutoFillCommand.cpp <span style="color: grey">(41601e7)</span></li>
<li>sheets/part/dialogs/SheetSelectPage.cpp <span style="color: grey">(7858bfb)</span></li>
<li>sheets/plugins/scripting/ScriptingPart.cpp <span style="color: grey">(e606c69)</span></li>
<li>sheets/plugins/scripting/ScriptingWidgets.cpp <span style="color: grey">(cd11b3b)</span></li>
<li>sheets/plugins/solver/Solver.cpp <span style="color: grey">(8cb4290)</span></li>
<li>stage/part/KPrCustomSlideShows.cpp <span style="color: grey">(e23fd90)</span></li>
<li>stage/part/KPrCustomSlideShowsModel.cpp <span style="color: grey">(9870494)</span></li>
<li>stage/part/animations/strategy/KPrSmilValues.cpp <span style="color: grey">(25e4f97)</span></li>
<li>stage/part/commands/KPrDeleteSlidesCommand.cpp <span style="color: grey">(3cf536a)</span></li>
<li>words/part/KWDocument.cpp <span style="color: grey">(3298086)</span></li>
<li>words/part/KWOdfWriter.cpp <span style="color: grey">(f209e0c)</span></li>
<li>words/part/KWView.cpp <span style="color: grey">(a992bde)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107990/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>