<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107530/">http://git.reviewboard.kde.org/r/107530/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 19th, 2012, 10:29 p.m., <b>Jarosław Staniek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107530/diff/8/?file=100154#file100154line41" style="color: black; font-weight: bold; text-decoration: underline;">libs/widgets/KoGroupButton.cpp</a>
<span style="font-weight: normal;">
(Diff revision 8)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KoGroupButton::KoGroupButton(GroupPosition position, QWidget* parent)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">41</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="o">:</span> <span class="n">d</span><span class="p">(</span><span class="k">new</span> <span class="n">Private</span><span class="p">(</span><span class="n">position</span><span class="p">))</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Missing QToolButton(parent) call, what makes the widget invisible and uninitialized.</pre>
</blockquote>
<p>On December 22nd, 2012, 1:53 p.m., <b>Jean-Nicolas Artaud</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't understand.. what is invisible on the screenshot ?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">parent widget wasn't set properly, it's fixed in https://git.reviewboard.kde.org/r/107842/</pre>
<br />
<p>- Jarosław</p>
<br />
<p>On December 22nd, 2012, 4:07 p.m., Jean-Nicolas Artaud wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and C. Boemann.</div>
<div>By Jean-Nicolas Artaud.</div>
<p style="color: grey;"><i>Updated Dec. 22, 2012, 4:07 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Implement triple button widget in the calligra widget libs.
This also can be used for double buttons (like in gwenview for instance).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use the triple button on the property docker.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/widgets/CMakeLists.txt <span style="color: grey">(10e4e09)</span></li>
<li>libs/widgets/KoGroupButton.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/widgets/KoGroupButton.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107530/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/107530/s/865/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/12/03/StrokePropertiesDocker_400x100.jpg" style="border: 1px black solid;" alt="Strocke properties docker with the triple buttons" /></a>
<a href="http://git.reviewboard.kde.org/r/107530/s/869/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/12/04/fenetre_400x100.jpg" style="border: 1px black solid;" alt="MS Word uses it every where" /></a>
<a href="http://git.reviewboard.kde.org/r/107530/s/875/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/12/06/StrokePropertiesDocker-normalmode_400x100.jpg" style="border: 1px black solid;" alt="Normal Mode, Normal Size" /></a>
<a href="http://git.reviewboard.kde.org/r/107530/s/876/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/12/06/StrokePropertiesDocker-flatmode_400x100.jpg" style="border: 1px black solid;" alt="Flat Mode, Normal Size" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>