<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107842/">http://git.reviewboard.kde.org/r/107842/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit c0bb371a5e17489e7aaa48f5db2570996f9d1e12 by Jaroslaw Staniek to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On December 21st, 2012, 11:16 p.m., Jarosław Staniek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Jean-Nicolas Artaud, Adam Pigg, Dimitrios Tanis, Radosław Wicik, and Oleg Kukharchuk.</div>
<div>By Jarosław Staniek.</div>
<p style="color: grey;"><i>Updated Dec. 21, 2012, 11:16 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Introduce kowidgetutils library to Calligra libs 2.7 and put KoGroupButton in it.
The KoGroupButton's code is untouched (except for the EXPORT name) and comes from Jean-Nicolas Artaud - see https://git.reviewboard.kde.org/r/107530 so please do not report issues related to it here. In that patch KoGroupButton was put into kowidgets library what's suboptimal because of dependencies - no point to depend on kotext, etc. to use one unrelated widget.
This change is s small step to increase modularity.
More classes to come here, including improvements to KoGroupButton.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested in Kexi</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/CMakeLists.txt <span style="color: grey">(531873f7e8fb3c8f1f7f49d3d355e9f6e537ac2b)</span></li>
<li>libs/widgetutils/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/widgetutils/KoGroupButton.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/widgetutils/KoGroupButton.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/widgetutils/README <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/widgetutils/kowidgetutils_export.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107842/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>